You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/02 23:54:39 UTC
[GitHub] [skywalking] xbkaishui opened a new issue #5430: Agent support dynamic load config without restart instance
xbkaishui opened a new issue #5430:
URL: https://github.com/apache/skywalking/issues/5430
Please answer these questions before submitting your issue.
- Why do you submit this issue?
- [ ] Question or discussion
- [ ] Bug
- [ ] Requirement
- [√] Feature or performance improvement
___
### Requirement or improvement
- Please describe your requirements or improvement suggestions.
For some scenario, we need change some configration of agent such as samplingRate, collect http params swith, this is more flexible to dynamic change the config without restart instance. can we add it as feature ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-686153842
You'd better change the config through the `Command` responded from the backend when heart beating, instead of reloading the config file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690986173
> Ok,your mean is monitor agent.conf file change?
No, we don't recommend doing this.
> I think in agent side, we can just dynamic change Config and Plugin related Config
Yes, I prefer this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690934142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-687042133
Yes, I agree it's better to config through backend command
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] cheetah012 commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
cheetah012 commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-693146828
Our approach here is to add a grpc interface. The agent side pulls the configuration information from the server every 60 seconds
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng closed issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5430:
URL: https://github.com/apache/skywalking/issues/5430
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-686217500
Loading dynamic config from file is fine. But like backend, it should through another file, not agent.config.
Read backend es username password update.
Of course, through backend dynamic config is super.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wtsoftware commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wtsoftware commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-689438269
use jvm attach agent，Is this method feasible？rebuild the agent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-693148204
> Our approach here is to add a grpc interface. The agent side pulls the configuration information from the server every 60 seconds
The command system is there. It would be easy to use that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wtsoftware commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wtsoftware commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690896065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690934142
No, I think in agent side, we can just dynamic change Config and Plugin related Config
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690986173
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wtsoftware commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wtsoftware commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690896065
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-686216377
Ok, sound good to me，let me check logic and see how to implement it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wtsoftware commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wtsoftware commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690896065
> > attach agent
>
> It provides limited features, and it is not matching SkyWalking's requirement.
Ok,your mean is monitor agent.conf file change? and call ServiceManager.shutdonw ->initializeCoreConfig->ServiceManager.boot ，Now follow this procedure to refresh the configuration successfully。 e ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wtsoftware commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wtsoftware commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690896065
> > attach agent
>
> It provides limited features, and it is not matching SkyWalking's requirement.
Ok,your mean is monitor agent.conf file change? and call ServiceManager.shutdonw ->initializeCoreConfig->ServiceManager.boot ，Now follow this procedure to refresh the configuration successfully。 e ok?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-687692271
Personally, I prefer to provide a file watcher for agent, and the command system only provides a capability to update the dynamic config file.
This provides two capabilities at the same time,
1. Could use backend configuration to update the configuration in batch(eg. all instance of a service)
1. Update one agent config manually.
Especially, terminal-based agent config update is safer in the product environment.
NOTE, not all configuration should support changing dynamically. They should be declared clearly, and if they are going to provide in the upstream release, they must be reviewed manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-689447546
> attach agent
It provides limited features, and it is not matching SkyWalking's requirement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690934142
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #5430: Agent support dynamic load config without restart instance
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5430:
URL: https://github.com/apache/skywalking/issues/5430#issuecomment-690986173
> Ok,your mean is monitor agent.conf file change?
No, we don't recommend doing this.
> I think in agent side, we can just dynamic change Config and Plugin related Config
Yes, I prefer this way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org