[jira] Commented: (HTTPCLIENT-682) ConnectionManager timeout not used

["Wolfgang Winter (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HTTPCLIENT-682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519413 ] 

Wolfgang Winter commented on HTTPCLIENT-682:
--------------------------------------------

This may be true but is not obvious for a simple user of the framework. It is an internal issue that HttpClient uses the SimpleConnectionManager that is not documented. The developer only sees the methods and it's Javadoc and of cause assumes that the method really does what it reclames. I agree that the SimpleConnectionManager does not work with timeout but then make it clear in Javadoc. It took us months to find out why timeout in our application did not work once or twice a month.

> ConnectionManager timeout not used
> ----------------------------------
>
>                 Key: HTTPCLIENT-682
>                 URL: https://issues.apache.org/jira/browse/HTTPCLIENT-682
>             Project: HttpComponents HttpClient
>          Issue Type: Bug
>          Components: HttpClient
>    Affects Versions: 3.0.1
>            Reporter: Wolfgang Winter
>
> In HttpClientParams a connectionManagerTimeout can be set but is never used. The HttpClient uses per default the SimpleHttpConnectionManager, this class implements method getConnectionWithTimeout(
>         HostConfiguration hostConfiguration, long timeout). However, the parameter timeout is not used in the method, despite it's name. The timeout parameter is set with HttpClientParams.connectionManagerTimeout, therefore it is of no use in the standard framework.
> you can fix this by 
> --> correcting the method SimpleHttpConnectionManager.getConnectionWithTimeout()
> --> extending the Javadoc of SimpleHttpConnectionManager.getConnectionWithTimeout() and HttpClientParams.setConnectionManagerTimeout() saying, that the timeout parameter is not used in the standard default implementation.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org