[GitHub] spark pull request #16269: [SPARK-19080][SQL] simplify data source analysis

[gatorsmile <gi...@git.apache.org>]

Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16269#discussion_r99390405
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala ---
    @@ -376,28 +376,6 @@ trait CheckAnalysis extends PredicateHelper {
                      |Conflicting attributes: ${conflictingAttributes.mkString(",")}
                    """.stripMargin)
     
    -          case InsertIntoTable(t, _, _, _, _)
    -            if !t.isInstanceOf[LeafNode] ||
    -              t.isInstanceOf[Range] ||
    -              t == OneRowRelation ||
    -              t.isInstanceOf[LocalRelation] =>
    -            failAnalysis(s"Inserting into an RDD-based table is not allowed.")
    --- End diff --
    
    To other reviewers: This is moved to `PreWriteCheck`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org