You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Nitay Joffe (JIRA)" <ji...@apache.org> on 2008/12/08 10:10:44 UTC
[jira] Created: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
QuorumPeer.getClientPort() always returns -1
--------------------------------------------
Key: ZOOKEEPER-249
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
Project: Zookeeper
Issue Type: Bug
Reporter: Nitay Joffe
Priority: Trivial
This was changed in SVN 700690:
http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar reassigned ZOOKEEPER-249:
---------------------------------------
Assignee: Nitay Joffe
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated ZOOKEEPER-249:
----------------------------------
Status: Patch Available (was: Open)
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.1, 3.0.0
> Reporter: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-249:
------------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I just committed this. Thanks nitay.
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nitay Joffe updated ZOOKEEPER-249:
----------------------------------
Attachment: 249.patch
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Reporter: Nitay Joffe
> Priority: Trivial
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654702#action_12654702 ]
Mahadev konar commented on ZOOKEEPER-249:
-----------------------------------------
+1 the patch looks good.
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654566#action_12654566 ]
Mahadev konar commented on ZOOKEEPER-249:
-----------------------------------------
git checkout is fine... the guidelines is that usually the patch is geenrated from the trunk, so the reviewer does not have to worry abt -p1 or -p2 ... though its good for a starting point :)..
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Nitay Joffe (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654559#action_12654559 ]
Nitay Joffe commented on ZOOKEEPER-249:
---------------------------------------
Besides the ZOOKEEPER- before the name, is my patch okay format wise? It's generated from a git checkout, not an svn one. I think the only difference is you need to use patch -p1 instead of -p0. Otherwise it should work the same.
Thanks,
-n
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mahadev konar updated ZOOKEEPER-249:
------------------------------------
Affects Version/s: 3.0.0
3.0.1
Fix Version/s: 3.1.0
chagingng the fix and affects versions. would be good to have in 3.1.0.
nitay, do you want someone to review the patch? Here is hte process for patch contribution
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute
The patch needs to be submitted and made patch available for someone to review the patch.
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12654581#action_12654581 ]
Patrick Hunt commented on ZOOKEEPER-249:
----------------------------------------
Nitay, try the --no-prefix option next time, that's what I use:
example:
git diff --no-prefix master > ~/Desktop/ZOOKEEPER-249.patch
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-249) QuorumPeer.getClientPort() always
returns -1
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12655214#action_12655214 ]
Hudson commented on ZOOKEEPER-249:
----------------------------------
Integrated in ZooKeeper-trunk #168 (See [http://hudson.zones.apache.org/hudson/job/ZooKeeper-trunk/168/])
> QuorumPeer.getClientPort() always returns -1
> --------------------------------------------
>
> Key: ZOOKEEPER-249
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-249
> Project: Zookeeper
> Issue Type: Bug
> Affects Versions: 3.0.0, 3.0.1
> Reporter: Nitay Joffe
> Assignee: Nitay Joffe
> Priority: Trivial
> Fix For: 3.1.0
>
> Attachments: 249.patch
>
>
> This was changed in SVN 700690:
> http://svn.apache.org/viewvc/hadoop/zookeeper/trunk/src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java?r1=700690&r2=700689&pathrev=700690
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.