You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@arrow.apache.org by Andy Grove <an...@gmail.com> on 2024/03/28 23:21:35 UTC
[VOTE][RUST][DataFusion] Release Apache Arrow DataFusion 37.0.0 RC1
Hi,
I would like to propose a release of Apache Arrow DataFusion Implementation,
version 37.0.0.
This release candidate is based on commit:
799be5e76bd631608b2357dbbe600afc2cebc359 [1]
The proposed release tarball and signatures are hosted at [2].
The changelog is located at [3].
Please download, verify checksums and signatures, run the unit tests, and
vote
on the release. The vote will be open for at least 72 hours.
Only votes from PMC members are binding, but all members of the community
are
encouraged to test the release and vote with "(non-binding)".
The standard verification procedure is documented at
https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
.
[ ] +1 Release this as Apache Arrow DataFusion 37.0.0
[ ] +0
[ ] -1 Do not release this as Apache Arrow DataFusion 37.0.0 because...
Here is my vote:
+1
*NOTE: I had to set RUST_MIN_STACK=3000000 for the tests to pass.*
[1]:
https://github.com/apache/arrow-datafusion/tree/799be5e76bd631608b2357dbbe600afc2cebc359
[2]:
https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.0.0-rc1
[3]:
https://github.com/apache/arrow-datafusion/blob/799be5e76bd631608b2357dbbe600afc2cebc359/CHANGELOG.md
Re: [VOTE][RUST][DataFusion] Release Apache Arrow DataFusion 37.0.0 RC1
Posted by Andrew Lamb <al...@influxdata.com>.
Update here is that Denise did in fact find another regression in 37.0.0
[1] and I verified the same query works in 36.0.0 [2]
There is a PR[3] up to fix it
Andrew
[1]: https://github.com/apache/arrow-datafusion/issues/9870
[2]:
https://github.com/apache/arrow-datafusion/issues/9870#issuecomment-2028018095
[3]: https://github.com/apache/arrow-datafusion/pull/9871
On Fri, Mar 29, 2024 at 12:09 PM Wayne Xia <wa...@gmail.com> wrote:
> +1 (non-binding)
>
> Same here on x86 Linux.
>
> Thanks.
>
> On Fri, Mar 29, 2024 at 7:22 PM Andrew Lamb <al...@influxdata.com> wrote:
>
> > +1 (binding)
> >
> > Thank you Andy. I likewise had to up the min stack size.
> >
> > FYI we (InfluxData) are still chasing down what we think may be a
> > regression introduced by the TreeNode refactor [1] for certain queries.
> If
> > this turns out to be the case I will coordinate making a patch release.
> >
> > Andrew
> >
> > [1] https://github.com/apache/arrow-datafusion/pull/8891
> >
> > On Thu, Mar 28, 2024 at 10:49 PM L. C. Hsieh <vi...@gmail.com> wrote:
> >
> > > +1 (binding)
> > >
> > > Verified on M3 after setting RUST_MIN_STACK=3000000.
> > >
> > > Thanks Andy.
> > >
> > > On Thu, Mar 28, 2024 at 7:39 PM Andy Grove <an...@gmail.com>
> > wrote:
> > > >
> > > > Yes, I also saw this (both on Ubuntu and Mac), and I had to set
> > > > RUST_MIN_STACK=3000000 for the tests to pass.
> > > >
> > > > I filed https://github.com/apache/arrow-datafusion/issues/9848 to
> > > improve
> > > > the release verification documentation to mention this.
> > > >
> > > >
> > > > On Thu, Mar 28, 2024 at 7:59 PM L. C. Hsieh <vi...@gmail.com>
> wrote:
> > > >
> > > > > I got the following error when running verify-release-candidate.sh:
> > > > >
> > > > > thread 'tpcds_physical_q54' has overflowed its stack
> > > > > fatal runtime error: stack overflow
> > > > > error: test failed, to rerun pass `-p datafusion --test
> > tpcds_planning`
> > > > >
> > > > >
> > > > > On Thu, Mar 28, 2024 at 4:22 PM Andy Grove <an...@gmail.com>
> > > wrote:
> > > > > >
> > > > > > Hi,
> > > > > >
> > > > > > I would like to propose a release of Apache Arrow DataFusion
> > > > > Implementation,
> > > > > > version 37.0.0.
> > > > > >
> > > > > > This release candidate is based on commit:
> > > > > > 799be5e76bd631608b2357dbbe600afc2cebc359 [1]
> > > > > > The proposed release tarball and signatures are hosted at [2].
> > > > > > The changelog is located at [3].
> > > > > >
> > > > > > Please download, verify checksums and signatures, run the unit
> > > tests, and
> > > > > > vote
> > > > > > on the release. The vote will be open for at least 72 hours.
> > > > > >
> > > > > > Only votes from PMC members are binding, but all members of the
> > > community
> > > > > > are
> > > > > > encouraged to test the release and vote with "(non-binding)".
> > > > > >
> > > > > > The standard verification procedure is documented at
> > > > > >
> > > > >
> > >
> >
> https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
> > > > > > .
> > > > > >
> > > > > > [ ] +1 Release this as Apache Arrow DataFusion 37.0.0
> > > > > > [ ] +0
> > > > > > [ ] -1 Do not release this as Apache Arrow DataFusion 37.0.0
> > > because...
> > > > > >
> > > > > > Here is my vote:
> > > > > >
> > > > > > +1
> > > > > >
> > > > > > *NOTE: I had to set RUST_MIN_STACK=3000000 for the tests to
> pass.*
> > > > > >
> > > > > > [1]:
> > > > > >
> > > > >
> > >
> >
> https://github.com/apache/arrow-datafusion/tree/799be5e76bd631608b2357dbbe600afc2cebc359
> > > > > > [2]:
> > > > > >
> > > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.0.0-rc1
> > > > > > [3]:
> > > > > >
> > > > >
> > >
> >
> https://github.com/apache/arrow-datafusion/blob/799be5e76bd631608b2357dbbe600afc2cebc359/CHANGELOG.md
> > > > >
> > >
> >
>
Re: [VOTE][RUST][DataFusion] Release Apache Arrow DataFusion 37.0.0 RC1
Posted by Wayne Xia <wa...@gmail.com>.
+1 (non-binding)
Same here on x86 Linux.
Thanks.
On Fri, Mar 29, 2024 at 7:22 PM Andrew Lamb <al...@influxdata.com> wrote:
> +1 (binding)
>
> Thank you Andy. I likewise had to up the min stack size.
>
> FYI we (InfluxData) are still chasing down what we think may be a
> regression introduced by the TreeNode refactor [1] for certain queries. If
> this turns out to be the case I will coordinate making a patch release.
>
> Andrew
>
> [1] https://github.com/apache/arrow-datafusion/pull/8891
>
> On Thu, Mar 28, 2024 at 10:49 PM L. C. Hsieh <vi...@gmail.com> wrote:
>
> > +1 (binding)
> >
> > Verified on M3 after setting RUST_MIN_STACK=3000000.
> >
> > Thanks Andy.
> >
> > On Thu, Mar 28, 2024 at 7:39 PM Andy Grove <an...@gmail.com>
> wrote:
> > >
> > > Yes, I also saw this (both on Ubuntu and Mac), and I had to set
> > > RUST_MIN_STACK=3000000 for the tests to pass.
> > >
> > > I filed https://github.com/apache/arrow-datafusion/issues/9848 to
> > improve
> > > the release verification documentation to mention this.
> > >
> > >
> > > On Thu, Mar 28, 2024 at 7:59 PM L. C. Hsieh <vi...@gmail.com> wrote:
> > >
> > > > I got the following error when running verify-release-candidate.sh:
> > > >
> > > > thread 'tpcds_physical_q54' has overflowed its stack
> > > > fatal runtime error: stack overflow
> > > > error: test failed, to rerun pass `-p datafusion --test
> tpcds_planning`
> > > >
> > > >
> > > > On Thu, Mar 28, 2024 at 4:22 PM Andy Grove <an...@gmail.com>
> > wrote:
> > > > >
> > > > > Hi,
> > > > >
> > > > > I would like to propose a release of Apache Arrow DataFusion
> > > > Implementation,
> > > > > version 37.0.0.
> > > > >
> > > > > This release candidate is based on commit:
> > > > > 799be5e76bd631608b2357dbbe600afc2cebc359 [1]
> > > > > The proposed release tarball and signatures are hosted at [2].
> > > > > The changelog is located at [3].
> > > > >
> > > > > Please download, verify checksums and signatures, run the unit
> > tests, and
> > > > > vote
> > > > > on the release. The vote will be open for at least 72 hours.
> > > > >
> > > > > Only votes from PMC members are binding, but all members of the
> > community
> > > > > are
> > > > > encouraged to test the release and vote with "(non-binding)".
> > > > >
> > > > > The standard verification procedure is documented at
> > > > >
> > > >
> >
> https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
> > > > > .
> > > > >
> > > > > [ ] +1 Release this as Apache Arrow DataFusion 37.0.0
> > > > > [ ] +0
> > > > > [ ] -1 Do not release this as Apache Arrow DataFusion 37.0.0
> > because...
> > > > >
> > > > > Here is my vote:
> > > > >
> > > > > +1
> > > > >
> > > > > *NOTE: I had to set RUST_MIN_STACK=3000000 for the tests to pass.*
> > > > >
> > > > > [1]:
> > > > >
> > > >
> >
> https://github.com/apache/arrow-datafusion/tree/799be5e76bd631608b2357dbbe600afc2cebc359
> > > > > [2]:
> > > > >
> > > >
> >
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.0.0-rc1
> > > > > [3]:
> > > > >
> > > >
> >
> https://github.com/apache/arrow-datafusion/blob/799be5e76bd631608b2357dbbe600afc2cebc359/CHANGELOG.md
> > > >
> >
>
Re: [VOTE][RUST][DataFusion] Release Apache Arrow DataFusion 37.0.0 RC1
Posted by Andrew Lamb <al...@influxdata.com>.
+1 (binding)
Thank you Andy. I likewise had to up the min stack size.
FYI we (InfluxData) are still chasing down what we think may be a
regression introduced by the TreeNode refactor [1] for certain queries. If
this turns out to be the case I will coordinate making a patch release.
Andrew
[1] https://github.com/apache/arrow-datafusion/pull/8891
On Thu, Mar 28, 2024 at 10:49 PM L. C. Hsieh <vi...@gmail.com> wrote:
> +1 (binding)
>
> Verified on M3 after setting RUST_MIN_STACK=3000000.
>
> Thanks Andy.
>
> On Thu, Mar 28, 2024 at 7:39 PM Andy Grove <an...@gmail.com> wrote:
> >
> > Yes, I also saw this (both on Ubuntu and Mac), and I had to set
> > RUST_MIN_STACK=3000000 for the tests to pass.
> >
> > I filed https://github.com/apache/arrow-datafusion/issues/9848 to
> improve
> > the release verification documentation to mention this.
> >
> >
> > On Thu, Mar 28, 2024 at 7:59 PM L. C. Hsieh <vi...@gmail.com> wrote:
> >
> > > I got the following error when running verify-release-candidate.sh:
> > >
> > > thread 'tpcds_physical_q54' has overflowed its stack
> > > fatal runtime error: stack overflow
> > > error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
> > >
> > >
> > > On Thu, Mar 28, 2024 at 4:22 PM Andy Grove <an...@gmail.com>
> wrote:
> > > >
> > > > Hi,
> > > >
> > > > I would like to propose a release of Apache Arrow DataFusion
> > > Implementation,
> > > > version 37.0.0.
> > > >
> > > > This release candidate is based on commit:
> > > > 799be5e76bd631608b2357dbbe600afc2cebc359 [1]
> > > > The proposed release tarball and signatures are hosted at [2].
> > > > The changelog is located at [3].
> > > >
> > > > Please download, verify checksums and signatures, run the unit
> tests, and
> > > > vote
> > > > on the release. The vote will be open for at least 72 hours.
> > > >
> > > > Only votes from PMC members are binding, but all members of the
> community
> > > > are
> > > > encouraged to test the release and vote with "(non-binding)".
> > > >
> > > > The standard verification procedure is documented at
> > > >
> > >
> https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
> > > > .
> > > >
> > > > [ ] +1 Release this as Apache Arrow DataFusion 37.0.0
> > > > [ ] +0
> > > > [ ] -1 Do not release this as Apache Arrow DataFusion 37.0.0
> because...
> > > >
> > > > Here is my vote:
> > > >
> > > > +1
> > > >
> > > > *NOTE: I had to set RUST_MIN_STACK=3000000 for the tests to pass.*
> > > >
> > > > [1]:
> > > >
> > >
> https://github.com/apache/arrow-datafusion/tree/799be5e76bd631608b2357dbbe600afc2cebc359
> > > > [2]:
> > > >
> > >
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.0.0-rc1
> > > > [3]:
> > > >
> > >
> https://github.com/apache/arrow-datafusion/blob/799be5e76bd631608b2357dbbe600afc2cebc359/CHANGELOG.md
> > >
>
Re: [VOTE][RUST][DataFusion] Release Apache Arrow DataFusion 37.0.0 RC1
Posted by "L. C. Hsieh" <vi...@gmail.com>.
+1 (binding)
Verified on M3 after setting RUST_MIN_STACK=3000000.
Thanks Andy.
On Thu, Mar 28, 2024 at 7:39 PM Andy Grove <an...@gmail.com> wrote:
>
> Yes, I also saw this (both on Ubuntu and Mac), and I had to set
> RUST_MIN_STACK=3000000 for the tests to pass.
>
> I filed https://github.com/apache/arrow-datafusion/issues/9848 to improve
> the release verification documentation to mention this.
>
>
> On Thu, Mar 28, 2024 at 7:59 PM L. C. Hsieh <vi...@gmail.com> wrote:
>
> > I got the following error when running verify-release-candidate.sh:
> >
> > thread 'tpcds_physical_q54' has overflowed its stack
> > fatal runtime error: stack overflow
> > error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
> >
> >
> > On Thu, Mar 28, 2024 at 4:22 PM Andy Grove <an...@gmail.com> wrote:
> > >
> > > Hi,
> > >
> > > I would like to propose a release of Apache Arrow DataFusion
> > Implementation,
> > > version 37.0.0.
> > >
> > > This release candidate is based on commit:
> > > 799be5e76bd631608b2357dbbe600afc2cebc359 [1]
> > > The proposed release tarball and signatures are hosted at [2].
> > > The changelog is located at [3].
> > >
> > > Please download, verify checksums and signatures, run the unit tests, and
> > > vote
> > > on the release. The vote will be open for at least 72 hours.
> > >
> > > Only votes from PMC members are binding, but all members of the community
> > > are
> > > encouraged to test the release and vote with "(non-binding)".
> > >
> > > The standard verification procedure is documented at
> > >
> > https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
> > > .
> > >
> > > [ ] +1 Release this as Apache Arrow DataFusion 37.0.0
> > > [ ] +0
> > > [ ] -1 Do not release this as Apache Arrow DataFusion 37.0.0 because...
> > >
> > > Here is my vote:
> > >
> > > +1
> > >
> > > *NOTE: I had to set RUST_MIN_STACK=3000000 for the tests to pass.*
> > >
> > > [1]:
> > >
> > https://github.com/apache/arrow-datafusion/tree/799be5e76bd631608b2357dbbe600afc2cebc359
> > > [2]:
> > >
> > https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.0.0-rc1
> > > [3]:
> > >
> > https://github.com/apache/arrow-datafusion/blob/799be5e76bd631608b2357dbbe600afc2cebc359/CHANGELOG.md
> >
Re: [VOTE][RUST][DataFusion] Release Apache Arrow DataFusion 37.0.0 RC1
Posted by Andy Grove <an...@gmail.com>.
Yes, I also saw this (both on Ubuntu and Mac), and I had to set
RUST_MIN_STACK=3000000 for the tests to pass.
I filed https://github.com/apache/arrow-datafusion/issues/9848 to improve
the release verification documentation to mention this.
On Thu, Mar 28, 2024 at 7:59 PM L. C. Hsieh <vi...@gmail.com> wrote:
> I got the following error when running verify-release-candidate.sh:
>
> thread 'tpcds_physical_q54' has overflowed its stack
> fatal runtime error: stack overflow
> error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
>
>
> On Thu, Mar 28, 2024 at 4:22 PM Andy Grove <an...@gmail.com> wrote:
> >
> > Hi,
> >
> > I would like to propose a release of Apache Arrow DataFusion
> Implementation,
> > version 37.0.0.
> >
> > This release candidate is based on commit:
> > 799be5e76bd631608b2357dbbe600afc2cebc359 [1]
> > The proposed release tarball and signatures are hosted at [2].
> > The changelog is located at [3].
> >
> > Please download, verify checksums and signatures, run the unit tests, and
> > vote
> > on the release. The vote will be open for at least 72 hours.
> >
> > Only votes from PMC members are binding, but all members of the community
> > are
> > encouraged to test the release and vote with "(non-binding)".
> >
> > The standard verification procedure is documented at
> >
> https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
> > .
> >
> > [ ] +1 Release this as Apache Arrow DataFusion 37.0.0
> > [ ] +0
> > [ ] -1 Do not release this as Apache Arrow DataFusion 37.0.0 because...
> >
> > Here is my vote:
> >
> > +1
> >
> > *NOTE: I had to set RUST_MIN_STACK=3000000 for the tests to pass.*
> >
> > [1]:
> >
> https://github.com/apache/arrow-datafusion/tree/799be5e76bd631608b2357dbbe600afc2cebc359
> > [2]:
> >
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.0.0-rc1
> > [3]:
> >
> https://github.com/apache/arrow-datafusion/blob/799be5e76bd631608b2357dbbe600afc2cebc359/CHANGELOG.md
>
Re: [VOTE][RUST][DataFusion] Release Apache Arrow DataFusion 37.0.0 RC1
Posted by "L. C. Hsieh" <vi...@gmail.com>.
I got the following error when running verify-release-candidate.sh:
thread 'tpcds_physical_q54' has overflowed its stack
fatal runtime error: stack overflow
error: test failed, to rerun pass `-p datafusion --test tpcds_planning`
On Thu, Mar 28, 2024 at 4:22 PM Andy Grove <an...@gmail.com> wrote:
>
> Hi,
>
> I would like to propose a release of Apache Arrow DataFusion Implementation,
> version 37.0.0.
>
> This release candidate is based on commit:
> 799be5e76bd631608b2357dbbe600afc2cebc359 [1]
> The proposed release tarball and signatures are hosted at [2].
> The changelog is located at [3].
>
> Please download, verify checksums and signatures, run the unit tests, and
> vote
> on the release. The vote will be open for at least 72 hours.
>
> Only votes from PMC members are binding, but all members of the community
> are
> encouraged to test the release and vote with "(non-binding)".
>
> The standard verification procedure is documented at
> https://github.com/apache/arrow-datafusion/blob/main/dev/release/README.md#verifying-release-candidates
> .
>
> [ ] +1 Release this as Apache Arrow DataFusion 37.0.0
> [ ] +0
> [ ] -1 Do not release this as Apache Arrow DataFusion 37.0.0 because...
>
> Here is my vote:
>
> +1
>
> *NOTE: I had to set RUST_MIN_STACK=3000000 for the tests to pass.*
>
> [1]:
> https://github.com/apache/arrow-datafusion/tree/799be5e76bd631608b2357dbbe600afc2cebc359
> [2]:
> https://dist.apache.org/repos/dist/dev/arrow/apache-arrow-datafusion-37.0.0-rc1
> [3]:
> https://github.com/apache/arrow-datafusion/blob/799be5e76bd631608b2357dbbe600afc2cebc359/CHANGELOG.md