You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@seatunnel.apache.org by GitBox <gi...@apache.org> on 2021/12/28 15:57:28 UTC

[GitHub] [incubator-seatunnel-website] wolfboys opened a new pull request #25: navbar i18n support.

wolfboys opened a new pull request #25:
URL: https://github.com/apache/incubator-seatunnel-website/pull/25


   navbar i18n support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel-website] CalvinKirs commented on a change in pull request #25: navbar i18n support.

Posted by GitBox <gi...@apache.org>.
CalvinKirs commented on a change in pull request #25:
URL: https://github.com/apache/incubator-seatunnel-website/pull/25#discussion_r776125976



##########
File path: src/pages/team/languages.json
##########
@@ -183,7 +183,7 @@
         "email": "kirs@apache.org",
         "gitUrl": "https://github.com/CalvinKirs",
         "githubId": "Calvin Kirs",
-        "name": "Calvin Kirs"
+        "name": "CalvinKirs"

Review comment:
        it should be the ID field does not allow spaces




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel-website] wolfboys commented on a change in pull request #25: navbar i18n support.

Posted by GitBox <gi...@apache.org>.
wolfboys commented on a change in pull request #25:
URL: https://github.com/apache/incubator-seatunnel-website/pull/25#discussion_r776126863



##########
File path: src/pages/team/languages.json
##########
@@ -183,7 +183,7 @@
         "email": "kirs@apache.org",
         "gitUrl": "https://github.com/CalvinKirs",
         "githubId": "Calvin Kirs",
-        "name": "Calvin Kirs"
+        "name": "CalvinKirs"

Review comment:
       ok, fixed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel-website] CalvinKirs merged pull request #25: "Core Features" adaptation issue fixed

Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #25:
URL: https://github.com/apache/incubator-seatunnel-website/pull/25


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-seatunnel-website] wolfboys commented on pull request #25: navbar i18n support.

Posted by GitBox <gi...@apache.org>.
wolfboys commented on pull request #25:
URL: https://github.com/apache/incubator-seatunnel-website/pull/25#issuecomment-1002361960


   @CalvinKirs PTAL again. thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org