You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Jack, Paul" <pj...@sfaf.org> on 2002/05/24 21:49:29 UTC

RE: [PATCH][Collections] SequencedHashMap: equals, hashCode, toSt ring

> Extending AbstractMap is not the right way to add an equals, 
> hashcode and 
> toString method.  I just committed real implementations for 
> the methods.

Was there something wrong with AbstractMap's implementations,
or did you just want to keep SequencedHashMap's superclass
as Object?  I'm just wondering if there's something my 
unit tests aren't catching...

-Paul

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


RE: [PATCH][Collections] SequencedHashMap: equals, hashCode, toSt ring

Posted by "Michael A. Smith" <ma...@apache.org>.
On Fri, 24 May 2002, Jack, Paul wrote:
> > Extending AbstractMap is not the right way to add an equals, 
> > hashcode and 
> > toString method.  I just committed real implementations for 
> > the methods.
> 
> Was there something wrong with AbstractMap's implementations,
> or did you just want to keep SequencedHashMap's superclass
> as Object?  I'm just wondering if there's something my 
> unit tests aren't catching...

Just wanted to keep the superclass as Object.  I suppose it doesn't make 
that much of a difference really, so my statement on it being "not the 
right way" is probably a bit harsh.  Sorry about that.  :)

regards
michael



--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>