[jira] [Commented] (ARIES-1387) Make Subsystem header items order reproducible

["John Ross (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARIES-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14713428#comment-14713428 ] 

John Ross commented on ARIES-1387:
----------------------------------

Have you made this change locally and it works for you? My concern is that in addition to not preserving the ordering, attributes and directives with their default values are added that were not originally there. Do you expect the clauses to be reproduced *exactly* as given or is ordering really the only concern? What about the ordering of attributes and directives within a particular clause?

> Make Subsystem header items order reproducible
> ----------------------------------------------
>
>                 Key: ARIES-1387
>                 URL: https://issues.apache.org/jira/browse/ARIES-1387
>             Project: Aries
>          Issue Type: Improvement
>          Components: Subsystem
>            Reporter: Cristiano Gavião
>
> Currently the org.apache.aries.subsystem.core.archive.SubsystemContentHeader class (line 210) and other headers classes uses a HashSet in order to hold its clauses.
> HashSet doesn't ensure the order of its items and then its impossible to have a reproducible build of any manifest file. As the SubsystemManifest class doesn't provide a equals() method, we can't compare a generated manifest file with any template in a test, it will fail.
> The propose it to change the used HashSet for the LinkedHashSet class.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)