You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by "Sergey Vladimirov (JIRA)" <ji...@apache.org> on 2007/07/04 10:48:04 UTC
[jira] Created: (JXPATH-91) KeyManager should support nodeset
selection
KeyManager should support nodeset selection
-------------------------------------------
Key: JXPATH-91
URL: https://issues.apache.org/jira/browse/JXPATH-91
Project: Commons JXPath
Issue Type: Improvement
Affects Versions: 1.2 Final
Reporter: Sergey Vladimirov
KeyManager should support nodeset selection.
In XSLT standart key() function can return not only singl node, but node set.
KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JXPATH-91) KeyManager should support nodeset
selection
Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510236 ]
Sergey Vladimirov commented on JXPATH-91:
-----------------------------------------
- agree. Will preserve signarute.
- code from computeValue() can't be moved to functionKey(). It should be saved in computeValue, because it's different from compute() case.
- getNodeSetByKey() removed
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Attachments: source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Commented: (JXPATH-91) KeyManager should support nodeset
selection
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510214 ]
Matt Benson commented on JXPATH-91:
-----------------------------------
This looks reasonable. A couple of points with your source patch:
- You have changed the signature of the protected functionKey() method in CoreFunction. All the followup code from computeValue() should be moved there and the signature preserved.
- I see no need for NodePointer to implement the selectNodeSet... method; the JXPathContext is available in functionKey() so the method defined on the context should be sufficient.
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Attachments: source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (JXPATH-91) KeyManager should support nodeset
selection
Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Vladimirov updated JXPATH-91:
------------------------------------
Attachment: testcase-patch.txt
Test case patch totest the feature
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Attachments: source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Issue Comment Edited: (JXPATH-91) KeyManager should support
nodeset selection
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510799 ]
Matt Benson edited comment on JXPATH-91 at 7/6/07 2:31 PM:
-----------------------------------------------------------
I have committed the basic change. I made some tweaks, including supporting a NodeSet for 2nd key() argument and support for passing in the context as the third key() argument.
was:
I have committed the basic change. I made some tweaks, including supporting multivalues for 2nd key() argument and support for passing in the context as the third key() argument.
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Fix For: 1.3
>
> Attachments: source-patch.txt, source-patch.txt, source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Resolved: (JXPATH-91) KeyManager should support nodeset
selection
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matt Benson resolved JXPATH-91.
-------------------------------
Resolution: Fixed
Fix Version/s: 1.3
I have committed the basic change. I made some tweaks, including supporting multivalues for 2nd key() argument and support for passing in the context as the third key() argument.
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Fix For: 1.3
>
> Attachments: source-patch.txt, source-patch.txt, source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (JXPATH-91) KeyManager should support nodeset
selection
Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Vladimirov updated JXPATH-91:
------------------------------------
Attachment: source-patch.txt
Source Code patch to implement feature
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Attachments: source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (JXPATH-91) KeyManager should support nodeset
selection
Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Vladimirov updated JXPATH-91:
------------------------------------
Attachment: source-patch.txt
Remove reformat of apache code
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Attachments: source-patch.txt, source-patch.txt, source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Updated: (JXPATH-91) KeyManager should support nodeset
selection
Posted by "Sergey Vladimirov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sergey Vladimirov updated JXPATH-91:
------------------------------------
Attachment: source-patch.txt
Patch for source code is updated using Matt comments.
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Attachments: source-patch.txt, source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org
[jira] Issue Comment Edited: (JXPATH-91) KeyManager should support
nodeset selection
Posted by "Matt Benson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JXPATH-91?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12510214 ]
Matt Benson edited comment on JXPATH-91 at 7/4/07 8:27 AM:
-----------------------------------------------------------
This looks reasonable. A couple of issues with your source patch:
- You have changed the signature of the protected functionKey() method in CoreFunction. All the followup code from computeValue() should be moved there and the signature preserved.
- I see no need for NodePointer to implement getNodeSetByKey(); the JXPathContext is available in functionKey() so the method defined on the context should be sufficient.
was:
This looks reasonable. A couple of points with your source patch:
- You have changed the signature of the protected functionKey() method in CoreFunction. All the followup code from computeValue() should be moved there and the signature preserved.
- I see no need for NodePointer to implement the selectNodeSet... method; the JXPathContext is available in functionKey() so the method defined on the context should be sufficient.
> KeyManager should support nodeset selection
> -------------------------------------------
>
> Key: JXPATH-91
> URL: https://issues.apache.org/jira/browse/JXPATH-91
> Project: Commons JXPath
> Issue Type: Improvement
> Affects Versions: 1.2 Final
> Reporter: Sergey Vladimirov
> Attachments: source-patch.txt, testcase-patch.txt
>
>
> KeyManager should support nodeset selection.
> In XSLT standart key() function can return not only singl node, but node set.
> KeyManager should support such functionality
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org