You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2018/01/29 23:11:01 UTC
Review Request 65413: HIVE-18575 ACID properties usage in jobconf is
ambiguous for MM tables
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/
-----------------------------------------------------------
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a505f576a06c530080fc72dddcd85ba
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa774a85a0bdbcaf78a636ff6593c43e2
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe17030f8fcb56ef8c83b53b8b870c97
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e6216e95d9c13f3a26540ca03e7405e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 13059023516edbb58a9129ba9aa49de7e40129e6
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be973201227da52d8aecf83b3fcc4656b
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd23b84dd150cdc4da63d73657f1b33bb
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d6fb3dabc4c5e77ef68f83617eb48d1
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199c57c109195b85d43e216743a607955
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651927503e7c8c2d9a7d3d415cc9c4ac4
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java eb75308e8393cadf8e69e0e30b303474b89df03e
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c64ed210d8ff14a9f112cd91b7314be
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef0305006a57b7f608e60ddcdf2b6ff474d
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bcbc8f2fe1d793acc7b84f8b99ae67cc
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e648646c5a199aaebf04484b81ff1c12478
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 923372d5b6da42446997051d0758e9aab4881e2e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b1cbf4b669a8919271b25a689af941b
ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b9fbb5cf248d76205e47dbaa113026f
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 9152b4e08a7a1044fc7f844d47ae8e180162b78b
ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 26a96a47f1935de8e985d382b40c8aae604a9880
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc837ea5ba7d8579892b6e7325940120
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a1644f087d260f78e280d07867d81cbc0c
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd66140a273c8c447c0ee93f4f139454
Diff: https://reviews.apache.org/r/65413/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
> On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
> > Line 507 (original), 507 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507>
> >
> > stupid RB won't let me edit my own comment...
> > Previsouly this check was testing for full acid but now just for transactional. Why?
>
> Sergey Shelukhin wrote:
> It's used to skip global limit optimization. As far as I understand this should also be skipped for insert-only tables
>
> Eugene Koifman wrote:
> why is that? For full acid, you have to apply delete events but for MM once you filter the set of files based on getAcidState() it should be just like non-transactional read...
?
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196819
-----------------------------------------------------------
On Feb. 8, 2018, 5:52 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 5:52 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
> On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
> > Line 862 (original), 863 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950137#file1950137line863>
> >
> > is 'job' cloned somewhere between invocations? If not this seems like a bug
>
> Sergey Shelukhin wrote:
> This is existing code. Another strange thing here is that there's job (the field) and jobConf (the parameter), and some code in this methods updates one while some updates the other.
> They are not obviously identical.
> Does it make sense to investigate/fix in a follow-up jira?
bug-for-bug compatibility... sure follow up is fine
> On Feb. 5, 2018, 10:52 a.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
> > Line 507 (original), 507 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507>
> >
> > stupid RB won't let me edit my own comment...
> > Previsouly this check was testing for full acid but now just for transactional. Why?
>
> Sergey Shelukhin wrote:
> It's used to skip global limit optimization. As far as I understand this should also be skipped for insert-only tables
why is that? For full acid, you have to apply delete events but for MM once you filter the set of files based on getAcidState() it should be just like non-transactional read...
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196819
-----------------------------------------------------------
On Feb. 5, 2018, 7:29 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 7:29 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 8943423244
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 1305902351
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d3aa571913
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 07999e2e9e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3eb869d3f6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b67a03f213
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
>
>
> Diff: https://reviews.apache.org/r/65413/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
> > Line 507 (original), 507 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507>
> >
> > stupid RB won't let me edit my own comment...
> > Previsouly this check was testing for full acid but now just for transactional. Why?
>
> Sergey Shelukhin wrote:
> It's used to skip global limit optimization. As far as I understand this should also be skipped for insert-only tables
>
> Eugene Koifman wrote:
> why is that? For full acid, you have to apply delete events but for MM once you filter the set of files based on getAcidState() it should be just like non-transactional read...
>
> Eugene Koifman wrote:
> ?
I already changed it back to full
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196819
-----------------------------------------------------------
On Feb. 9, 2018, 1:52 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2018, 1:52 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
> > Line 862 (original), 863 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950137#file1950137line863>
> >
> > is 'job' cloned somewhere between invocations? If not this seems like a bug
This is existing code. Another strange thing here is that there's job (the field) and jobConf (the parameter), and some code in this methods updates one while some updates the other.
They are not obviously identical.
Does it make sense to investigate/fix in a follow-up jira?
> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
> > Line 202 (original), 202 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950138#file1950138line202>
> >
> > on the client we have isTransactionalTable() to mean MM or full acid and isAcidTable() to mean full acid.
> >
> > Shouldn't this be isAcidRead() to be consistent?
I;m going to change these too.. I see that some code calls is(Full)Acid... && !isInsertOnly.
These methods should be explicit.
> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
> > Line 507 (original), 507 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507>
> >
> > stupid RB won't let me edit my own comment...
> > Previsouly this check was testing for full acid but now just for transactional. Why?
It's used to skip global limit optimization. As far as I understand this should also be skipped for insert-only tables
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196819
-----------------------------------------------------------
On Jan. 29, 2018, 11:12 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 11:12 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a505f576a06c530080fc72dddcd85ba
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa774a85a0bdbcaf78a636ff6593c43e2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe17030f8fcb56ef8c83b53b8b870c97
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e6216e95d9c13f3a26540ca03e7405e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 13059023516edbb58a9129ba9aa49de7e40129e6
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be973201227da52d8aecf83b3fcc4656b
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd23b84dd150cdc4da63d73657f1b33bb
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d6fb3dabc4c5e77ef68f83617eb48d1
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199c57c109195b85d43e216743a607955
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651927503e7c8c2d9a7d3d415cc9c4ac4
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java eb75308e8393cadf8e69e0e30b303474b89df03e
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c64ed210d8ff14a9f112cd91b7314be
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef0305006a57b7f608e60ddcdf2b6ff474d
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bcbc8f2fe1d793acc7b84f8b99ae67cc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e648646c5a199aaebf04484b81ff1c12478
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 923372d5b6da42446997051d0758e9aab4881e2e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b1cbf4b669a8919271b25a689af941b
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b9fbb5cf248d76205e47dbaa113026f
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 9152b4e08a7a1044fc7f844d47ae8e180162b78b
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 26a96a47f1935de8e985d382b40c8aae604a9880
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc837ea5ba7d8579892b6e7325940120
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a1644f087d260f78e280d07867d81cbc0c
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd66140a273c8c447c0ee93f4f139454
>
>
> Diff: https://reviews.apache.org/r/65413/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196819
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java
Lines 1306 (patched)
<https://reviews.apache.org/r/65413/#comment276653>
nit: wouldn't it be better if this removed both props if 'isTxnTable' is false?
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java
Line 862 (original), 863 (patched)
<https://reviews.apache.org/r/65413/#comment276657>
is 'job' cloned somewhere between invocations? If not this seems like a bug
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
Line 202 (original), 202 (patched)
<https://reviews.apache.org/r/65413/#comment276658>
on the client we have isTransactionalTable() to mean MM or full acid and isAcidTable() to mean full acid.
Shouldn't this be isAcidRead() to be consistent?
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
Line 507 (original), 507 (patched)
<https://reviews.apache.org/r/65413/#comment276656>
stupid RB won't let me edit my own comment...
Previsouly this check was testing for full acid but now just for transactional. Why?
ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java
Line 138 (original), 138 (patched)
<https://reviews.apache.org/r/65413/#comment276655>
AcidUtils.isAcidTable() is meant to test for "full acid". Now this code looks confusing. (and I think wrong for insert_only table - will set isTransactional=false. )
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
Lines 377 (patched)
<https://reviews.apache.org/r/65413/#comment276654>
this seems to be set in the caller of setColumnTypes
- Eugene Koifman
On Jan. 29, 2018, 11:12 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 11:12 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a505f576a06c530080fc72dddcd85ba
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa774a85a0bdbcaf78a636ff6593c43e2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe17030f8fcb56ef8c83b53b8b870c97
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e6216e95d9c13f3a26540ca03e7405e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 13059023516edbb58a9129ba9aa49de7e40129e6
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be973201227da52d8aecf83b3fcc4656b
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd23b84dd150cdc4da63d73657f1b33bb
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d6fb3dabc4c5e77ef68f83617eb48d1
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199c57c109195b85d43e216743a607955
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651927503e7c8c2d9a7d3d415cc9c4ac4
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java eb75308e8393cadf8e69e0e30b303474b89df03e
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c64ed210d8ff14a9f112cd91b7314be
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef0305006a57b7f608e60ddcdf2b6ff474d
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bcbc8f2fe1d793acc7b84f8b99ae67cc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e648646c5a199aaebf04484b81ff1c12478
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 923372d5b6da42446997051d0758e9aab4881e2e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b1cbf4b669a8919271b25a689af941b
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b9fbb5cf248d76205e47dbaa113026f
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 9152b4e08a7a1044fc7f844d47ae8e180162b78b
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 26a96a47f1935de8e985d382b40c8aae604a9880
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc837ea5ba7d8579892b6e7325940120
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a1644f087d260f78e280d07867d81cbc0c
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd66140a273c8c447c0ee93f4f139454
>
>
> Diff: https://reviews.apache.org/r/65413/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review197282
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java
Line 1706 (original), 1703 (patched)
<https://reviews.apache.org/r/65413/#comment277408>
should the msg say ACID?
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
Line 545 (original), 545 (patched)
<https://reviews.apache.org/r/65413/#comment277407>
Should the message say ACID?
- Eugene Koifman
On Feb. 9, 2018, 1:46 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2018, 1:46 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/6/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/
-----------------------------------------------------------
(Updated Feb. 9, 2018, 9:46 p.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
Diff: https://reviews.apache.org/r/65413/diff/6/
Changes: https://reviews.apache.org/r/65413/diff/5-6/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/
-----------------------------------------------------------
(Updated Feb. 9, 2018, 1:52 a.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
Diff: https://reviews.apache.org/r/65413/diff/5/
Changes: https://reviews.apache.org/r/65413/diff/4-5/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/
-----------------------------------------------------------
(Updated Feb. 7, 2018, 10:34 p.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 109f4c710e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
Diff: https://reviews.apache.org/r/65413/diff/4/
Changes: https://reviews.apache.org/r/65413/diff/3-4/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
> On Feb. 7, 2018, 11:24 a.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
> > Line 429 (original), 429 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953196#file1953196line429>
> >
> > Below, you left the same compBuilder.setIsAcid(isFullAcid) but here it using isTransactional - why the logical change?
>
> Sergey Shelukhin wrote:
> fixed; this affects whether locks are taken so my understanding is it's also needed for MM
>
> Eugene Koifman wrote:
> it doesn't affect whether locsk are taken. locks are taken for all tables even transactional=false. it affects whether certain entries are made for compactor which is not needed for MM and just pollutes those tables
>
> Sergey Shelukhin wrote:
> I'm not sure what this has to do with compactor. This sets the flag on LockComponent.
> The only place where this flag is used is
> or (LockComponent lc : rqst.getComponent()) {
> if(lc.isSetIsAcid() && !lc.isIsAcid()) {
> //we don't prevent using non-acid resources in a txn but we do lock them
> continue;
> }
>
> Is it valid to treat MM table as non-acid resource?
isAcid here means full acid, so yes. the locks will still be acquired
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196904
-----------------------------------------------------------
On Feb. 8, 2018, 5:52 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 5:52 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
> > Line 429 (original), 429 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953196#file1953196line429>
> >
> > Below, you left the same compBuilder.setIsAcid(isFullAcid) but here it using isTransactional - why the logical change?
fixed; this affects whether locks are taken so my understanding is it's also needed for MM
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
> > Line 4355 (original), 4355 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953201#file1953201line4355>
> >
> > this changes the logic. why?
The comment just above says it's supported for ACID or MM tables :)
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
> > Line 12640 (original), 12640 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953202#file1953202line12640>
> >
> > logic change. why?
Same, see exception message below
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
> > Line 164 (original), 165 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953203#file1953203line165>
> >
> > follow up jira?
Followed up with Thejas, he's saying it will be removed but for now it supports neither, so this should apply to both.
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196904
-----------------------------------------------------------
On Feb. 6, 2018, 3:29 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 3:29 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 8943423244
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 1305902351
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d3aa571913
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 07999e2e9e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3eb869d3f6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b67a03f213
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
>
>
> Diff: https://reviews.apache.org/r/65413/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
> > Line 429 (original), 429 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953196#file1953196line429>
> >
> > Below, you left the same compBuilder.setIsAcid(isFullAcid) but here it using isTransactional - why the logical change?
>
> Sergey Shelukhin wrote:
> fixed; this affects whether locks are taken so my understanding is it's also needed for MM
>
> Eugene Koifman wrote:
> it doesn't affect whether locsk are taken. locks are taken for all tables even transactional=false. it affects whether certain entries are made for compactor which is not needed for MM and just pollutes those tables
>
> Sergey Shelukhin wrote:
> I'm not sure what this has to do with compactor. This sets the flag on LockComponent.
> The only place where this flag is used is
> or (LockComponent lc : rqst.getComponent()) {
> if(lc.isSetIsAcid() && !lc.isIsAcid()) {
> //we don't prevent using non-acid resources in a txn but we do lock them
> continue;
> }
>
> Is it valid to treat MM table as non-acid resource?
>
> Eugene Koifman wrote:
> isAcid here means full acid, so yes. the locks will still be acquired
Fixed based on discussion
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196904
-----------------------------------------------------------
On Feb. 9, 2018, 1:52 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2018, 1:52 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
> On Feb. 7, 2018, 11:24 a.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
> > Line 429 (original), 429 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953196#file1953196line429>
> >
> > Below, you left the same compBuilder.setIsAcid(isFullAcid) but here it using isTransactional - why the logical change?
>
> Sergey Shelukhin wrote:
> fixed; this affects whether locks are taken so my understanding is it's also needed for MM
it doesn't affect whether locsk are taken. locks are taken for all tables even transactional=false. it affects whether certain entries are made for compactor which is not needed for MM and just pollutes those tables
> On Feb. 7, 2018, 11:24 a.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
> > Line 4355 (original), 4355 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953201#file1953201line4355>
> >
> > this changes the logic. why?
>
> Sergey Shelukhin wrote:
> The comment just above says it's supported for ACID or MM tables :)
so you are making an assumption that comment is correct rather than the code...
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196904
-----------------------------------------------------------
On Feb. 8, 2018, 5:52 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 5:52 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
> > Line 429 (original), 429 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953196#file1953196line429>
> >
> > Below, you left the same compBuilder.setIsAcid(isFullAcid) but here it using isTransactional - why the logical change?
>
> Sergey Shelukhin wrote:
> fixed; this affects whether locks are taken so my understanding is it's also needed for MM
>
> Eugene Koifman wrote:
> it doesn't affect whether locsk are taken. locks are taken for all tables even transactional=false. it affects whether certain entries are made for compactor which is not needed for MM and just pollutes those tables
I'm not sure what this has to do with compactor. This sets the flag on LockComponent.
The only place where this flag is used is
or (LockComponent lc : rqst.getComponent()) {
if(lc.isSetIsAcid() && !lc.isIsAcid()) {
//we don't prevent using non-acid resources in a txn but we do lock them
continue;
}
Is it valid to treat MM table as non-acid resource?
> On Feb. 7, 2018, 7:24 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
> > Line 4355 (original), 4355 (patched)
> > <https://reviews.apache.org/r/65413/diff/3/?file=1953201#file1953201line4355>
> >
> > this changes the logic. why?
>
> Sergey Shelukhin wrote:
> The comment just above says it's supported for ACID or MM tables :)
>
> Eugene Koifman wrote:
> so you are making an assumption that comment is correct rather than the code...
I checked with Jesus, he said it's intended to be accoring to the comment.
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196904
-----------------------------------------------------------
On Feb. 9, 2018, 1:52 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2018, 1:52 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196904
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java
Line 429 (original), 429 (patched)
<https://reviews.apache.org/r/65413/#comment276884>
Below, you left the same compBuilder.setIsAcid(isFullAcid) but here it using isTransactional - why the logical change?
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
Line 4355 (original), 4355 (patched)
<https://reviews.apache.org/r/65413/#comment277130>
this changes the logic. why?
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Line 12640 (original), 12640 (patched)
<https://reviews.apache.org/r/65413/#comment277131>
logic change. why?
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java
Line 164 (original), 165 (patched)
<https://reviews.apache.org/r/65413/#comment277132>
follow up jira?
- Eugene Koifman
On Feb. 5, 2018, 7:29 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 7:29 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 8943423244
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 1305902351
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d3aa571913
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 07999e2e9e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3eb869d3f6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b67a03f213
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
>
>
> Diff: https://reviews.apache.org/r/65413/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/
-----------------------------------------------------------
(Updated Feb. 6, 2018, 3:29 a.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 8943423244
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 1305902351
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d3aa571913
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 07999e2e9e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3eb869d3f6
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b67a03f213
ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
Diff: https://reviews.apache.org/r/65413/diff/3/
Changes: https://reviews.apache.org/r/65413/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
> On Feb. 2, 2018, 5:26 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
> > Line 507 (original), 507 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507>
> >
> > This seems to change the logic. isAcidTable() used to mean full acid, but now it less than that...
>
> Sergey Shelukhin wrote:
> Responded on IM :)
I don't see it in IM. Why is this done?
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196778
-----------------------------------------------------------
On Feb. 5, 2018, 7:29 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2018, 7:29 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 8943423244
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 1305902351
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d3aa571913
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 07999e2e9e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3eb869d3f6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b67a03f213
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
>
>
> Diff: https://reviews.apache.org/r/65413/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
> On Feb. 2, 2018, 5:26 p.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
> > Line 507 (original), 507 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507>
> >
> > This seems to change the logic. isAcidTable() used to mean full acid, but now it less than that...
>
> Sergey Shelukhin wrote:
> Responded on IM :)
>
> Eugene Koifman wrote:
> I don't see it in IM. Why is this done?
I'd like an answer
- Eugene
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196778
-----------------------------------------------------------
On Feb. 8, 2018, 5:52 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2018, 5:52 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Feb. 3, 2018, 1:26 a.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
> > Line 507 (original), 507 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507>
> >
> > This seems to change the logic. isAcidTable() used to mean full acid, but now it less than that...
Responded on IM :)
> On Feb. 3, 2018, 1:26 a.m., Eugene Koifman wrote:
> > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java
> > Line 839 (original), 839 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950147#file1950147line839>
> >
> > why is this null? it used to be that a table with "transactional=true" would become full acid - is that still the case? there are a few places where the last param in
> > AcidUtils.setAcidOperationalProperties(conf, true, null);
> > is nulll
updated the comment on the method. That means full ACID (basically, the default)
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196778
-----------------------------------------------------------
On Feb. 6, 2018, 3:29 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2018, 3:29 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 8943423244
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 1305902351
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java d3aa571913
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 07999e2e9e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 3eb869d3f6
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b67a03f213
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
>
>
> Diff: https://reviews.apache.org/r/65413/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
> On Feb. 3, 2018, 1:26 a.m., Eugene Koifman wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
> > Line 507 (original), 507 (patched)
> > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507>
> >
> > This seems to change the logic. isAcidTable() used to mean full acid, but now it less than that...
>
> Sergey Shelukhin wrote:
> Responded on IM :)
>
> Eugene Koifman wrote:
> I don't see it in IM. Why is this done?
>
> Eugene Koifman wrote:
> I'd like an answer
This is the dup of the other comment, the change was already undone in the last revision
- Sergey
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196778
-----------------------------------------------------------
On Feb. 9, 2018, 1:52 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Feb. 9, 2018, 1:52 a.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 67e22f6649
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa7
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/HiveEndPoint.java 3388a34446
> hcatalog/streaming/src/java/org/apache/hive/hcatalog/streaming/mutate/client/lock/Lock.java c2728376b2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 4e928121c7
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java a5e6293a3e
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be9
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd2
> ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 20c2c3294a
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java 090a18852a
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java 430e0fc551
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java 856b026c91
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef030
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e6486
> ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java 3968b0e899
> ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java c8d1589f44
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/BucketingSortingReduceSinkOptimizer.java 0fdff7d853
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 69447d9d34
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java b766791ebc
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 8e587f1cf6
> ql/src/java/org/apache/hadoop/hive/ql/parse/repl/dump/TableExport.java e1cea22005
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b
> ql/src/java/org/apache/hadoop/hive/ql/stats/Partish.java 78f48b169a
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 0e456df19c
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 8945fdf1e7
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a164
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd
> standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/LockComponentBuilder.java de6c718ba9
>
>
> Diff: https://reviews.apache.org/r/65413/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Eugene Koifman <ek...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/#review196778
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java
Line 507 (original), 507 (patched)
<https://reviews.apache.org/r/65413/#comment276614>
This seems to change the logic. isAcidTable() used to mean full acid, but now it less than that...
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java
Line 376 (original), 376 (patched)
<https://reviews.apache.org/r/65413/#comment276615>
compactor doesn't rewrite MM tables. So it always assumed full acid
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java
Line 839 (original), 839 (patched)
<https://reviews.apache.org/r/65413/#comment276617>
why is this null? it used to be that a table with "transactional=true" would become full acid - is that still the case? there are a few places where the last param in
AcidUtils.setAcidOperationalProperties(conf, true, null);
is nulll
- Eugene Koifman
On Jan. 29, 2018, 11:12 p.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65413/
> -----------------------------------------------------------
>
> (Updated Jan. 29, 2018, 11:12 p.m.)
>
>
> Review request for hive and Eugene Koifman.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> .
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a505f576a06c530080fc72dddcd85ba
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa774a85a0bdbcaf78a636ff6593c43e2
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe17030f8fcb56ef8c83b53b8b870c97
> hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e6216e95d9c13f3a26540ca03e7405e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 13059023516edbb58a9129ba9aa49de7e40129e6
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be973201227da52d8aecf83b3fcc4656b
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd23b84dd150cdc4da63d73657f1b33bb
> ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d6fb3dabc4c5e77ef68f83617eb48d1
> ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199c57c109195b85d43e216743a607955
> ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651927503e7c8c2d9a7d3d415cc9c4ac4
> ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java eb75308e8393cadf8e69e0e30b303474b89df03e
> ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c64ed210d8ff14a9f112cd91b7314be
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef0305006a57b7f608e60ddcdf2b6ff474d
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bcbc8f2fe1d793acc7b84f8b99ae67cc
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e648646c5a199aaebf04484b81ff1c12478
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 923372d5b6da42446997051d0758e9aab4881e2e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b1cbf4b669a8919271b25a689af941b
> ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b9fbb5cf248d76205e47dbaa113026f
> ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 9152b4e08a7a1044fc7f844d47ae8e180162b78b
> ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 26a96a47f1935de8e985d382b40c8aae604a9880
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc837ea5ba7d8579892b6e7325940120
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a1644f087d260f78e280d07867d81cbc0c
> ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd66140a273c8c447c0ee93f4f139454
>
>
> Diff: https://reviews.apache.org/r/65413/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 65413: HIVE-18575 ACID properties usage in jobconf
is ambiguous for MM tables
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65413/
-----------------------------------------------------------
(Updated Jan. 29, 2018, 11:12 p.m.)
Review request for hive and Eugene Koifman.
Repository: hive-git
Description
-------
.
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a505f576a06c530080fc72dddcd85ba
hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java 5ee8aadfa774a85a0bdbcaf78a636ff6593c43e2
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java 5e12614cfe17030f8fcb56ef8c83b53b8b870c97
hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java c98d22be2e6216e95d9c13f3a26540ca03e7405e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java 13059023516edbb58a9129ba9aa49de7e40129e6
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java d252279be973201227da52d8aecf83b3fcc4656b
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 68bb168bd23b84dd150cdc4da63d73657f1b33bb
ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java a7dace955d6fb3dabc4c5e77ef68f83617eb48d1
ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java 270b576199c57c109195b85d43e216743a607955
ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java abd42ec651927503e7c8c2d9a7d3d415cc9c4ac4
ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java eb75308e8393cadf8e69e0e30b303474b89df03e
ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java ff2cc0455c64ed210d8ff14a9f112cd91b7314be
ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java 61565ef0305006a57b7f608e60ddcdf2b6ff474d
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java da200049bcbc8f2fe1d793acc7b84f8b99ae67cc
ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java 7b157e648646c5a199aaebf04484b81ff1c12478
ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java 923372d5b6da42446997051d0758e9aab4881e2e
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b1cbf4b669a8919271b25a689af941b
ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java 661446df0b9fbb5cf248d76205e47dbaa113026f
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java 9152b4e08a7a1044fc7f844d47ae8e180162b78b
ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java 26a96a47f1935de8e985d382b40c8aae604a9880
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java 92f005d1dc837ea5ba7d8579892b6e7325940120
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java c6a866a1644f087d260f78e280d07867d81cbc0c
ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java 65508f4ddd66140a273c8c447c0ee93f4f139454
Diff: https://reviews.apache.org/r/65413/diff/2/
Changes: https://reviews.apache.org/r/65413/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin