You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Andreas Schaefer Sr." <sc...@me.com> on 2016/03/15 18:27:38 UTC
Trunk Build Failure
The current trunk of sling fails in the JCR Resource Resolver with these tests:
Failed tests:
JcrModifiablePropertyMapTest>JcrPropertyMapTest.testJCRType:76->JcrPropertyMapTest.testValue:258 expected:<-28800000> but was:<-25200000>
JcrPropertyMapTest.testJCRType:76->testValue:258 expected:<-28800000> but was:<-25200000>
I am running Maven 3.25 on Java 1.8.0_31 on Mac OS X 10.11.
Any ideas if I doing something wrong here?
Cheers - Andy
Re: Trunk Build Failure
Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday 16 March 2016 17:01:01 Andreas Schaefer Sr. wrote:
> There is another issue I encountered. The RAT plugin is complaining about
> IntelliJ Module files (*.iml) files.
>
> I did include the exclude for **/*.iml but that is only local. I will
> include the change to the Parent POM inside the latest project but there
> are other POM files that do not have the exclude.
>
> I discussed this with Robert a while ago but the current Sling will not
> build for anyone using IntelliJ to work with Sling.
That is not true. I'm using IDEA with no special rat configuration and rat
doesn't complain about my *.iml files, see for default IDEA excludes:
http://creadur.apache.org/rat/apache-rat-plugin/rat-mojo.html#useIdeaDefaultExcludes
Regards,
O.
> Cheers - Andy
>
> > On Mar 16, 2016, at 2:46 PM, Andreas Schaefer Sr. <sc...@me.com>
> > wrote:
> >
> > Ok, that did the trick.
> >
> > If I get a setup working I will debug it as I had a similar issue (JCR
> > Calendar issues based on timezones) in the past. I also will see if I can
> > reproduce it consistently.
> >
> > But at least I am now good to test my merge for a pull request.
> >
> > Thanks - Andy
> >
> >> On Mar 16, 2016, at 12:43 AM, Bertrand Delacretaz
> >> <bd...@apache.org> wrote:>>
> >> On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <sc...@me.com>
wrote:
> >>> ...This line is causing the failure:
> >>> Assert.assertEquals(expected.getTimeZone().getRawOffset(),
> >>> actual.getTimeZone().getRawOffset()); ...>>
> >> Makes sense, good catch!
> >>
> >> I have changed the Calendar comparison method in
> >> https://issues.apache.org/jira/browse/SLING-5612, does that fix your
> >> issue?
> >>
> >> Also, if you find a way to reproduce it on any system (with
> >> -Duser.timezone maybe?) please add that info there, I haven't been
> >> able to reproduce it myself.
> >>
> >> -Bertrand
Re: Trunk Build Failure
Posted by "Andreas Schaefer Sr." <sc...@me.com>.
Thanks for the hint. Wasn’t aware that Git would not remove these files during a merge but now I know. A nice “git clean” worked wonders.
- Andy
> On Mar 17, 2016, at 9:58 AM, Oliver Lietz <ap...@oliverlietz.de> wrote:
>
> On Thursday 17 March 2016 09:52:13 Andreas Schaefer Sr. wrote:
>> Ok, took some time to reproduce but it fails in the "Apache Sling Testing
>> Modules Reactor” module.
>>
>> [INFO] Rat check: Summary of files. Unapproved: 3 unknown: 3 generated: 0
>> approved: 1 license.
>>
>> Rat.txt:
>>
>> *******************************
>>
>> Unapproved licenses:
>>
>>
>> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.
>> Development/sling-git-fork/sling/testing/samples/failing-tests/org.apache.sl
>> ing.testing.samples.failingtests.iml
>> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.
>> Development/sling-git-fork/sling/testing/samples/integration-tests/org.apach
>> e.sling.testing.samples.integrationtests.iml
>> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.
>> Development/sling-git-fork/sling/testing/samples/sample-tests/org.apache.sli
>> ng.testing.samples.sampletests.iml
>>
>> *******************************
>>
>> This is done based on my forked project and I will run it on a latest Sling
>> trunk but I think it should be the same.
>
> These modules got removed, see SLING-5611 for details. You have to clean up
> your project.
>
> Regards,
> O.
>
> https://issues.apache.org/jira/browse/SLING-5611 <https://issues.apache.org/jira/browse/SLING-5611>
>
>> Cheers - Andy
>>
>>> On Mar 17, 2016, at 1:11 AM, Robert Munteanu <ro...@apache.org> wrote:
>>>
>>> On Wed, 2016-03-16 at 17:01 -0700, Andreas Schaefer Sr. wrote:
>>>> There is another issue I encountered. The RAT plugin is complaining
>>>> about IntelliJ Module files (*.iml) files.
>>>>
>>>> I did include the exclude for **/*.iml but that is only local. I will
>>>> include the change to the Parent POM inside the latest project but
>>>> there are other POM files that do not have the exclude.
>>>>
>>>> I discussed this with Robert a while ago but the current Sling will
>>>> not build for anyone using IntelliJ to work with Sling.
>>>
>>> Where exactly does this fail?
>>>
>>> Thanks,
>>>
>>> Robert
>>>
>>>> Cheers - Andy
>>>>
>>>>> On Mar 16, 2016, at 2:46 PM, Andreas Schaefer Sr. <schaefera@me.com
>>>>>
>>>>>> wrote:
>>>>> Ok, that did the trick.
>>>>>
>>>>> If I get a setup working I will debug it as I had a similar issue
>>>>> (JCR Calendar issues based on timezones) in the past. I also will
>>>>> see if I can reproduce it consistently.
>>>>>
>>>>> But at least I am now good to test my merge for a pull request.
>>>>>
>>>>> Thanks - Andy
>>>>>
>>>>>> On Mar 16, 2016, at 12:43 AM, Bertrand Delacretaz <bdelacretaz@ap
>>>>>> ache.org> wrote:
>>>>>>
>>>>>> On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <schaefera@
>>>>>>
>>>>>> me.com> wrote:
>>>>>>> ...This line is causing the failure:
>>>>>>> Assert.assertEquals(expected.getTimeZone().getRawOffset(),
>>>>>>> actual.getTimeZone().getRawOffset()); ...
>>>>>>
>>>>>> Makes sense, good catch!
>>>>>>
>>>>>> I have changed the Calendar comparison method in
>>>>>> https://issues.apache.org/jira/browse/SLING-5612, does that fix
>>>>>> your
>>>>>> issue?
>>>>>>
>>>>>> Also, if you find a way to reproduce it on any system (with
>>>>>> -Duser.timezone maybe?) please add that info there, I haven't
>>>>>> been
>>>>>> able to reproduce it myself.
>>>>>>
>>>>>> -Bertrand
Re: Trunk Build Failure
Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Thursday 17 March 2016 09:52:13 Andreas Schaefer Sr. wrote:
> Ok, took some time to reproduce but it fails in the "Apache Sling Testing
> Modules Reactor” module.
>
> [INFO] Rat check: Summary of files. Unapproved: 3 unknown: 3 generated: 0
> approved: 1 license.
>
> Rat.txt:
>
> *******************************
>
> Unapproved licenses:
>
>
> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.
> Development/sling-git-fork/sling/testing/samples/failing-tests/org.apache.sl
> ing.testing.samples.failingtests.iml
> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.
> Development/sling-git-fork/sling/testing/samples/integration-tests/org.apach
> e.sling.testing.samples.integrationtests.iml
> /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.
> Development/sling-git-fork/sling/testing/samples/sample-tests/org.apache.sli
> ng.testing.samples.sampletests.iml
>
> *******************************
>
> This is done based on my forked project and I will run it on a latest Sling
> trunk but I think it should be the same.
These modules got removed, see SLING-5611 for details. You have to clean up
your project.
Regards,
O.
https://issues.apache.org/jira/browse/SLING-5611
> Cheers - Andy
>
> > On Mar 17, 2016, at 1:11 AM, Robert Munteanu <ro...@apache.org> wrote:
> >
> > On Wed, 2016-03-16 at 17:01 -0700, Andreas Schaefer Sr. wrote:
> >> There is another issue I encountered. The RAT plugin is complaining
> >> about IntelliJ Module files (*.iml) files.
> >>
> >> I did include the exclude for **/*.iml but that is only local. I will
> >> include the change to the Parent POM inside the latest project but
> >> there are other POM files that do not have the exclude.
> >>
> >> I discussed this with Robert a while ago but the current Sling will
> >> not build for anyone using IntelliJ to work with Sling.
> >
> > Where exactly does this fail?
> >
> > Thanks,
> >
> > Robert
> >
> >> Cheers - Andy
> >>
> >>> On Mar 16, 2016, at 2:46 PM, Andreas Schaefer Sr. <schaefera@me.com
> >>>
> >>>> wrote:
> >>> Ok, that did the trick.
> >>>
> >>> If I get a setup working I will debug it as I had a similar issue
> >>> (JCR Calendar issues based on timezones) in the past. I also will
> >>> see if I can reproduce it consistently.
> >>>
> >>> But at least I am now good to test my merge for a pull request.
> >>>
> >>> Thanks - Andy
> >>>
> >>>> On Mar 16, 2016, at 12:43 AM, Bertrand Delacretaz <bdelacretaz@ap
> >>>> ache.org> wrote:
> >>>>
> >>>> On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <schaefera@
> >>>>
> >>>> me.com> wrote:
> >>>>> ...This line is causing the failure:
> >>>>> Assert.assertEquals(expected.getTimeZone().getRawOffset(),
> >>>>> actual.getTimeZone().getRawOffset()); ...
> >>>>
> >>>> Makes sense, good catch!
> >>>>
> >>>> I have changed the Calendar comparison method in
> >>>> https://issues.apache.org/jira/browse/SLING-5612, does that fix
> >>>> your
> >>>> issue?
> >>>>
> >>>> Also, if you find a way to reproduce it on any system (with
> >>>> -Duser.timezone maybe?) please add that info there, I haven't
> >>>> been
> >>>> able to reproduce it myself.
> >>>>
> >>>> -Bertrand
Re: Trunk Build Failure
Posted by "Andreas Schaefer Sr." <sc...@me.com>.
Ok, took some time to reproduce but it fails in the "Apache Sling Testing Modules Reactor” module.
[INFO] Rat check: Summary of files. Unapproved: 3 unknown: 3 generated: 0 approved: 1 license.
Rat.txt:
*******************************
Unapproved licenses:
/Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.Development/sling-git-fork/sling/testing/samples/failing-tests/org.apache.sling.testing.samples.failingtests.iml
/Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.Development/sling-git-fork/sling/testing/samples/integration-tests/org.apache.sling.testing.samples.integrationtests.iml
/Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.Development/sling-git-fork/sling/testing/samples/sample-tests/org.apache.sling.testing.samples.sampletests.iml
*******************************
This is done based on my forked project and I will run it on a latest Sling trunk but I think it should be the same.
Cheers - Andy
> On Mar 17, 2016, at 1:11 AM, Robert Munteanu <ro...@apache.org> wrote:
>
> On Wed, 2016-03-16 at 17:01 -0700, Andreas Schaefer Sr. wrote:
>> There is another issue I encountered. The RAT plugin is complaining
>> about IntelliJ Module files (*.iml) files.
>>
>> I did include the exclude for **/*.iml but that is only local. I will
>> include the change to the Parent POM inside the latest project but
>> there are other POM files that do not have the exclude.
>>
>> I discussed this with Robert a while ago but the current Sling will
>> not build for anyone using IntelliJ to work with Sling.
>
> Where exactly does this fail?
>
> Thanks,
>
> Robert
>
>>
>> Cheers - Andy
>>
>>>
>>> On Mar 16, 2016, at 2:46 PM, Andreas Schaefer Sr. <schaefera@me.com
>>>> wrote:
>>>
>>> Ok, that did the trick.
>>>
>>> If I get a setup working I will debug it as I had a similar issue
>>> (JCR Calendar issues based on timezones) in the past. I also will
>>> see if I can reproduce it consistently.
>>>
>>> But at least I am now good to test my merge for a pull request.
>>>
>>> Thanks - Andy
>>>
>>>>
>>>> On Mar 16, 2016, at 12:43 AM, Bertrand Delacretaz <bdelacretaz@ap
>>>> ache.org> wrote:
>>>>
>>>> On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <schaefera@
>>>> me.com> wrote:
>>>>>
>>>>> ...This line is causing the failure:
>>>>> Assert.assertEquals(expected.getTimeZone().getRawOffset(),
>>>>> actual.getTimeZone().getRawOffset()); ...
>>>> Makes sense, good catch!
>>>>
>>>> I have changed the Calendar comparison method in
>>>> https://issues.apache.org/jira/browse/SLING-5612, does that fix
>>>> your
>>>> issue?
>>>>
>>>> Also, if you find a way to reproduce it on any system (with
>>>> -Duser.timezone maybe?) please add that info there, I haven't
>>>> been
>>>> able to reproduce it myself.
>>>>
>>>> -Bertrand
>
Re: Trunk Build Failure
Posted by Robert Munteanu <ro...@apache.org>.
On Wed, 2016-03-16 at 17:01 -0700, Andreas Schaefer Sr. wrote:
> There is another issue I encountered. The RAT plugin is complaining
> about IntelliJ Module files (*.iml) files.
>
> I did include the exclude for **/*.iml but that is only local. I will
> include the change to the Parent POM inside the latest project but
> there are other POM files that do not have the exclude.
>
> I discussed this with Robert a while ago but the current Sling will
> not build for anyone using IntelliJ to work with Sling.
Where exactly does this fail?
Thanks,
Robert
>
> Cheers - Andy
>
> >
> > On Mar 16, 2016, at 2:46 PM, Andreas Schaefer Sr. <schaefera@me.com
> > > wrote:
> >
> > Ok, that did the trick.
> >
> > If I get a setup working I will debug it as I had a similar issue
> > (JCR Calendar issues based on timezones) in the past. I also will
> > see if I can reproduce it consistently.
> >
> > But at least I am now good to test my merge for a pull request.
> >
> > Thanks - Andy
> >
> > >
> > > On Mar 16, 2016, at 12:43 AM, Bertrand Delacretaz <bdelacretaz@ap
> > > ache.org> wrote:
> > >
> > > On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <schaefera@
> > > me.com> wrote:
> > > >
> > > > ...This line is causing the failure:
> > > > Assert.assertEquals(expected.getTimeZone().getRawOffset(),
> > > > actual.getTimeZone().getRawOffset()); ...
> > > Makes sense, good catch!
> > >
> > > I have changed the Calendar comparison method in
> > > https://issues.apache.org/jira/browse/SLING-5612, does that fix
> > > your
> > > issue?
> > >
> > > Also, if you find a way to reproduce it on any system (with
> > > -Duser.timezone maybe?) please add that info there, I haven't
> > > been
> > > able to reproduce it myself.
> > >
> > > -Bertrand
Re: Trunk Build Failure
Posted by "Andreas Schaefer Sr." <sc...@me.com>.
There is another issue I encountered. The RAT plugin is complaining about IntelliJ Module files (*.iml) files.
I did include the exclude for **/*.iml but that is only local. I will include the change to the Parent POM inside the latest project but
there are other POM files that do not have the exclude.
I discussed this with Robert a while ago but the current Sling will not build for anyone using IntelliJ to work with Sling.
Cheers - Andy
> On Mar 16, 2016, at 2:46 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
>
> Ok, that did the trick.
>
> If I get a setup working I will debug it as I had a similar issue (JCR Calendar issues based on timezones) in the past. I also will see if I can reproduce it consistently.
>
> But at least I am now good to test my merge for a pull request.
>
> Thanks - Andy
>
>> On Mar 16, 2016, at 12:43 AM, Bertrand Delacretaz <bd...@apache.org> wrote:
>>
>> On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
>>> ...This line is causing the failure:
>>> Assert.assertEquals(expected.getTimeZone().getRawOffset(), actual.getTimeZone().getRawOffset()); ...
>>
>> Makes sense, good catch!
>>
>> I have changed the Calendar comparison method in
>> https://issues.apache.org/jira/browse/SLING-5612, does that fix your
>> issue?
>>
>> Also, if you find a way to reproduce it on any system (with
>> -Duser.timezone maybe?) please add that info there, I haven't been
>> able to reproduce it myself.
>>
>> -Bertrand
>
Re: Trunk Build Failure
Posted by "Andreas Schaefer Sr." <sc...@me.com>.
Ok, that did the trick.
If I get a setup working I will debug it as I had a similar issue (JCR Calendar issues based on timezones) in the past. I also will see if I can reproduce it consistently.
But at least I am now good to test my merge for a pull request.
Thanks - Andy
> On Mar 16, 2016, at 12:43 AM, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
>> ...This line is causing the failure:
>> Assert.assertEquals(expected.getTimeZone().getRawOffset(), actual.getTimeZone().getRawOffset()); ...
>
> Makes sense, good catch!
>
> I have changed the Calendar comparison method in
> https://issues.apache.org/jira/browse/SLING-5612, does that fix your
> issue?
>
> Also, if you find a way to reproduce it on any system (with
> -Duser.timezone maybe?) please add that info there, I haven't been
> able to reproduce it myself.
>
> -Bertrand
Re: Trunk Build Failure
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Mar 15, 2016 at 9:33 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
> ...This line is causing the failure:
> Assert.assertEquals(expected.getTimeZone().getRawOffset(), actual.getTimeZone().getRawOffset()); ...
Makes sense, good catch!
I have changed the Calendar comparison method in
https://issues.apache.org/jira/browse/SLING-5612, does that fix your
issue?
Also, if you find a way to reproduce it on any system (with
-Duser.timezone maybe?) please add that info there, I haven't been
able to reproduce it myself.
-Bertrand
Re: Trunk Build Failure
Posted by "Andreas Schaefer Sr." <sc...@me.com>.
I knew I saw that before and the issue is the Timezone.
California does already have Daylight Savings Time and I would guess that’s the issue here.
This line is causing the failure:
Assert.assertEquals(expected.getTimeZone().getRawOffset(), actual.getTimeZone().getRawOffset());
inside org.apache.sling.jcr.resource.internal.AssertCalendar.
I cannot figure out where the original instance of the Calendar is switched but I will see if I can get the debugger up (IntelliJ is not cooperating right now).
- Andy
> On Mar 15, 2016, at 12:03 PM, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> On Tue, Mar 15, 2016 at 7:29 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
>> Got the same when checked out the code from SVN:...
>
> Ok, I have no idea what's going on unfortunately, and the build also
> worked on Jenkins earlier today at
> https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.8/2850/org.apache.sling$org.apache.sling.jcr.resource/
>
> Let's see if others have the same issue - and maybe try moving your
> local Maven repository away before building (and get a coffee while
> Maven Downloads The Web Twice).
>
> -Bertrand
Re: Trunk Build Failure
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Mar 15, 2016 at 7:29 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
> Got the same when checked out the code from SVN:...
Ok, I have no idea what's going on unfortunately, and the build also
worked on Jenkins earlier today at
https://builds.apache.org/view/S-Z/view/Sling/job/sling-trunk-1.8/2850/org.apache.sling$org.apache.sling.jcr.resource/
Let's see if others have the same issue - and maybe try moving your
local Maven repository away before building (and get a coffee while
Maven Downloads The Web Twice).
-Bertrand
Re: Trunk Build Failure
Posted by "Andreas Schaefer Sr." <sc...@me.com>.
Got the same when checked out the code from SVN:
Andreass-MacBook-Pro:sling-trunk schaefa$ svn info
Path: .
Working Copy Root Path: /Users/schaefa/Dropbox/Shared.Development/AdobeAEM.projects/HW.AEM.Tooling.Development/apache.svn/sling-trunk
URL: https://svn.apache.org/repos/asf/sling/trunk
Repository Root: https://svn.apache.org/repos/asf
Repository UUID: 13f79535-47bb-0310-9956-ffa450edef68
Revision: 1735153
Node Kind: directory
Schedule: normal
Last Changed Author: bdelacretaz
Last Changed Rev: 1735140
Last Changed Date: 2016-03-15 09:55:42 -0700 (Tue, 15 Mar 2016)
- Andy
> On Mar 15, 2016, at 11:18 AM, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> On Tue, Mar 15, 2016 at 7:11 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
>> ...Do I need to work with SVN?..
>
> That shouldn't make a difference, Git catches up quite quickly AFAIK.
>
> Anyway, I have posted the md5 digests the code that I have, at
> https://paste.apache.org/nlui - if you think you might have a
> difference you can check those.
>
> The pom.xml does not refer to any SNAPSHOT, so beyond that you should
> be using the same libs that I am.
>
> -Bertrand
Re: Trunk Build Failure
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, Mar 15, 2016 at 7:11 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
> ...Do I need to work with SVN?..
That shouldn't make a difference, Git catches up quite quickly AFAIK.
Anyway, I have posted the md5 digests the code that I have, at
https://paste.apache.org/nlui - if you think you might have a
difference you can check those.
The pom.xml does not refer to any SNAPSHOT, so beyond that you should
be using the same libs that I am.
-Bertrand
Re: Trunk Build Failure
Posted by "Andreas Schaefer Sr." <sc...@me.com>.
I use git and this is the latest:
git-svn-id: https://svn.apache.org/repos/asf/sling/trunk@1735140 <ht...@1735140>
Do I need to work with SVN?
- Andy
> On Mar 15, 2016, at 10:44 AM, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> Hi,
>
> On Tue, Mar 15, 2016 at 6:27 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
>> Failed tests:
>> JcrModifiablePropertyMapTest>JcrPropertyMapTest.testJCRType:...
>
> That test passes for me at revision 1735149, with both jdk 1.7 and 1.8.
>
> -Bertrand
Re: Trunk Build Failure
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Tue, Mar 15, 2016 at 6:27 PM, Andreas Schaefer Sr. <sc...@me.com> wrote:
> Failed tests:
> JcrModifiablePropertyMapTest>JcrPropertyMapTest.testJCRType:...
That test passes for me at revision 1735149, with both jdk 1.7 and 1.8.
-Bertrand