You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@trafficserver.apache.org by zw...@apache.org on 2020/06/09 21:47:16 UTC

[trafficserver] branch 9.0.x updated: regex_remap: Adjust regex recursion limit down due to crashes in testing. (#6819)

This is an automated email from the ASF dual-hosted git repository.

zwoop pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/trafficserver.git


The following commit(s) were added to refs/heads/9.0.x by this push:
     new 9c7500e  regex_remap: Adjust regex recursion limit down due to crashes in testing. (#6819)
9c7500e is described below

commit 9c7500e70d4747abb3742de024dc45aaaeabc7ed
Author: Alan M. Carroll <am...@apache.org>
AuthorDate: Tue May 26 19:32:00 2020 -0500

    regex_remap: Adjust regex recursion limit down due to crashes in testing. (#6819)
    
    (cherry picked from commit fe903399337c87b855af39cca6cdacd263fb9307)
---
 plugins/regex_remap/regex_remap.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/plugins/regex_remap/regex_remap.cc b/plugins/regex_remap/regex_remap.cc
index 0426a6c..2720140 100644
--- a/plugins/regex_remap/regex_remap.cc
+++ b/plugins/regex_remap/regex_remap.cc
@@ -394,7 +394,8 @@ RemapRegex::compile(const char *&error, int &erroffset)
     return -1;
   }
 
-  _extra->match_limit_recursion = 2047;
+  // POOMA - also dependent on actual stack size. Crashes with previous value of 2047,
+  _extra->match_limit_recursion = 1750;
   _extra->flags |= PCRE_EXTRA_MATCH_LIMIT_RECURSION;
 
   if (pcre_fullinfo(_rex, _extra, PCRE_INFO_CAPTURECOUNT, &ccount) != 0) {