You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/04/11 19:16:57 UTC
Review Request 33103: Skip known flaky tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen and Brian Wickman.
Repository: aurora
Description
-------
We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
Diffs
-----
src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
Diff: https://reviews.apache.org/r/33103/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 33103: Skip known flaky tests.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/#review79881
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On April 11, 2015, 5:16 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33103/
> -----------------------------------------------------------
>
> (Updated April 11, 2015, 5:16 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
> src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
> src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
>
> Diff: https://reviews.apache.org/r/33103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33103: Skip known flaky tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/#review79807
-----------------------------------------------------------
Ship it!
Master (eb9e408) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 11, 2015, 5:16 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33103/
> -----------------------------------------------------------
>
> (Updated April 11, 2015, 5:16 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
> src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
> src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
>
> Diff: https://reviews.apache.org/r/33103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33103: Skip known flaky tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/#review79934
-----------------------------------------------------------
Ship it!
Master (eb9e408) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On April 13, 2015, 7:44 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33103/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 7:44 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
> src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
> src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
>
> Diff: https://reviews.apache.org/r/33103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33103: Skip known flaky tests.
Posted by Joe Smith <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/#review79931
-----------------------------------------------------------
Ship it!
Ship It!
- Joe Smith
On April 13, 2015, 12:44 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33103/
> -----------------------------------------------------------
>
> (Updated April 13, 2015, 12:44 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
> src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
> src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
>
> Diff: https://reviews.apache.org/r/33103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33103: Skip known flaky tests.
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/
-----------------------------------------------------------
(Updated April 13, 2015, 7:44 p.m.)
Review request for Aurora, Joshua Cohen and Brian Wickman.
Repository: aurora
Description
-------
We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
Diffs (updated)
-----
src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
Diff: https://reviews.apache.org/r/33103/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 33103: Skip known flaky tests.
Posted by Bill Farner <wf...@apache.org>.
> On April 13, 2015, 3:32 p.m., Brian Wickman wrote:
> > Actually could you also mark test_integration_quitquitquit as well? I was trying to address it in https://reviews.apache.org/r/32221/diff/# but don't feel particularly confident about that approach.
Done.
- Bill
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/#review79882
-----------------------------------------------------------
On April 11, 2015, 5:16 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33103/
> -----------------------------------------------------------
>
> (Updated April 11, 2015, 5:16 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
> src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
> src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
>
> Diff: https://reviews.apache.org/r/33103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33103: Skip known flaky tests.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/#review79882
-----------------------------------------------------------
Actually could you also mark test_integration_quitquitquit as well? I was trying to address it in https://reviews.apache.org/r/32221/diff/# but don't feel particularly confident about that approach.
- Brian Wickman
On April 11, 2015, 5:16 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33103/
> -----------------------------------------------------------
>
> (Updated April 11, 2015, 5:16 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
> src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
> src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
>
> Diff: https://reviews.apache.org/r/33103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 33103: Skip known flaky tests.
Posted by Joshua Cohen <jc...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33103/#review79908
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On April 11, 2015, 5:16 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33103/
> -----------------------------------------------------------
>
> (Updated April 11, 2015, 5:16 p.m.)
>
>
> Review request for Aurora, Joshua Cohen and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> We've had very few legitimate build breakages over the last few months, these tests are a major source of illegitimate breakage.
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_announcer.py 6b782778e52394de3744b43003226dac3f65169e
> src/test/python/apache/aurora/executor/test_gc_executor.py 0f0b4a3781295c2a6640d272f9c8b0e8f78cc8a8
> src/test/python/apache/aurora/executor/test_thermos_task_runner.py 6b24bbb2ab7ca16f97961aabeed945b61e5b5908
> src/test/python/apache/thermos/core/test_staged_kill.py b52fcba3c7174a5e4d413b7b01f2fa7d95d21ee1
>
> Diff: https://reviews.apache.org/r/33103/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>