You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "chihumyum (via GitHub)" <gi...@apache.org> on 2026/09/19 14:15:14 UTC

[PR] refactor(desktop): move session settings ownership below AppShell [maka]

chihumyum opened a new pull request, #5509:
URL: https://github.com/apache/maka/pull/5509

   ## Summary
   
   Session-setting write intents currently live in AppShell, so writes for inactive Sessions also re-render the shell. Move their controller into a feature-owned `SessionSettingsProvider`, registered in `controllerOwners`, and leave the shell one equality-selected read of the active Session's model/thinking, permission, Plan and orchestration overlays plus stable commands.
   
   Move the Plan transition policy and its authoritative `getPlanState` read behind feature services. Preserve optimistic rollback, revision-based retirement, captured-owner permission confirmation and the original Session target during Plan confirmation. Shell bridge paths drop from 18 to 17; the existing settings hook remains as a necessary read. Session Collaboration and Plan panel subscriptions remain outside this slice.
   
   Refs #4582.
   
   ## Verification
   
   Rebased onto `main` `852a9748d`; source changes were unchanged by the rebase and the architecture ledger was regenerated.
   
   - Node 24: `build:test`, Desktop `test:dist` **2784/2784**, Desktop typecheck (including stories), production renderer build.
   - Renderer architecture **112/112** and exact-base check; AppShell hook gate; lint, format, Desktop/UI Knip, ASF headers, Astryx and Windows inventories, `git diff --check`.
   - New provider tests cover inactive-Session render isolation, active optimistic rollback, navigation during bypass/Plan confirmations, clearing pending intents, StrictMode cleanup and retained commands after unmount.
   - Plan policy tests cover active execution refusal, canceled discard, normal mode changes and Host read errors; existing settings/controller tests retain model/thinking and causal-retirement coverage.
   - Two temporary source mutations were rejected by the ownership guard: public controller export and a controller import from AppShell.
   - Merge-tree against the current base is clean.
   
   No UI layout or intended user-visible behavior change. Interactive Electron/manual UI acceptance was not run; the behavior and render-scope evidence above comes from feature-level React tests.
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex implemented the ownership migration, tests and documentation, performed source review and validation, and prepared this PR under the contributor's direction. The commit includes `Generated-by: Codex`.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [ ] Yes — described under Summary above
   - [x] No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org


Re: [PR] refactor(desktop): move session settings ownership below AppShell [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han merged PR #5509:
URL: https://github.com/apache/maka/pull/5509


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org