You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by John Dilley <jo...@citrix.com> on 2014/08/05 11:23:38 UTC

Review Request 24304: CLOUDSTACK-7247: Default hypervisor to None in deployVirtualMachine call in marvin base.py

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24304/
-----------------------------------------------------------

Review request for cloudstack and Santhosh Edukulla.


Bugs: CLOUDSTACK-7247
    https://issues.apache.org/jira/browse/CLOUDSTACK-7247


Repository: cloudstack-git


Description
-------

Currently the default hypervisor specified in deployVirtualMachine is XenServer. We've got away with this in the past because it's been ignored when using a template, but now (since the fix for CLOUDSTACK-7194) it either needs to match the template, or be None. I propose that the latter is easier.

This is blocking a lot of tests in CI, so getting it fixed quickly is important.


Diffs
-----

  tools/marvin/marvin/lib/base.py eb05a18 

Diff: https://reviews.apache.org/r/24304/diff/


Testing
-------

In progress on VMWare


Thanks,

John Dilley


Re: Review Request 24304: CLOUDSTACK-7247: Default hypervisor to None in deployVirtualMachine call in marvin base.py

Posted by Gaurav Aradhye <ga...@clogeny.com>.
Hi,

I already submitted patch for this.
https://reviews.apache.org/r/24301/

Regards,
Gaurav


On Tue, Aug 5, 2014 at 2:53 PM, John Dilley <jo...@citrix.com> wrote:

>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24304/
> -----------------------------------------------------------
>
> Review request for cloudstack and Santhosh Edukulla.
>
>
> Bugs: CLOUDSTACK-7247
>     https://issues.apache.org/jira/browse/CLOUDSTACK-7247
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Currently the default hypervisor specified in deployVirtualMachine is
> XenServer. We've got away with this in the past because it's been ignored
> when using a template, but now (since the fix for CLOUDSTACK-7194) it
> either needs to match the template, or be None. I propose that the latter
> is easier.
>
> This is blocking a lot of tests in CI, so getting it fixed quickly is
> important.
>
>
> Diffs
> -----
>
>   tools/marvin/marvin/lib/base.py eb05a18
>
> Diff: https://reviews.apache.org/r/24304/diff/
>
>
> Testing
> -------
>
> In progress on VMWare
>
>
> Thanks,
>
> John Dilley
>
>