You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Vivekanand Koya (Jira)" <ji...@apache.org> on 2025/10/23 05:03:00 UTC
[jira] [Assigned] (CASSANDRA-20984) java.lang.ClassCastException: Issues while joining
[ https://issues.apache.org/jira/browse/CASSANDRA-20984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Vivekanand Koya reassigned CASSANDRA-20984:
-------------------------------------------
Assignee: Vivekanand Koya
> java.lang.ClassCastException: Issues while joining
> --------------------------------------------------
>
> Key: CASSANDRA-20984
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20984
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Consistency/Bootstrap and Decommission, Consistency/Streaming
> Reporter: Vivekanand Koya
> Assignee: Vivekanand Koya
> Priority: Normal
>
> From [~rustyrazorblade]'s recommendation
> I've taken a closer look at the code. I've been able to reproduce the issue and have produced a fix. Along the way, I've noticed a few things.
> # initiateStreaming() method of OutboundConnectionInitiator is called from NettyStreamingConnectionFactory located in the streaming.async package. Similar method invocation initiateMessaging() method of OutboundConnectionInitiator is made from OutboundConnection (net package). Thus, the enum Outcome is package-private. The sanity check based on OutboundConnectionInitiator.Result.Outcome could be performed from OutboundConnection class. The same check cannot be performed from NettyStreamingConnectionFactory since the outcome field of Result is inaccessible.
> # There is an attempt to cast to the generic type SuccessType in OutboundConnectionIntiator.Result class. This behavior is inconsistent with the retry() and incompatible() methods which return their respective classes.
> # In NettyStreamingConnectionFactory, there appears to be some confusion in the involcation of isSuccess() method. It actually is making the invocation on Netty Future. It should have been on the Result object. On making a successful connect, NettyStreamingConnectionFactory calls success() on Future' s getNow() without checking the type of the cast.
> # There are no tests for initiateStreaming() method of OutboundConnectionInitiator as there are for initiateMessaging() method of OutboundConnectionInitiator.
> What I've done. # I wrote a test (StreamingTest) that reproduces the issue in [https://lists.apache.org/thread/ykkwhjdpgyqzw5xtol4v5ysz664bxxl3].
> # I used the instanceof in [https://openjdk.org/jeps/394] to make incorrect comparisons a compile-time error. This is done in OutboundConnection where I check if result.success() instanceof MessagingSuccess and OutboundConnectionInitiator where I return Success safely instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org