You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/11/03 13:52:52 UTC

[GitHub] [incubator-nuttx] hartmannathan opened a new pull request #2202: stm32 - Fix wrong executable permission on header file

hartmannathan opened a new pull request #2202:
URL: https://github.com/apache/incubator-nuttx/pull/2202


   ## Summary
   
   arch/arm/src/stm32/hardware/stm32g47xxx_vrefbuf.h:
   
       * Remove executable permission.
   
   ## Impact
   
   Fixes wrong permission.
   
   ## Testing
   
   Also checked for any additional source files with wrong executable permission using:
   
   `find . -type f -perm +111 -print`
   
   Did not find any others.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea merged pull request #2202: stm32 - Fix wrong executable permission on header file

Posted by GitBox <gi...@apache.org>.
jerpelea merged pull request #2202:
URL: https://github.com/apache/incubator-nuttx/pull/2202


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #2202: stm32 - Fix wrong executable permission on header file

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on pull request #2202:
URL: https://github.com/apache/incubator-nuttx/pull/2202#issuecomment-720559536


   @hartmannathan it's better to add the permission check to checkpatch.sh.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] jerpelea commented on pull request #2202: stm32 - Fix wrong executable permission on header file

Posted by GitBox <gi...@apache.org>.
jerpelea commented on pull request #2202:
URL: https://github.com/apache/incubator-nuttx/pull/2202#issuecomment-720559452


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org