You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Alexander Rojas <al...@mesosphere.io> on 2015/09/01 14:26:18 UTC

Re: Review Request 37996: Added property manager

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37996/
-----------------------------------------------------------

(Updated Sept. 1, 2015, 2:26 p.m.)


Review request for mesos and Benjamin Hindman.


Changes
-------

Removes use of `auto` and for range loops.


Repository: mesos


Description
-------

Introduces the `PathInheritedProperties` class which allows to create a tree where nodes can be tag with some property. This property is then inherited by children nodes.

Two behaviors are implemented, overriding, i.e. Adding a property to the child node of another node with a property already will result in the ancestor property being lost. The second behavior, accumulating, takes a function and accumulates
properties of all ancestors.


Diffs (updated)
-----

  3rdparty/libprocess/3rdparty/stout/Makefile.am f95ed03004d4e5382874d75969bc9285a0f44918 
  3rdparty/libprocess/3rdparty/stout/include/Makefile.am 8853f92fcfcff81d0a3197bade02110685fa0325 
  3rdparty/libprocess/3rdparty/stout/include/stout/properties.hpp PRE-CREATION 
  3rdparty/libprocess/3rdparty/stout/tests/CMakeLists.txt b1a519007e5bed196541f294c4676277f9708714 
  3rdparty/libprocess/3rdparty/stout/tests/properties_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/37996/diff/


Testing
-------

make check


Thanks,

Alexander Rojas