You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "terrymanu (via GitHub)" <gi...@apache.org> on 2023/04/07 10:37:20 UTC
[GitHub] [shardingsphere] terrymanu opened a new issue, #25057: Merge shardingsphere-standalone-mode-repository-jdbc module
terrymanu opened a new issue, #25057:
URL: https://github.com/apache/shardingsphere/issues/25057
Modify the module `shardingsphere-standalone-mode-repository-jdbc-core` by changing the current H2 and MySQL SPI to an XML configuration file that is directly load by the core module.
The XML attribute should contain all SQL statements of `JDBCRepositoryProvider` and the JDBC driver class name, which be parsed JAXB.
After the modification, `shardingsphere-standalone-mode-repository-jdbc-h2` and `shardingsphere-standalone-mode-repository-jdbc-mysql` can be deleted, and `shardingsphere-standalone-mode-repository-jdbc-core` should be renamed to "shardingsphere-standalone-mode-repository-jdbc" and moved up to the parent module.
The xml should be:
```xml
<sql type="H2" driver-class-name="xxx.xxx.xxx">
<create-table> xxx</create-table>
<select-by-key> xxx</select-by-key>
<select-by-parent> xxx</select-by-parent>
<insert> xxx</insert>
<update> xxx</update>
<delete> xxx</delete>
</sql>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] iamhucong commented on issue #25057: Merge shardingsphere-standalone-mode-repository-jdbc module
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on issue #25057:
URL: https://github.com/apache/shardingsphere/issues/25057#issuecomment-1501085088
@terrymanu Would it be possible to assign it to me? I believe I could try to accomplish it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu closed issue #25057: Merge shardingsphere-standalone-mode-repository-jdbc module
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu closed issue #25057: Merge shardingsphere-standalone-mode-repository-jdbc module
URL: https://github.com/apache/shardingsphere/issues/25057
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on issue #25057: Merge shardingsphere-standalone-mode-repository-jdbc module
Posted by "terrymanu (via GitHub)" <gi...@apache.org>.
terrymanu commented on issue #25057:
URL: https://github.com/apache/shardingsphere/issues/25057#issuecomment-1511630409
> @terrymanu @magestacks Hi, I have already submitted the pull request. Could you please review it when you have time and provide any suggestions you may have?
Thank you, I just comment on pull request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] magestacks commented on issue #25057: Merge shardingsphere-standalone-mode-repository-jdbc module
Posted by "magestacks (via GitHub)" <gi...@apache.org>.
magestacks commented on issue #25057:
URL: https://github.com/apache/shardingsphere/issues/25057#issuecomment-1501138838
@iamhucong Welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] iamhucong commented on issue #25057: Merge shardingsphere-standalone-mode-repository-jdbc module
Posted by "iamhucong (via GitHub)" <gi...@apache.org>.
iamhucong commented on issue #25057:
URL: https://github.com/apache/shardingsphere/issues/25057#issuecomment-1510878224
@terrymanu @magestacks Hi, I have already submitted the pull request. Could you please review it when you have time and provide any suggestions you may have?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] shiliang-star commented on issue #25057: Merge shardingsphere-standalone-mode-repository-jdbc module
Posted by "shiliang-star (via GitHub)" <gi...@apache.org>.
shiliang-star commented on issue #25057:
URL: https://github.com/apache/shardingsphere/issues/25057#issuecomment-1689230010
Please see this [issue](https://github.com/apache/shardingsphere/issues/28227)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org