You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2020/03/23 20:18:08 UTC

[kudu-CR] gutil: add CPU detection flags for carryless multiplication, BMI 

Hello Adar Dembo,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/15536

to review the following change.


Change subject: gutil: add CPU detection flags for carryless multiplication, BMI
......................................................................

gutil: add CPU detection flags for carryless multiplication, BMI

These instruction sets are useful for various code paths in my upcoming
columnar serialization patch. This adds flag detection based on the
tables in the Intel software development manual Table 3-8 "Information
Returned by CPUID Instruction" and Table 3-10 "Feature Information
Returned in the ECX Register"

[1] https://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-software-developer-vol-2a-manual.html

Change-Id: I89a0c6eab5e37dc8ce59fe1a048670c6c79c692a
---
M src/kudu/gutil/cpu.cc
M src/kudu/gutil/cpu.h
2 files changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/15536/1
-- 
To view, visit http://gerrit.cloudera.org:8080/15536
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I89a0c6eab5e37dc8ce59fe1a048670c6c79c692a
Gerrit-Change-Number: 15536
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>

[kudu-CR] gutil: add CPU detection flags for carryless multiplication, BMI

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15536 )

Change subject: gutil: add CPU detection flags for carryless multiplication, BMI
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/15536
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I89a0c6eab5e37dc8ce59fe1a048670c6c79c692a
Gerrit-Change-Number: 15536
Gerrit-PatchSet: 1
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Mon, 23 Mar 2020 20:32:27 +0000
Gerrit-HasComments: No

[kudu-CR] gutil: add CPU detection flags for carryless multiplication, BMI

Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15536 )

Change subject: gutil: add CPU detection flags for carryless multiplication, BMI
......................................................................

gutil: add CPU detection flags for carryless multiplication, BMI

These instruction sets are useful for various code paths in my upcoming
columnar serialization patch. This adds flag detection based on the
tables in the Intel software development manual Table 3-8 "Information
Returned by CPUID Instruction" and Table 3-10 "Feature Information
Returned in the ECX Register"

[1] https://www.intel.com/content/www/us/en/architecture-and-technology/64-ia-32-architectures-software-developer-vol-2a-manual.html

Change-Id: I89a0c6eab5e37dc8ce59fe1a048670c6c79c692a
Reviewed-on: http://gerrit.cloudera.org:8080/15536
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/gutil/cpu.cc
M src/kudu/gutil/cpu.h
2 files changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/15536
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I89a0c6eab5e37dc8ce59fe1a048670c6c79c692a
Gerrit-Change-Number: 15536
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>