You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/12/15 12:59:59 UTC

[GitHub] [calcite] mgramin commented on a change in pull request #2646: [CALCITE-4936] Generalize FilterCalcMergeRule and ProjectCalcMergeRule

mgramin commented on a change in pull request #2646:
URL: https://github.com/apache/calcite/pull/2646#discussion_r769602846



##########
File path: core/src/main/java/org/apache/calcite/rel/rules/ProjectCalcMergeRule.java
##########
@@ -82,8 +82,6 @@ public ProjectCalcMergeRule(RelBuilderFactory relBuilderFactory) {
             project.getRowType(),
             cluster.getRexBuilder());
     if (RexOver.containsOver(program)) {
-      LogicalCalc projectAsCalc = LogicalCalc.create(calc, program);

Review comment:
       Unfortunately, yes. But i assume that special rule `ProjectToCalcRule` can perform simple conversion from `LogicalProject` to `LogicalCalc`. Whereas `ProjectCalcMergeRule` will be able to stay more clear and more generalize.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org