You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/05/27 10:45:39 UTC
[GitHub] [pulsar] dockerzhang opened a new pull request #10728: change the parent dependency for pulsar-presto-connector
dockerzhang opened a new pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #10727
Master Issue: #<xyz>
### Motivation
the parent for `pulsar-presto-connector` should be `pulsar-sql`, and the version could be affected by the `mvn versions:set -DnewVersion=` command.
### Modifications
change the parent dependency for pulsar-presto-connector, and the version could be affected by 'mvn versions:set -DnewVersion=' command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang edited a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang edited a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-852640785
the timeout of `Integration - Sql` may be caused by other dependency problems.
```
2021-06-02 02:57:33,268 - ERROR - [main:GenericContainer@484] - Could not start container
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for URL to be accessible (http://localhost:49216/v1/info/state should return HTTP [200])
at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.waitUntilReady(HttpWaitStrategy.java:264)
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:35)
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:892)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:440)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:325)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:323)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311)
at org.apache.pulsar.tests.integration.containers.PulsarContainer.start(PulsarContainer.java:181)
at org.apache.pulsar.tests.integration.topologies.PulsarCluster.startPrestoWorker(PulsarCluster.java:370)
at org.apache.pulsar.tests.integration.topologies.PulsarCluster.startPrestoWorker(PulsarCluster.java:361)
at org.apache.pulsar.tests.integration.presto.TestBasicPresto.setupPresto(TestBasicPresto.java:60)
at org.apache.pulsar.tests.integration.presto.TestBasicPresto.setupCluster(TestBasicPresto.java:71)
at org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase.setup(PulsarClusterTestBase.java:33)
at org.apache.pulsar.tests.TestRetrySupport.stateCheck(TestRetrySupport.java:56)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:61)
at org.testng.internal.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:366)
at org.testng.internal.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:320)
at org.testng.internal.TestInvoker.runConfigMethods(TestInvoker.java:701)
at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:527)
at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at org.testng.TestRunner.privateRun(TestRunner.java:764)
at org.testng.TestRunner.run(TestRunner.java:585)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
at org.testng.SuiteRunner.run(SuiteRunner.java:286)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
at org.testng.TestNG.runSuites(TestNG.java:1069)
at org.testng.TestNG.run(TestNG.java:1037)
at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:283)
at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:75)
at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:120)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
2021-06-02 02:57:33,299 - ERROR - [main:GenericContainer@491] - Log output from the failed container:
[conf/presto/catalog/pulsar.properties] Applying config pulsar.bookkeeper-explicit-interval = 10
[conf/presto/catalog/pulsar.properties] Applying config pulsar.bookkeeper-use-v2-protocol = false
[conf/presto/catalog/pulsar.properties] Applying config pulsar.web-service-url = http://pulsar-broker-0:8080
```
but I test `sql-worker` and `pulsar sql` in the local environment, they work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang edited a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang edited a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-852640785
the timeout of `Integration - Sql` may be caused by other dependency problems.
```
2021-06-02 02:57:33,268 - ERROR - [main:GenericContainer@484] - Could not start container
org.testcontainers.containers.ContainerLaunchException: Timed out waiting for URL to be accessible (http://localhost:49216/v1/info/state should return HTTP [200])
at org.testcontainers.containers.wait.strategy.HttpWaitStrategy.waitUntilReady(HttpWaitStrategy.java:264)
at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:35)
at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:892)
at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:440)
at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:325)
at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:323)
at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311)
at org.apache.pulsar.tests.integration.containers.PulsarContainer.start(PulsarContainer.java:181)
at org.apache.pulsar.tests.integration.topologies.PulsarCluster.startPrestoWorker(PulsarCluster.java:370)
at org.apache.pulsar.tests.integration.topologies.PulsarCluster.startPrestoWorker(PulsarCluster.java:361)
at org.apache.pulsar.tests.integration.presto.TestBasicPresto.setupPresto(TestBasicPresto.java:60)
at org.apache.pulsar.tests.integration.presto.TestBasicPresto.setupCluster(TestBasicPresto.java:71)
at org.apache.pulsar.tests.integration.topologies.PulsarClusterTestBase.setup(PulsarClusterTestBase.java:33)
at org.apache.pulsar.tests.TestRetrySupport.stateCheck(TestRetrySupport.java:56)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:132)
at org.testng.internal.MethodInvocationHelper.invokeMethodConsideringTimeout(MethodInvocationHelper.java:61)
at org.testng.internal.ConfigInvoker.invokeConfigurationMethod(ConfigInvoker.java:366)
at org.testng.internal.ConfigInvoker.invokeConfigurations(ConfigInvoker.java:320)
at org.testng.internal.TestInvoker.runConfigMethods(TestInvoker.java:701)
at org.testng.internal.TestInvoker.invokeMethod(TestInvoker.java:527)
at org.testng.internal.TestInvoker.invokeTestMethod(TestInvoker.java:174)
at org.testng.internal.MethodRunner.runInSequence(MethodRunner.java:46)
at org.testng.internal.TestInvoker$MethodInvocationAgent.invoke(TestInvoker.java:822)
at org.testng.internal.TestInvoker.invokeTestMethods(TestInvoker.java:147)
at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:146)
at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:128)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at org.testng.TestRunner.privateRun(TestRunner.java:764)
at org.testng.TestRunner.run(TestRunner.java:585)
at org.testng.SuiteRunner.runTest(SuiteRunner.java:384)
at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:378)
at org.testng.SuiteRunner.privateRun(SuiteRunner.java:337)
at org.testng.SuiteRunner.run(SuiteRunner.java:286)
at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:53)
at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:96)
at org.testng.TestNG.runSuitesSequentially(TestNG.java:1218)
at org.testng.TestNG.runSuitesLocally(TestNG.java:1140)
at org.testng.TestNG.runSuites(TestNG.java:1069)
at org.testng.TestNG.run(TestNG.java:1037)
at org.apache.maven.surefire.testng.TestNGExecutor.run(TestNGExecutor.java:283)
at org.apache.maven.surefire.testng.TestNGXmlTestSuite.execute(TestNGXmlTestSuite.java:75)
at org.apache.maven.surefire.testng.TestNGProvider.invoke(TestNGProvider.java:120)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
2021-06-02 02:57:33,299 - ERROR - [main:GenericContainer@491] - Log output from the failed container:
[conf/presto/catalog/pulsar.properties] Applying config pulsar.bookkeeper-explicit-interval = 10
[conf/presto/catalog/pulsar.properties] Applying config pulsar.bookkeeper-use-v2-protocol = false
[conf/presto/catalog/pulsar.properties] Applying config pulsar.web-service-url = http://pulsar-broker-0:8080
```
the launcher log shows the property values are not passed to files.
```
root@presto-worker:/pulsar# cat lib/presto/bin/launcher.properties
main-class=${main-class}
process-name=${process-name}
root@presto-worker:/pulsar# cat lib/presto/var/
log/ run/
root@presto-worker:/pulsar# cat lib/presto/var/log/launcher.log
Error: Could not find or load main class ${main-class}
Caused by: java.lang.ClassNotFoundException: ${main-class}
Error: Could not find or load main class ${main-class}
Caused by: java.lang.ClassNotFoundException: ${main-class}
Error: Could not find or load main class ${main-class}
Caused by: java.lang.ClassNotFoundException: ${main-class}
Error: Could not find or load main class ${main-class}
Caused by: java.lang.ClassNotFoundException: ${main-class}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] lhotari commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
lhotari commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-855283081
@dockerzhang this change might have caused #10834 . Would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851995551
I found the following exception after running the `sql-worker`:
```
2021-06-01T17:51:27.931+0800 ERROR main io.prestosql.server.PrestoServer javax/servlet/http/HttpFilter
java.lang.NoClassDefFoundError: javax/servlet/http/HttpFilter
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
at io.airlift.http.server.HttpServer.createServletContext(HttpServer.java:400)
at io.airlift.http.server.HttpServer.<init>(HttpServer.java:351)
at io.airlift.http.server.HttpServerProvider.get(HttpServerProvider.java:134)
at io.airlift.http.server.HttpServerProvider.get(HttpServerProvider.java:43)
at com.google.inject.internal.ProviderInternalFactory.provision(ProviderInternalFactory.java:85)
at com.google.inject.internal.BoundProviderFactory.provision(BoundProviderFactory.java:77)
at com.google.inject.internal.ProviderInternalFactory$1.call(ProviderInternalFactory.java:66)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang removed a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang removed a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-852083008
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang removed a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang removed a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-850262724
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853028349
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853109523
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: change the parent dependency for pulsar-presto-connector
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-850050579
I am confused there are some integration CI fails, which do not happen in the local environment.
```
Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project pulsar-presto-distribution: Fatal error compiling: error: release version 1.8 not supported
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853484589
rebase to solve the conflicts.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853097755
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-850262724
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-852974074
the following exception is caused by `joda-time-2.10.1.jar`, we can update it to `joda-time-2.10.5.jar`.
```
Caused by: java.lang.IllegalArgumentException: The datetime zone id 'Asia/Qostanay' is not recognised
at org.joda.time.DateTimeZone.forID(DateTimeZone.java:234)
at io.prestosql.util.DateTimeZoneIndex.<clinit>(DateTimeZoneIndex.java:43)
... 44 more
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851486140
it is because we have "dependencyManagement" and "pluginManagement" in main pulsar parent pom.xml
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853533807
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851487745
I would also change the title of the PR to "Make Pulsar-SQL module to be a child of Pulsar main project"
because the change is all about that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang removed a comment on pull request #10728: change the parent dependency for pulsar-presto-connector
Posted by GitBox <gi...@apache.org>.
dockerzhang removed a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-850045227
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli edited a comment on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
eolivelli edited a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851485861
This implementation will probably change the versions of the dependencies.
you can fix the LICENSE files accordingly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang removed a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang removed a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853097755
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-852640785
the timeout of `Integration - Sql` may be caused by other dependency problems.
but I test `sql-worker` and `pulsar sql` in the local environment, they work fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang removed a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang removed a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853028349
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853124399
@sijie @codelipenghui @eolivelli Please review this PR again, thanks. there are some flaky test fails for broker should not caused by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851487114
the fact the the integration tests failed is bad news
probably some dependency changed and the Presto server does not work anymore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851433162
@dockerzhang Could you please help check the license check issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851486724
please also note the error:
`src/check-binary-license: line 111: echo: write error: Broken pipe`
this means that we have to rerun the job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: change the parent dependency for pulsar-presto-connector
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-850045227
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang removed a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang removed a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853100774
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853104217
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853484589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang edited a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang edited a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851995551
I found the following exception after running the `sql-worker`:
```
2021-06-01T17:51:27.931+0800 ERROR main io.prestosql.server.PrestoServer javax/servlet/http/HttpFilter
java.lang.NoClassDefFoundError: javax/servlet/http/HttpFilter
at java.lang.ClassLoader.defineClass1(Native Method)
at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
at java.security.AccessController.doPrivileged(Native Method)
at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
at io.airlift.http.server.HttpServer.createServletContext(HttpServer.java:400)
at io.airlift.http.server.HttpServer.<init>(HttpServer.java:351)
at io.airlift.http.server.HttpServerProvider.get(HttpServerProvider.java:134)
at io.airlift.http.server.HttpServerProvider.get(HttpServerProvider.java:43)
at com.google.inject.internal.ProviderInternalFactory.provision(ProviderInternalFactory.java:85)
at com.google.inject.internal.BoundProviderFactory.provision(BoundProviderFactory.java:77)
at com.google.inject.internal.ProviderInternalFactory$1.call(ProviderInternalFactory.java:66)
```
it's affected by `javax.servlet-api-3.1.0.jar`, pulsar-presto-distribution need `javax.servlet-api-4.0.1.jar` actually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang removed a comment on pull request #10728: change the parent dependency for pulsar-presto-connector
Posted by GitBox <gi...@apache.org>.
dockerzhang removed a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-850050579
I am confused there are some integration CI fails, which do not happen in the local environment.
```
Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project pulsar-presto-distribution: Fatal error compiling: error: release version 1.8 not supported
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
codelipenghui commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-852169181
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] eolivelli commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851485861
This implementation will probably change the versions of the dependencies.
we should take care of explicitly setting dependency versions in the pulsar-sql pom files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851436950
@codelipenghui I tried to fix the license check issue, but I did not figure out why this PR could affect the License Check and SQL Integration test. And I checked the structure of pulsar-presto-distribution output files, there is no difference. Could you give me some clue about how to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: support set any version for pulsar by maven command
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-851750306
@eolivelli I get what you said, thanks. I will try to fix the LICENSE and the integration tests failed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853100774
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-852083008
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang removed a comment on pull request #10728: Make Pulsar-SQL module to be a child of Pulsar main project
Posted by GitBox <gi...@apache.org>.
dockerzhang removed a comment on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-853104217
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] dockerzhang commented on pull request #10728: change the parent dependency for pulsar-presto-connector
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #10728:
URL: https://github.com/apache/pulsar/pull/10728#issuecomment-850059709
After this PR, we could set any version for pulsar by maven command, and it will build successfully:
```
mvn versions:set -DnewVersion=x.x.x.x
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org