You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/08 15:34:28 UTC
[GitHub] [arrow-datafusion] drrtuy opened a new pull request, #3771: Teach a negative NULL expression to return NULL instead of an error
drrtuy opened a new pull request, #3771:
URL: https://github.com/apache/arrow-datafusion/pull/3771
# Which issue does this PR close?
Closes #1192.
# Rationale for this change
This is a bug fix.
# What changes are included in this PR?
# Are there any user-facing changes?
The expression -null now returns NULL.
There are no API changes that I am aware #of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] jackwener commented on pull request #3771: Teach a negative NULL expression to return NULL instead of an error
Posted by GitBox <gi...@apache.org>.
jackwener commented on PR #3771:
URL: https://github.com/apache/arrow-datafusion/pull/3771#issuecomment-1272499097
PG will deduce the type of null based on other parameters.
we can specify the null type, it will ok.
```sql
jackwener=# select -null::int;
?column?
----------
(1 row)
```
deduce the type of null based on other parameters.
```sql
jackwener=# select 1+null;
?column?
----------
(1 row)
```
error, can't deduce
```sql
=# select null+null;
ERROR: operator is not unique: unknown + unknown
LINE 1: select null+null;
^
HINT: Could not choose a best candidate operator. You might need to add explicit type casts.
leiysky=#
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] drrtuy commented on pull request #3771: Teach a negative NULL expression to return NULL instead of an error
Posted by GitBox <gi...@apache.org>.
drrtuy commented on PR #3771:
URL: https://github.com/apache/arrow-datafusion/pull/3771#issuecomment-1272347697
There is a tradeoff, namely PG returns an error for the expression, however Oracle, MariaDB/MySQL returns NULL for -NULL expression. The behavior depends on what is the exemplar DB is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #3771: Teach a negative NULL expression to return NULL instead of an error
Posted by GitBox <gi...@apache.org>.
alamb merged PR #3771:
URL: https://github.com/apache/arrow-datafusion/pull/3771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #3771: Teach a negative NULL expression to return NULL instead of an error
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #3771:
URL: https://github.com/apache/arrow-datafusion/pull/3771#issuecomment-1273832280
Benchmark runs are scheduled for baseline = 80228279d61c10903cd9707fafcbccb8b15d5e1c and contender = c02e9d4c7c0aa6716ce9e4a7afd8e882e9efff79. c02e9d4c7c0aa6716ce9e4a7afd8e882e9efff79 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/e7bf52cd34a4448eafbd446db724c4d6...87c46df7b771406682dab0a3f6caf91c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/713b77ea3697451bb887818a26a72fb5...2a9e9a01f0994e4084da32e69a50147f/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/ea9d226fb0a2474f978a253bdcefd38c...8df3b5b3190e484391c481137387ed12/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/31b326e3adf04718a9ae405e3786dcaf...f2be834fd3b44f6ca1a316518dfe702c/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #3771: Teach a negative NULL expression to return NULL instead of an error
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #3771:
URL: https://github.com/apache/arrow-datafusion/pull/3771#issuecomment-1273830673
Thank you @drrtuy -- I agree with @jackwener that being more permissive than PG is a good thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org