You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2023/12/01 22:55:10 UTC
[PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
dongjoon-hyun opened a new pull request, #44113:
URL: https://github.com/apache/spark/pull/44113
…
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412704196
##########
core/src/test/scala/org/apache/spark/deploy/master/PersistenceEngineBenchmark.scala:
##########
@@ -60,15 +61,23 @@ object PersistenceEngineBenchmark extends BenchmarkBase {
runBenchmark("PersistenceEngineBenchmark") {
val benchmark = new Benchmark(s"$numWorkers Workers", numWorkers, output = output)
- benchmark.addCase("ZooKeeperPersistenceEngine", numIters) { _ =>
+ benchmark.addCase("ZooKeeperPersistenceEngine with JavaSerializer", numIters) { _ =>
Review Comment:
Sorry, but this is also intentional for the ordering like the following.
```
OpenJDK 64-Bit Server VM 17.0.9+9-LTS on Linux 5.15.0-1051-azure
AMD EPYC 7763 64-Core Processor
1000 Workers: Best Time(ms) Avg Time(ms) Stdev(ms) Rate(M/s) Per Row(ns) Relative
-------------------------------------------------------------------------------------------------------------------------------
ZooKeeperPersistenceEngine with JavaSerializer 1202 1298 138 0.0 1201614.2 1.0X
ZooKeeperPersistenceEngine with KryoSerializer 951 1004 48 0.0 950559.0 1.3X
FileSystemPersistenceEngine with JavaSerializer 212 217 6 0.0 211623.2 5.7X
FileSystemPersistenceEngine with KryoSerializer 79 81 2 0.0 79132.5 15.2X
BlackHolePersistenceEngine 0 0 0 30.9 32.4 37109.8X
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44113:
URL: https://github.com/apache/spark/pull/44113#issuecomment-1836890366
I'm going to update the benchmark files.
- https://github.com/dongjoon-hyun/spark/actions/runs/7066098422 (Java 17)
- https://github.com/dongjoon-hyun/spark/actions/runs/7066103306 (Java 21)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "beliefer (via GitHub)" <gi...@apache.org>.
beliefer commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412702173
##########
core/src/test/scala/org/apache/spark/deploy/master/PersistenceEngineSuite.scala:
##########
@@ -26,9 +26,10 @@ import org.apache.curator.test.TestingServer
import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
import org.apache.spark.internal.config.Deploy.ZOOKEEPER_URL
import org.apache.spark.rpc.{RpcEndpoint, RpcEnv}
-import org.apache.spark.serializer.{JavaSerializer, Serializer}
+import org.apache.spark.serializer.{JavaSerializer, KryoSerializer, Serializer}
import org.apache.spark.util.Utils
+
Review Comment:
Please revert this line.
##########
core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala:
##########
@@ -325,6 +326,26 @@ class MasterSuite extends SparkFunSuite
}
}
+ test("SPARK-46205: Recovery with Kryo Serializer") {
+ val conf = new SparkConf(loadDefaults = false)
+ conf.set(RECOVERY_MODE, "FILESYSTEM")
+ conf.set(RECOVERY_SERIALIZER, "Kryo")
+ conf.set(RECOVERY_DIRECTORY, System.getProperty("java.io.tmpdir"))
+
+ var master: Master = null
+ try {
+ master = makeAliveMaster(conf)
+ val e = master.invokePrivate(_persistenceEngine()).asInstanceOf[FileSystemPersistenceEngine]
+ assert(e.serializer.isInstanceOf[KryoSerializer])
Review Comment:
```suggestion
val persistenceEngine = master.invokePrivate(_persistenceEngine()).asInstanceOf[FileSystemPersistenceEngine]
assert(persistenceEngine.serializer.isInstanceOf[KryoSerializer])
```
##########
core/src/test/scala/org/apache/spark/deploy/master/PersistenceEngineBenchmark.scala:
##########
@@ -60,15 +61,23 @@ object PersistenceEngineBenchmark extends BenchmarkBase {
runBenchmark("PersistenceEngineBenchmark") {
val benchmark = new Benchmark(s"$numWorkers Workers", numWorkers, output = output)
- benchmark.addCase("ZooKeeperPersistenceEngine", numIters) { _ =>
+ benchmark.addCase("ZooKeeperPersistenceEngine with JavaSerializer", numIters) { _ =>
Review Comment:
How about
```
Seq(serializerJava, serializerKryo).foreach { serializer =>
benchmark.addCase("ZooKeeperPersistenceEngine with ${serializer.getClass.getSimpleName}", numIters) { _ =>
val engine = new ZooKeeperPersistenceEngine(conf, serializer)
...
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412704027
##########
core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala:
##########
@@ -325,6 +326,26 @@ class MasterSuite extends SparkFunSuite
}
}
+ test("SPARK-46205: Recovery with Kryo Serializer") {
+ val conf = new SparkConf(loadDefaults = false)
+ conf.set(RECOVERY_MODE, "FILESYSTEM")
+ conf.set(RECOVERY_SERIALIZER, "Kryo")
+ conf.set(RECOVERY_DIRECTORY, System.getProperty("java.io.tmpdir"))
+
+ var master: Master = null
+ try {
+ master = makeAliveMaster(conf)
+ val e = master.invokePrivate(_persistenceEngine()).asInstanceOf[FileSystemPersistenceEngine]
+ assert(e.serializer.isInstanceOf[KryoSerializer])
Review Comment:
Thank you but this was intention in order to avoid `Scalastyle` failure. Line 338 has 99 char already.
<img width="1528" alt="Screenshot 2023-12-01 at 6 25 35 PM" src="https://github.com/apache/spark/assets/9700541/5dd77608-a9c2-434f-80f4-676cfac4176b">
##########
core/src/test/scala/org/apache/spark/deploy/master/MasterSuite.scala:
##########
@@ -325,6 +326,26 @@ class MasterSuite extends SparkFunSuite
}
}
+ test("SPARK-46205: Recovery with Kryo Serializer") {
+ val conf = new SparkConf(loadDefaults = false)
+ conf.set(RECOVERY_MODE, "FILESYSTEM")
+ conf.set(RECOVERY_SERIALIZER, "Kryo")
+ conf.set(RECOVERY_DIRECTORY, System.getProperty("java.io.tmpdir"))
+
+ var master: Master = null
+ try {
+ master = makeAliveMaster(conf)
+ val e = master.invokePrivate(_persistenceEngine()).asInstanceOf[FileSystemPersistenceEngine]
+ assert(e.serializer.isInstanceOf[KryoSerializer])
Review Comment:
Thank you but this was intention in order to avoid `Scalastyle` failure. Line 338 has 99 char already.
<img width="1528" alt="Screenshot 2023-12-01 at 6 25 35 PM" src="https://github.com/apache/spark/assets/9700541/5dd77608-a9c2-434f-80f4-676cfac4176b">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44113:
URL: https://github.com/apache/spark/pull/44113#issuecomment-1836944025
Could you review this when you have a chance, @yaooqinn , @beliefer , @LuciferYang ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #44113: [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer`
URL: https://github.com/apache/spark/pull/44113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412659395
##########
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala:
##########
@@ -67,10 +67,10 @@ private[master] class FileSystemPersistenceEngine(
out = serializer.newInstance().serializeStream(fileOut)
out.writeObject(value)
} {
- fileOut.close()
if (out != null) {
out.close()
}
+ fileOut.close()
Review Comment:
Without this, KryoSerializer complains.
- https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #44113:
URL: https://github.com/apache/spark/pull/44113#issuecomment-1837000444
Thank you so much, @beliefer .
Merged to master for Apache Spark 4.0.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412705151
##########
core/src/test/scala/org/apache/spark/deploy/master/PersistenceEngineBenchmark.scala:
##########
@@ -60,15 +61,23 @@ object PersistenceEngineBenchmark extends BenchmarkBase {
runBenchmark("PersistenceEngineBenchmark") {
val benchmark = new Benchmark(s"$numWorkers Workers", numWorkers, output = output)
- benchmark.addCase("ZooKeeperPersistenceEngine", numIters) { _ =>
+ benchmark.addCase("ZooKeeperPersistenceEngine with JavaSerializer", numIters) { _ =>
Review Comment:
Oh, for this one, it seems that I misunderstood your previous comment. Let me address it at the next PR (or a follow-up), @beliefer . Sorry for my mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412658012
##########
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala:
##########
@@ -67,10 +67,10 @@ private[master] class FileSystemPersistenceEngine(
out = serializer.newInstance().serializeStream(fileOut)
out.writeObject(value)
} {
- fileOut.close()
if (out != null) {
out.close()
}
+ fileOut.close()
Review Comment:
In general, serializers should be closed before closing file output stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1421899548
##########
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala:
##########
@@ -67,10 +67,10 @@ private[master] class FileSystemPersistenceEngine(
out = serializer.newInstance().serializeStream(fileOut)
out.writeObject(value)
} {
- fileOut.close()
if (out != null) {
out.close()
}
+ fileOut.close()
Review Comment:
cc @sadikovi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412658012
##########
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala:
##########
@@ -67,10 +67,10 @@ private[master] class FileSystemPersistenceEngine(
out = serializer.newInstance().serializeStream(fileOut)
out.writeObject(value)
} {
- fileOut.close()
if (out != null) {
out.close()
}
+ fileOut.close()
Review Comment:
In general, serializers should be closed before closing file output stream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412659395
##########
core/src/main/scala/org/apache/spark/deploy/master/FileSystemPersistenceEngine.scala:
##########
@@ -67,10 +67,10 @@ private[master] class FileSystemPersistenceEngine(
out = serializer.newInstance().serializeStream(fileOut)
out.writeObject(value)
} {
- fileOut.close()
if (out != null) {
out.close()
}
+ fileOut.close()
Review Comment:
Without this reordering, KryoSerializer complains.
- https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/serializer/KryoSerializer.scala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46205][CORE] Improve `PersistenceEngine` performance with `KryoSerializer` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #44113:
URL: https://github.com/apache/spark/pull/44113#discussion_r1412704352
##########
core/src/test/scala/org/apache/spark/deploy/master/PersistenceEngineSuite.scala:
##########
@@ -26,9 +26,10 @@ import org.apache.curator.test.TestingServer
import org.apache.spark.{SecurityManager, SparkConf, SparkFunSuite}
import org.apache.spark.internal.config.Deploy.ZOOKEEPER_URL
import org.apache.spark.rpc.{RpcEndpoint, RpcEnv}
-import org.apache.spark.serializer.{JavaSerializer, Serializer}
+import org.apache.spark.serializer.{JavaSerializer, KryoSerializer, Serializer}
import org.apache.spark.util.Utils
+
Review Comment:
Thank you! Sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org