[GitHub] [tvm] leandron commented on a change in pull request #7983: [PROFILING] Use PAPI to collect hardware performance counters on CPU and CUDA

[GitBox <gi...@apache.org>]

leandron commented on a change in pull request #7983:
URL: https://github.com/apache/tvm/pull/7983#discussion_r660491006



##########
File path: python/tvm/runtime/profiler_vm.py
##########
@@ -50,14 +50,17 @@ def get_stat(self, sort_by_time=True):  # pylint: disable=unused-argument
         warnings.warn("get_stat has been removed, use profile instead")
         return ""
 
-    def profile(self, *args, func_name="main", **kwargs):
+    def profile(self, *args, func_name="main", collectors=[], **kwargs):

Review comment:
       Interesting pylint didn't complain about this one.

##########
File path: src/runtime/vm/executable.cc
##########
@@ -273,6 +273,13 @@ void Executable::SavePrimitiveOpNames(dmlc::Stream* strm) {
     primitive_names[packed_index] = it.first;
   }
   strm->Write(primitive_names);
+  // TODO(tkonolige): cannot serialize ObjectRefs with dmlc's serializer.

Review comment:
       If this is not needed, maybe can be removed?

##########
File path: python/tvm/contrib/debugger/debug_executor.py
##########
@@ -268,14 +268,18 @@ def run_individual(self, number, repeat=1, min_repeat_ms=0):
         ret = self._run_individual(number, repeat, min_repeat_ms)
         return ret.strip(",").split(",") if ret else []
 
-    def profile(self, **input_dict):
+    def profile(self, collectors=[], **input_dict):  # pylint: disable=dangerous-default-value

Review comment:
       I see you have a `# pylint: disable=dangerous-default-value`, after setting the `collectors=[]`.
   
   Just wanted to double check whether this is intended, as `collectors=[]` behaves like a global, and there will be only one list that will be shared across all the calls to `profile()` in which collectors is not provided?
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org