You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Venki Korukanti <ve...@gmail.com> on 2014/02/06 23:37:23 UTC
Re: Review Request 15105: HIVE-3844: Unix timestamps don't seem to be read
correctly from HDFS as Timestamp column
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15105/
-----------------------------------------------------------
(Updated Feb. 6, 2014, 10:37 p.m.)
Review request for hive and Mark Grover.
Changes
-------
Addressed review comments
Bugs: HIVE-3844
https://issues.apache.org/jira/browse/HIVE-3844
Repository: hive-git
Description
-------
Currently LazyTimestamp can only interpret timestamps in JDBC format. If there are UNIX epoch styles timestamps it treats them as invalid and output NULL. This patch is to support all three types of formats mentioned here https://cwiki.apache.org/confluence/display/Hive/LanguageManual+Types#LanguageManualTypes-Timestamps.
BigDecimal is used to avoid rounding off errors with atoi/atof type of conversions.
Diffs (updated)
-----
data/files/timestamp_data.txt PRE-CREATION
ql/src/test/queries/clientpositive/timestamp_4.q PRE-CREATION
ql/src/test/queries/clientpositive/timestamp_null.q 36f3541
ql/src/test/results/clientpositive/timestamp_4.q.out PRE-CREATION
ql/src/test/results/clientpositive/timestamp_null.q.out 57269d7
serde/src/java/org/apache/hadoop/hive/serde2/io/TimestampWritable.java 435d6c6
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyTimestamp.java 27895c5
Diff: https://reviews.apache.org/r/15105/diff/
Testing
-------
Fix includes a unittest which reads from a file that has most types of timestamp formats.
Thanks,
Venki Korukanti