You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "sbroeder (via GitHub)" <gi...@apache.org> on 2026/10/05 21:40:02 UTC
[PR] [CALCITE-7838] JDBC adapter generates nested aggregate SQL that throws an exception on HSQLDB [calcite]
sbroeder opened a new pull request, #5307:
URL: https://github.com/apache/calcite/pull/5307
HsqldbSqlDialect inherited the default true behavior for supportsNestedAggregations(), so an aggregate over an expression of another aggregate was pushed down, which HSQLDB rejects. Report that HSQLDB does not support nested aggregations so that the converter generates a sub-SELECT, similar to how MySQL and PostgreSQL are already handled.
## Jira Link
[CALCITE-7838](https://issues.apache.org/jira/browse/CALCITE-7838)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7838] HsqldbSqlDialect incorrectly claims to support nested aggregations [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu merged PR #5307:
URL: https://github.com/apache/calcite/pull/5307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7838] JDBC adapter generates nested aggregate SQL that throws an exception on HSQLDB [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #5307:
URL: https://github.com/apache/calcite/pull/5307#discussion_r4190120468
##########
core/src/main/java/org/apache/calcite/sql/dialect/HsqldbSqlDialect.java:
##########
@@ -49,6 +49,10 @@ public HsqldbSqlDialect(Context context) {
super(context);
}
+ @Override public boolean supportsNestedAggregations() {
Review Comment:
I really would change the issue; this has nothing to do with the JDBC adapter.
It's a problem with the HSQLDB dialect.
Otherwise the fix looks fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7838] HsqldbSqlDialect incorrectly claims to support nested aggregations [calcite]
Posted by "sbroeder (via GitHub)" <gi...@apache.org>.
sbroeder commented on PR #5307:
URL: https://github.com/apache/calcite/pull/5307#issuecomment-6008128890
@mihaibudiu I used the JDBC adapter to demonstrate the problem, but your suggestion is better. I have already updated the PR title. If you agree with it I will update the JIRA to match. If you'd prefer something else, let me know and I'll adopt it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7838] HsqldbSqlDialect incorrectly claims to support nested aggregations [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #5307:
URL: https://github.com/apache/calcite/pull/5307#issuecomment-6008221762
you can also squash the commits
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7838] HsqldbSqlDialect incorrectly claims to support nested aggregations [calcite]
Posted by "sbroeder (via GitHub)" <gi...@apache.org>.
sbroeder commented on PR #5307:
URL: https://github.com/apache/calcite/pull/5307#issuecomment-6016966025
Done. Also updated the JIRA. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-7838] HsqldbSqlDialect incorrectly claims to support nested aggregations [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on PR #5307:
URL: https://github.com/apache/calcite/pull/5307#issuecomment-6008218212
This is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org