[GitHub] [spark] srowen commented on a change in pull request #25228: [SPARK-28472][SQL][TEST][test-hadoop3.2] Add test for thriftserver protocol versions

[GitBox <gi...@apache.org>]

srowen commented on a change in pull request #25228: [SPARK-28472][SQL][TEST][test-hadoop3.2] Add test for thriftserver protocol versions
URL: https://github.com/apache/spark/pull/25228#discussion_r307751900
 
 

 ##########
 File path: sql/hive-thriftserver/v1.2.1/src/main/scala/org/apache/spark/sql/hive/thriftserver/ThriftserverShimUtils.scala
 ##########
 @@ -46,4 +49,13 @@ private[thriftserver] object ThriftserverShimUtils {
 
   private[thriftserver] def toJavaSQLType(s: String): Int = Type.getType(s).toJavaSQLType
 
+  private[thriftserver] val testedProtocalVersions = Seq(
 
 Review comment:
   I guess the downside is we spend extra time testing more protocols? would we ever care to fix support of such old protocols if they didn't work?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org