You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Jark Wu (Jira)" <ji...@apache.org> on 2020/12/10 03:59:00 UTC

[jira] [Updated] (FLINK-20546) Misuse of the method in KafkaDynamicTableFactoryTest

     [ https://issues.apache.org/jira/browse/FLINK-20546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jark Wu updated FLINK-20546:
----------------------------
    Component/s: Table SQL / Ecosystem

> Misuse of the method in KafkaDynamicTableFactoryTest
> ----------------------------------------------------
>
>                 Key: FLINK-20546
>                 URL: https://issues.apache.org/jira/browse/FLINK-20546
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Kafka, Table SQL / Ecosystem
>    Affects Versions: 1.12.0
>            Reporter: zoucao
>            Assignee: zoucao
>            Priority: Major
>
> hi all, I am reading something about DynamicTable Source/Sink Factory recently, and one thing let me confused. In `KafkaDynamicTableFactoryTest`, `getBasicSourceOptions()`  and `getBasicSinkOptions()` are created for source table and sink table, respectively. However, in the situation of validating sink table, `getBasicSourceOptions()` is called, for example in method `testSinkWithTopicListOrTopicPattern`、`testInvalidSinkSemantic` etc.  Although no exception is thrown, it also should be fixed. WDYT?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)