You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/08/02 09:07:08 UTC

[GitHub] [rocketmq-client-cpp] ifplusor commented on a change in pull request #169: Format the code and remove warnings

ifplusor commented on a change in pull request #169: Format the code and remove warnings
URL: https://github.com/apache/rocketmq-client-cpp/pull/169#discussion_r310046099
 
 

 ##########
 File path: src/transport/TcpRemotingClient.cpp
 ##########
 @@ -373,7 +373,7 @@ std::shared_ptr<TcpTransport> TcpRemotingClient::CreateNameServerTransport(bool
       m_namesrvAddrChoosed.clear();
   }
 
-  for (int i = 0; i < m_namesrvAddrList.size(); i++) {
+  for (unsigned i = 0; i < m_namesrvAddrList.size(); i++) {
 
 Review comment:
   size_t is better

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services