You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pivot.apache.org by "Edvin Syse (JIRA)" <ji...@apache.org> on 2011/07/21 21:02:57 UTC
[jira] [Created] (PIVOT-774) Selection bug in TextArea
Selection bug in TextArea
-------------------------
Key: PIVOT-774
URL: https://issues.apache.org/jira/browse/PIVOT-774
Project: Pivot
Issue Type: Bug
Components: wtk
Affects Versions: 2.0
Reporter: Edvin Syse
Priority: Minor
If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069158#comment-13069158 ]
Greg Brown commented on PIVOT-774:
----------------------------------
I think that patch may prevent the scroll timer from being cancelled.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070017#comment-13070017 ]
Edvin Syse commented on PIVOT-774:
----------------------------------
I understand. When you said the right fix probably lies elsewhere.. did you have something spesific in mind? I'd like to investigate further, but I still don't have a good enough overview of Pivot internals.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078761#comment-13078761 ]
Edvin Syse commented on PIVOT-774:
----------------------------------
Noel, I think rev 1153480 stops the scroll timer prematurely. If you scroll down and then try to select text "upwards", the textarea doesn't scroll back up now.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Assignee: Noel Grandin
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069175#comment-13069175 ]
Edvin Syse commented on PIVOT-774:
----------------------------------
Yeah, that would stop the scrolling from occuring when you select and move north. I'm out :)
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edvin Syse updated PIVOT-774:
-----------------------------
Comment: was deleted
(was: Hm.. I took another look. This shouldn't prevent the scrollTimer from being cancelled, it should ensure it get's cancelled even when y >= visibleArea.y. Can you explain why you think this prevents the scroll timer from being cancelled?)
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Edvin Syse updated PIVOT-774:
-----------------------------
Attachment: TextAreaSelectionFix.patch
Path to correct the selection behavior of TextArea. The check I removed might have been for something else, but I can't see what. I basically changed:
if (y >= visibleArea.y
&& y < visibleArea.y + visibleArea.height) {
// Stop the scroll selection timer
to
if (y < visibleArea.y + visibleArea.height) {
// Stop the scroll selection timer
in TextAreaSkin#mouseMove() so that it is no longer required that the mouse is above visibleArea.y.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069182#comment-13069182 ]
Greg Brown commented on PIVOT-774:
----------------------------------
I was going to add a comment to that effect, but then thought I might be mis-reading it. :-) But I guess not.
The "right" fix probably lies somewhere else - the skin should still be able to respond to the mouse move outside the component's bounds even when the scroll timer isn't running.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069173#comment-13069173 ]
Edvin Syse commented on PIVOT-774:
----------------------------------
That could be remedied by doing:
if (y >= visibleArea.y || y < visibleArea.y + visibleArea.height)
But again, I'm unsure of the side effects.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by Greg Brown <gk...@verizon.net>.
The timer is used to periodically scroll the selection up or down by one row when the caret moves outside of the text area's bounds. TextInput does something similar for horizontal scrolling.
On Jul 21, 2011, at 3:52 PM, Edvin Syse (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069160#comment-13069160 ]
>
> Edvin Syse commented on PIVOT-774:
> ----------------------------------
>
> You might be correct :) It seems to be stopped on mouseUp though. I haven't fully understood the function of this timer, I'm not very familiar with this skin yet.
>
>> Selection bug in TextArea
>> -------------------------
>>
>> Key: PIVOT-774
>> URL: https://issues.apache.org/jira/browse/PIVOT-774
>> Project: Pivot
>> Issue Type: Bug
>> Components: wtk
>> Affects Versions: 2.0
>> Reporter: Edvin Syse
>> Priority: Minor
>> Attachments: TextAreaSelectionFix.patch
>>
>>
>> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
>> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
>> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
>> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
>
> --
> This message is automatically generated by JIRA.
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069160#comment-13069160 ]
Edvin Syse commented on PIVOT-774:
----------------------------------
You might be correct :) It seems to be stopped on mouseUp though. I haven't fully understood the function of this timer, I'm not very familiar with this skin yet.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069166#comment-13069166 ]
Edvin Syse commented on PIVOT-774:
----------------------------------
Hm.. I took another look. This shouldn't prevent the scrollTimer from being cancelled, it should ensure it get's cancelled even when y >= visibleArea.y. Can you explain why you think this prevents the scroll timer from being cancelled?
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (PIVOT-774) Selection bug in TextArea
Posted by "Noel Grandin (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Noel Grandin resolved PIVOT-774.
--------------------------------
Resolution: Fixed
Fix Version/s: 2.0.1
Assignee: Noel Grandin
Fixed in rev 1153480
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Assignee: Noel Grandin
> Priority: Minor
> Fix For: 2.0.1
>
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069200#comment-13069200 ]
Greg Brown commented on PIVOT-774:
----------------------------------
During a "drag" operation (left mouse button down/mouse move), mouse events continue to be fired to the component that "captured" the mouse. That's how we get notified when the mouse moves outside the text area's bounds.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Greg Brown (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070443#comment-13070443 ]
Greg Brown commented on PIVOT-774:
----------------------------------
I just meant elsewhere in the mouse handling code of TextAreaSkin.
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (PIVOT-774) Selection bug in TextArea
Posted by "Edvin Syse (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/PIVOT-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069192#comment-13069192 ]
Edvin Syse commented on PIVOT-774:
----------------------------------
That might be difficult if the mouse is outside of the Pivot Window's bounds I think. Then you'd need the timer to track the mouse movements, because there won't be any mouse events fired, right?
> Selection bug in TextArea
> -------------------------
>
> Key: PIVOT-774
> URL: https://issues.apache.org/jira/browse/PIVOT-774
> Project: Pivot
> Issue Type: Bug
> Components: wtk
> Affects Versions: 2.0
> Reporter: Edvin Syse
> Priority: Minor
> Attachments: TextAreaSelectionFix.patch
>
>
> If you start to select text in a TextArea and while selecting, move the cursor over the bounds of the TextArea (north of it), the selection area is not expanded.
> This bug only appears to affect TextArea when the content has been scrolled as far down or as far up as possible. While the text is being vertically scrolled, selection works as expected.
> A video showing the problem can be seen here: https://edvin.viewscreencasts.com/c97422da51ed4cf1845e5a7610a8716f
> This bug makes it hard to select text in a TextArea, because one often moves the cursor further north than the TextArea when selecting.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira