You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/05/17 04:06:40 UTC
Review Request: WDRF 6 - Adds tests for roles and WDRF
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11214/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
Updates DRFAllocatorTest to actually account for hierarchical allocation correctly, to test roles.
Adds AllocatorTest.RoleTest, which tests adding frameworks with roles set.
Adds SorterTest.WDRFSorter, which checks that WDRFSorter implements the WDRF algorithm correctly.
Diffs
-----
src/tests/allocator_tests.cpp 540c05a
src/tests/sorter_tests.cpp 95e8d28
Diff: https://reviews.apache.org/r/11214/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 5 - Adds tests for roles and WDRF
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11214/#review21821
-----------------------------------------------------------
Ship it!
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11214/#comment45026>
s/and/an/
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11214/#comment45027>
s/, as well as added, removed, and updated through the http endpoints//
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11214/#comment45028>
Shutdown();
- Benjamin Hindman
On June 5, 2013, 9:48 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11214/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 9:48 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Updates DRFAllocatorTest to actually account for hierarchical allocation correctly, to test roles.
>
> Adds AllocatorTest.RoleTest, which tests adding frameworks with roles set.
>
> Adds SorterTest.WDRFSorter, which checks that WDRFSorter implements the WDRF algorithm correctly.
>
>
> Diffs
> -----
>
> src/tests/allocator_tests.cpp 32f0a90
> src/tests/sorter_tests.cpp 0a50b43
>
> Diff: https://reviews.apache.org/r/11214/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: WDRF 5 - Adds tests for roles and WDRF
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11214/
-----------------------------------------------------------
(Updated June 13, 2013, 7:41 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Ben's review.
Description
-------
Updates DRFAllocatorTest to actually account for hierarchical allocation correctly, to test roles.
Adds AllocatorTest.RoleTest, which tests adding frameworks with roles set.
Adds SorterTest.WDRFSorter, which checks that WDRFSorter implements the WDRF algorithm correctly.
This addresses bug MESOS-504.
https://issues.apache.org/jira/browse/MESOS-504
Diffs (updated)
-----
src/tests/allocator_tests.cpp 32f0a90
src/tests/sorter_tests.cpp 0a50b43
Diff: https://reviews.apache.org/r/11214/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 5 - Adds tests for roles and WDRF
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11214/
-----------------------------------------------------------
(Updated June 12, 2013, 11:40 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Added bug.
Description
-------
Updates DRFAllocatorTest to actually account for hierarchical allocation correctly, to test roles.
Adds AllocatorTest.RoleTest, which tests adding frameworks with roles set.
Adds SorterTest.WDRFSorter, which checks that WDRFSorter implements the WDRF algorithm correctly.
This addresses bug MESOS-504.
https://issues.apache.org/jira/browse/MESOS-504
Diffs
-----
src/tests/allocator_tests.cpp 32f0a90
src/tests/sorter_tests.cpp 0a50b43
Diff: https://reviews.apache.org/r/11214/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 5 - Adds tests for roles and WDRF
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11214/
-----------------------------------------------------------
(Updated June 5, 2013, 9:48 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Rebased.
Summary (updated)
-----------------
WDRF 5 - Adds tests for roles and WDRF
Description
-------
Updates DRFAllocatorTest to actually account for hierarchical allocation correctly, to test roles.
Adds AllocatorTest.RoleTest, which tests adding frameworks with roles set.
Adds SorterTest.WDRFSorter, which checks that WDRFSorter implements the WDRF algorithm correctly.
Diffs (updated)
-----
src/tests/allocator_tests.cpp 32f0a90
src/tests/sorter_tests.cpp 0a50b43
Diff: https://reviews.apache.org/r/11214/diff/
Testing
-------
make check
Thanks,
Thomas Marshall