You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2023/01/04 14:53:46 UTC

[GitHub] [hudi] fengjian428 opened a new pull request, #7604: [DOCS][MINOR] add File base lock description

fengjian428 opened a new pull request, #7604:
URL: https://github.com/apache/hudi/pull/7604

   ### Change Logs
   
   Update for FileSystemBasedLockProvider.
   
   ### Impact
   
   NA
   
   ### Risk level (write none, low medium or high below)
   
   none
   
   ### Documentation Update
   
   _Describe any necessary documentation update if there is any new feature, config, or user-facing change_
   
   - _The config description must be updated if new configs are added or the default value of the configs are changed_
   - _Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
     ticket number here and follow the [instruction](https://hudi.apache.org/contribute/developer-setup#website) to make
     changes to the website._
   
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan merged pull request #7604: [DOCS][MINOR] add File base lock description

Posted by GitBox <gi...@apache.org>.
xushiyan merged PR #7604:
URL: https://github.com/apache/hudi/pull/7604


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on a diff in pull request #7604: [DOCS][MINOR] add File base lock description

Posted by GitBox <gi...@apache.org>.
xushiyan commented on code in PR #7604:
URL: https://github.com/apache/hudi/pull/7604#discussion_r1062708493


##########
website/versioned_docs/version-0.12.0/concurrency_control.md:
##########
@@ -47,7 +47,34 @@ hoodie.cleaner.policy.failed.writes=LAZY
 hoodie.write.lock.provider=<lock-provider-classname>
 ```
 
-There are 3 different server based lock providers that require different configuration to be set.
+There are 4 different lock providers that require different configurations to be set.
+
+**`FileSystem`** based lock provider
+
+FileSystem based lock provider provides an out-of-box way to support multiple writers cross different jobs/applications based on atomic
+create/delete operations of the underlying filesystem
+
+```
+hoodie.write.lock.provider=org.apache.hudi.client.transaction.lock.FileSystemBasedLockProvider
+hoodie.write.lock.filesystem.path (optional)
+hoodie.write.lock.filesystem.expire (optional)
+```
+
+When using the FileSystem based lock provider, by default, the lock file will store into `hoodie.base.path`+`/.hoodie/lock`,
+in additional, you can use a custom folder to store the lock file by specify `hoodie.write.lock.filesystem.path`

Review Comment:
   ```suggestion
   in addition, you can use a custom folder to store the lock file by specify `hoodie.write.lock.filesystem.path`
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] fengjian428 commented on pull request #7604: [DOCS][MINOR] add File base lock description

Posted by GitBox <gi...@apache.org>.
fengjian428 commented on PR #7604:
URL: https://github.com/apache/hudi/pull/7604#issuecomment-1373064347

   > LGTM. can you resolve conflicts pls?
   
   done, I removed the JSON content part since it hasn't been included in the 0.12.2


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org