You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Peeyush Bishnoi <bp...@yahoo.co.in> on 2015/10/13 10:58:16 UTC
Review Request 39261: FALCON-1480 : Gather data transfer details of
Hive DR
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1480
https://issues.apache.org/jira/browse/FALCON-1480
Repository: falcon-git
Description
-------
FALCON-1480: Gather data transfer details of Hive DR
Diffs
-----
addons/hivedr/pom.xml a1be288
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
Diff: https://reviews.apache.org/r/39261/diff/
Testing
-------
Yes. Manual testing done.
Thanks,
Peeyush Bishnoi
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Oct. 14, 2015, 5:16 p.m., Venkatesan Ramachandran wrote:
> > Looks good to me. But, please run end to end on secure cluster such that distcp runs (a) on the source and (b) on the target.
Done. Tested patch on secure cluster by executing distcp job on source and target cluster respectively.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review102659
-----------------------------------------------------------
On Oct. 23, 2015, 10:01 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 10:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml a1be288
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Venkatesan Ramachandran <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review102659
-----------------------------------------------------------
Ship it!
Looks good to me. But, please run end to end on secure cluster such that distcp runs (a) on the source and (b) on the target.
- Venkatesan Ramachandran
On Oct. 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml a1be288
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Oct. 15, 2015, 6:37 a.m., Venkat Ranganathan wrote:
> > I am seeing only one patch uploaded to the RB, but two are there in the JIRA. Can you upload the second patch to the RB.
> >
> > It is OK if this does not make it to 0.8 if there are more work to do for this.
Venkat,
Initially I could not able to put the patch on RB as this patch depends on FALCON-1102. At that time FALCON-1102 did not commit, so I attached the initial patch with JIRA issue.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review102760
-----------------------------------------------------------
On Oct. 23, 2015, 10:01 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Oct. 23, 2015, 10:01 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml a1be288
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review102760
-----------------------------------------------------------
I am seeing only one patch uploaded to the RB, but two are there in the JIRA. Can you upload the second patch to the RB.
It is OK if this does not make it to 0.8 if there are more work to do for this.
- Venkat Ranganathan
On Oct. 13, 2015, 1:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 1:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml a1be288
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review108109
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Nov. 26, 2015, 9:47 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Nov. 26, 2015, 9:47 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml f98e8c4
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java df16c40
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/
-----------------------------------------------------------
(Updated Nov. 26, 2015, 9:47 a.m.)
Review request for Falcon.
Changes
-------
Rebased patch.
Bugs: FALCON-1480
https://issues.apache.org/jira/browse/FALCON-1480
Repository: falcon-git
Description
-------
FALCON-1480: Gather data transfer details of Hive DR
Diffs (updated)
-----
addons/hivedr/pom.xml f98e8c4
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java df16c40
addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
Diff: https://reviews.apache.org/r/39261/diff/
Testing
-------
Yes. Manual testing done.
Thanks,
Peeyush Bishnoi
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Nov. 26, 2015, 3:25 a.m., Venkat Ranganathan wrote:
> > Thanks for working on this. Who is the consumer of this apart from the UI? Do ywe have a CLI option to display these?
Thank for the review. Currently as per the requirement, UI is only the consumer for captured metrics. But we can have CLI as another option to display the captured replication metrics from graphdb. I will create a separate issue for this to discuss more.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review108085
-----------------------------------------------------------
On Oct. 26, 2015, 5 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Oct. 26, 2015, 5 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml a1be288
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review108085
-----------------------------------------------------------
Ship it!
Thanks for working on this. Who is the consumer of this apart from the UI? Do ywe have a CLI option to display these?
- Venkat Ranganathan
On Oct. 25, 2015, 10 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Oct. 25, 2015, 10 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml a1be288
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/
-----------------------------------------------------------
(Updated Oct. 26, 2015, 5 a.m.)
Review request for Falcon.
Bugs: FALCON-1480
https://issues.apache.org/jira/browse/FALCON-1480
Repository: falcon-git
Description
-------
FALCON-1480: Gather data transfer details of Hive DR
Diffs (updated)
-----
addons/hivedr/pom.xml a1be288
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
Diff: https://reviews.apache.org/r/39261/diff/
Testing
-------
Yes. Manual testing done.
Thanks,
Peeyush Bishnoi
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/
-----------------------------------------------------------
(Updated Oct. 23, 2015, 10:01 a.m.)
Review request for Falcon.
Changes
-------
Changes after incorporating review comments
Bugs: FALCON-1480
https://issues.apache.org/jira/browse/FALCON-1480
Repository: falcon-git
Description
-------
FALCON-1480: Gather data transfer details of Hive DR
Diffs (updated)
-----
addons/hivedr/pom.xml a1be288
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
Diff: https://reviews.apache.org/r/39261/diff/
Testing
-------
Yes. Manual testing done.
Thanks,
Peeyush Bishnoi
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Oct. 13, 2015, 8:19 p.m., Venkatesan Ramachandran wrote:
> >
Thanks for the review.
> On Oct. 13, 2015, 8:19 p.m., Venkatesan Ramachandran wrote:
> > addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java, line 319
> > <https://reviews.apache.org/r/39261/diff/1/?file=1097138#file1097138line319>
> >
> > What if the distcp job fails? Are we still going to get the counters?
Fixed.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review102523
-----------------------------------------------------------
On Oct. 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml a1be288
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 39261: FALCON-1480 : Gather data transfer details
of Hive DR
Posted by Venkatesan Ramachandran <me...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39261/#review102523
-----------------------------------------------------------
addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java (line 318)
<https://reviews.apache.org/r/39261/#comment160215>
What if the distcp job fails? Are we still going to get the counters?
- Venkatesan Ramachandran
On Oct. 13, 2015, 8:58 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39261/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2015, 8:58 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1480
> https://issues.apache.org/jira/browse/FALCON-1480
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> FALCON-1480: Gather data transfer details of Hive DR
>
>
> Diffs
> -----
>
> addons/hivedr/pom.xml a1be288
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRArgs.java 574524d
> addons/hivedr/src/main/java/org/apache/falcon/hive/HiveDRTool.java bebdb0b
> addons/hivedr/src/main/java/org/apache/falcon/hive/mapreduce/CopyMapper.java 5eb8acb
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/EventUtils.java f8397ff
> addons/hivedr/src/main/java/org/apache/falcon/hive/util/HiveDRUtils.java d9d6ab0
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-secure-workflow.xml 74902b4
> addons/recipes/hive-disaster-recovery/src/main/resources/hive-disaster-recovery-workflow.xml 72d40a3
> metrics/src/main/java/org/apache/falcon/job/HiveReplicationCounters.java PRE-CREATION
> metrics/src/main/java/org/apache/falcon/job/JobCountersHandler.java e8b68ff
> metrics/src/main/java/org/apache/falcon/job/JobType.java 456e57f
>
> Diff: https://reviews.apache.org/r/39261/diff/
>
>
> Testing
> -------
>
> Yes. Manual testing done.
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>