You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/04/13 14:34:39 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #10998: [TIR] Ignore Allocate/AllocateConst in BufferAllocationLocator
Lunderberg opened a new pull request, #10998:
URL: https://github.com/apache/tvm/pull/10998
Prior to this commit, the BufferAllocationLocator mutator used in the PlanAndUpdateBufferAllocationLocation pass would erroneously insert an entry to `BlockNode::alloc_buffers` for buffers allocated using `Allocate` or `AllocateConst` nodes. This error was introduced in https://github.com/apache/tvm/pull/9727, which deprecated `Load` and `Store` nodes, replacing them with `BufferLoad` and `BufferStore` nodes. As a result, BufferAllocationLocator identified these as buffers whose allocations should be moved to inner loops, rather than as unmanaged allocations that should be ignored.
This commit restores the earlier behavior by only operating on buffer allocations in `BlockNode::alloc_buffers`, and explicitly ignoring any buffers whose allocation is done with `Allocate` or `AllocateConst`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 commented on a diff in pull request #10998: [TIR] Ignore Allocate/AllocateConst in BufferAllocationLocator
Posted by GitBox <gi...@apache.org>.
vinx13 commented on code in PR #10998:
URL: https://github.com/apache/tvm/pull/10998#discussion_r849678107
##########
tests/python/unittest/test_tir_transform_extract_constants.py:
##########
@@ -59,6 +59,8 @@ def _visit(stmt):
for n, f in mod.functions.items():
tvm.tir.stmt_functor.post_order_visit(f.body, _visit)
+ tvm.lower(mod)
Review Comment:
is this needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vinx13 merged pull request #10998: [TIR] Ignore Allocate/AllocateConst in BufferAllocationLocator
Posted by GitBox <gi...@apache.org>.
vinx13 merged PR #10998:
URL: https://github.com/apache/tvm/pull/10998
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org