You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jackrabbit.apache.org by db...@apache.org on 2013/08/24 19:33:57 UTC

svn commit: r1517168 - in /jackrabbit/trunk: jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/ jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/version/report/ jackrabbit-spi2dav/src/main/java/org/apache/jackrabb...

Author: dbrosius
Date: Sat Aug 24 17:33:56 2013
New Revision: 1517168

URL: http://svn.apache.org/r1517168
Log:
use StringBuffer correctly

Modified:
    jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/VersionControlledItemCollection.java
    jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/version/report/JcrPrivilegeReport.java
    jackrabbit/trunk/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java

Modified: jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/VersionControlledItemCollection.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/VersionControlledItemCollection.java?rev=1517168&r1=1517167&r2=1517168&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/VersionControlledItemCollection.java (original)
+++ jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/VersionControlledItemCollection.java Sat Aug 24 17:33:56 2013
@@ -682,7 +682,7 @@ public class VersionControlledItemCollec
             StringBuilder sb = new StringBuilder();
             sb.append(u.getRawPath());
             if (u.getRawQuery() != null) {
-                sb.append("?" + u.getRawQuery());
+                sb.append("?").append(u.getRawQuery());
             }
             return sb.toString();
         }

Modified: jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/version/report/JcrPrivilegeReport.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/version/report/JcrPrivilegeReport.java?rev=1517168&r1=1517167&r2=1517168&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/version/report/JcrPrivilegeReport.java (original)
+++ jackrabbit/trunk/jackrabbit-jcr-server/src/main/java/org/apache/jackrabbit/webdav/jcr/version/report/JcrPrivilegeReport.java Sat Aug 24 17:33:56 2013
@@ -139,7 +139,7 @@ public class JcrPrivilegeReport extends 
             StringBuilder sb = new StringBuilder();
             sb.append(u.getRawPath());
             if (u.getRawQuery() != null) {
-                sb.append("?" + u.getRawQuery());
+                sb.append("?").append(u.getRawQuery());
             }
             return sb.toString();
         }

Modified: jackrabbit/trunk/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java
URL: http://svn.apache.org/viewvc/jackrabbit/trunk/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java?rev=1517168&r1=1517167&r2=1517168&view=diff
==============================================================================
--- jackrabbit/trunk/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java (original)
+++ jackrabbit/trunk/jackrabbit-spi2dav/src/main/java/org/apache/jackrabbit/spi2dav/RepositoryServiceImpl.java Sat Aug 24 17:33:56 2013
@@ -429,14 +429,14 @@ public class RepositoryServiceImpl imple
 
             String sessionIdentifier = ((SessionInfoImpl) sessionInfo)
                     .getSessionIdentifier();
-            linkHeaderField.append("<" + sessionIdentifier + ">; rel=\""
-                    + JcrRemotingConstants.RELATION_REMOTE_SESSION_ID + "\"");
+            linkHeaderField.append("<").append(sessionIdentifier).append(">; rel=\"")
+                    .append(JcrRemotingConstants.RELATION_REMOTE_SESSION_ID).append("\"");
 
             String userdata = ((SessionInfoImpl) sessionInfo).getUserData();
             if (userdata != null && ! isReadAccess) {
                 String escaped = Text.escape(userdata);
-                linkHeaderField.append((", <data:," + escaped + ">; rel=\""
-                        + JcrRemotingConstants.RELATION_USER_DATA + "\""));
+                linkHeaderField.append(", <data:,").append(escaped).append(">; rel=\"")
+                    .append(JcrRemotingConstants.RELATION_USER_DATA).append("\"");
             }
 
             method.addRequestHeader("Link", linkHeaderField.toString());
@@ -2847,7 +2847,7 @@ public class RepositoryServiceImpl imple
             StringBuilder sb = new StringBuilder();
             sb.append(u.getRawPath());
             if (u.getRawQuery() != null) {
-                sb.append("?" + u.getRawQuery());
+                sb.append("?").append(u.getRawQuery());
             }
             return sb.toString();
         }