[jira] [Commented] (AURORA-145) Test dependencies leak into distribution

["Bill Farner (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AURORA-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13887556#comment-13887556 ] 

Bill Farner commented on AURORA-145:
------------------------------------

Some code rearrangement would be necessary for this to be done cleanly.  We pull in junit through twitter.common.testing, and that's currently part of our main code:
{noformat}
$ find src -name *.java | xargs grep twitter.common.testing | grep main
src/main/java/org/apache/aurora/scheduler/cron/testing/AbstractCronIT.java:import com.twitter.common.testing.easymock.EasyMockTest;
src/main/java/org/apache/aurora/scheduler/storage/testing/StorageTestUtil.java:import com.twitter.common.testing.easymock.EasyMockTest;
{noformat}

If the ultimate goal is to reduce the distribution size, there may be lower-hanging fruit:
{noformat}
$ zipinfo dist/distributions/aurora-scheduler-0.5.0-SNAPSHOT.zip | grep -v Archive | awk '{print $4,$9}' | sort -rn | head
8857794 aurora-scheduler-0.5.0-SNAPSHOT/lib/scala-library-2.9.2.jar
3268188 aurora-scheduler-0.5.0-SNAPSHOT/lib/aurora-0.5.0-SNAPSHOT.jar
2172168 aurora-scheduler-0.5.0-SNAPSHOT/lib/guava-15.0.jar
933714 aurora-scheduler-0.5.0-SNAPSHOT/lib/util-core-6.8.1.jar
890168 aurora-scheduler-0.5.0-SNAPSHOT/lib/jaxb-impl-2.2.3-1.jar
765648 aurora-scheduler-0.5.0-SNAPSHOT/lib/jackson-mapper-asl-1.9.2.jar
710492 aurora-scheduler-0.5.0-SNAPSHOT/lib/guice-3.0.jar
604182 aurora-scheduler-0.5.0-SNAPSHOT/lib/zookeeper-3.3.4.jar
596901 aurora-scheduler-0.5.0-SNAPSHOT/lib/jersey-server-1.12.jar
581571 aurora-scheduler-0.5.0-SNAPSHOT/lib/joda-time-2.3.jar
{noformat}

And within our own jar:
{noformat}
$ zipinfo dist/libs/aurora-0.5.0-SNAPSHOT.jar | grep -v Archive | awk '{print $4,$9}' | sort -rn | head
724155 bower_components/angular/angular.js
269462 bower_components/angular/angular.min.js.map
265217 bower_components/jquery/jquery.js
127352 bower_components/bootstrap.css/css/bootstrap.css
109237 api_types.js
106015 bower_components/bootstrap.css/css/bootstrap.min.css
100023 bower_components/angular/angular.min.js
70857 org/apache/aurora/scheduler/http/assets/datatables/js/jquery.dataTables.min.js
64585 AuroraAdmin.js
61962 bower_components/bootstrap.css/js/bootstrap.js
{noformat}

> Test dependencies leak into distribution
> ----------------------------------------
>
>                 Key: AURORA-145
>                 URL: https://issues.apache.org/jira/browse/AURORA-145
>             Project: Aurora
>          Issue Type: Bug
>          Components: Scheduler
>            Reporter: Kevin Sweeney
>            Priority: Minor
>              Labels: newbie
>
> Our generated gradle distribution contains test dependencies like easymock and junit. Remove them and shave a few MB.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)