You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by Poltergeist <gi...@git.apache.org> on 2015/02/08 17:02:06 UTC
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
GitHub user Poltergeist opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/261
add a warning for deletion of a systemdatabase on a cluster.
Add a warning if the current database is an internal cluster database
and _stats is available on that note. _stats is only available if
it is a cluster internal node.
The warning is only shown for databases with the name:
- _replicator
- _users
- dbs
- nodes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Poltergeist/couchdb-fauxton feature/system-database-warning
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/261.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #261
----
commit e71ec904341976d8fd38f85e6610c1f027eb1e87
Author: Poltergeist <sp...@gmail.com>
Date: 2015-02-08T15:49:19Z
add a warning for deletion of a systemdatabase on a cluster.
Add a warning if the current database is an internal cluster database
and _stats is available on that note. _stats is only available if
it is a cluster internal node.
The warning is only shown for databases with the name:
- _replicator
- _users
- dbs
- nodes
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-76754478
@Poltergeist @kxepal will take care of that now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by Poltergeist <gi...@git.apache.org>.
Github user Poltergeist commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-75119250
I'll add the cassim database. I just didn't know about the cassim database.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-74504792
@Poltergeist there is a slight bug. When I try delete a database the database name doesn't appear in the modal. See screenshot. I've added a comment on how to fix it. Other than that it is looking good. Once the bug is fixed we can merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-75121082
No worries. Nobody known (: Thought it might be also good idea to make all system databases with leading `_` to make sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#discussion_r24748949
--- Diff: app/addons/documents/views.js ---
@@ -145,9 +145,16 @@ function (app, FauxtonAPI, Components, Documents,
template: "addons/documents/templates/delete_database_modal",
initialize: function (options) {
this.database = options.database;
+ this.isSystemDatabase = options.isSystemDatabase;
FauxtonAPI.Events.on('database:delete', this.showDeleteDatabase, this);
},
+ serialize: function () {
+ return {
+ isSystemDatabase: this.isSystemDatabase
--- End diff --
This serialize function also needs to return database. You need to make the return this:
return {
isSystemDatabase: this.isSystemDatabase,
database: this.database
};
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-76597305
@Poltergeist [COUCHDB-2619](https://issues.apache.org/jira/browse/COUCHDB-2619) fixed so all system databases are starts with underscore no matter on which iface they are. Could you please submit new PR? I'd tried by my own, but I don't understand what is going on in `IsSystemDatabaseModel`, why there is need to request `_stats` (which I strongly believe causes [COUCHDB-2607](https://issues.apache.org/jira/browse/COUCHDB-2607) ) when you could just GET app.host and look if uuid is in the response and how to turn it into simple property of Database model without ruining everything. Thanks (:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by Poltergeist <gi...@git.apache.org>.
Github user Poltergeist commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-74924785
@garrensmith added the test and also merged the master branch into this branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-75045866
Thanks for this @Poltergeist this is great. I've merged it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by Poltergeist <gi...@git.apache.org>.
Github user Poltergeist commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-73804086
@garrensmith I'll add tests asap in the next days.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by kxepal <gi...@git.apache.org>.
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-75046135
cassim database is missed in the list.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-73691017
@Poltergeist @robertkowalski this looks great. Could you add a few tests for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by Poltergeist <gi...@git.apache.org>.
Github user Poltergeist commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-74274728
Added test cases for the parse function of the new model.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by Poltergeist <gi...@git.apache.org>.
Github user Poltergeist commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/261#issuecomment-75126129
I added the cassim database in another pull request. Test for the _ prefixed names could be a good idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: add a warning for deletion of a syst...
Posted by Poltergeist <gi...@git.apache.org>.
Github user Poltergeist closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/261
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---