You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@wink.apache.org by "Seshu Pasam (Updated) (JIRA)" <ji...@apache.org> on 2011/10/07 05:06:31 UTC
[jira] [Updated] (WINK-352) AbstractJAXBProvider:
getJAXBUnmarshaller is final (unlike getJAXBMarshaller)
[ https://issues.apache.org/jira/browse/WINK-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Seshu Pasam updated WINK-352:
-----------------------------
Attachment: AbstractJAXBProvider.diff
Thanks Raymond. Attached is the patch. All tests pass fine. I did the full build.
BTW, nice work. I tried various open source implementations and Wink has been the easiest with good design.
> AbstractJAXBProvider: getJAXBUnmarshaller is final (unlike getJAXBMarshaller)
> -----------------------------------------------------------------------------
>
> Key: WINK-352
> URL: https://issues.apache.org/jira/browse/WINK-352
> Project: Wink
> Issue Type: Bug
> Components: Client
> Affects Versions: 1.1.3
> Reporter: Seshu Pasam
> Attachments: AbstractJAXBProvider.diff
>
>
> I am extending AbstractJAXBProvider and found that getJAXBUnmarshaller is final (unlike getJAXBMarshaller). It is just inconsistent and would be useful if these methods are not final.
> I am actually more interested in overriding AbstractJAXBProvider#getXMLStreamReader(...) calls and these are marked as static. It would be useful if these methods are not static. I can then wrap the XMLStreamReader to deal with XML parsing case sensitivity issues like:
> javax.xml.bind.UnmarshalException: unexpected element (uri:"", local:"Time"). Expected elements are <{}time>
> Simple changes:
> a.) Remove final keyword on AbstractJAXBProvider#getJAXBUnmarshaller()
> b.) Remove static keyword on AbstractJAXBProvider#getXMLStreamReader(InputStream) and AbstractJAXBProvider#getXMLStreamReader(InputStreamReader)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] [Updated] (WINK-352) AbstractJAXBProvider: getJAXBUnmarshaller is final (unlike getJAXBMarshaller)
Posted by Raymond Feng <en...@gmail.com>.
Patch applied.
Thanks,
Raymond
________________________________________________________________
Raymond Feng
rfeng@apache.org
Apache Software Foundation Member
Apache Tuscany PMC member and committer: tuscany.apache.org
Co-author of Tuscany SCA In Action book: www.tuscanyinaction.com
Personal Web Site: www.enjoyjava.com
________________________________________________________________
On Oct 6, 2011, at 8:06 PM, Seshu Pasam (Updated) (JIRA) wrote:
>
> [ https://issues.apache.org/jira/browse/WINK-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Seshu Pasam updated WINK-352:
> -----------------------------
>
> Attachment: AbstractJAXBProvider.diff
>
> Thanks Raymond. Attached is the patch. All tests pass fine. I did the full build.
>
> BTW, nice work. I tried various open source implementations and Wink has been the easiest with good design.
>
>> AbstractJAXBProvider: getJAXBUnmarshaller is final (unlike getJAXBMarshaller)
>> -----------------------------------------------------------------------------
>>
>> Key: WINK-352
>> URL: https://issues.apache.org/jira/browse/WINK-352
>> Project: Wink
>> Issue Type: Bug
>> Components: Client
>> Affects Versions: 1.1.3
>> Reporter: Seshu Pasam
>> Attachments: AbstractJAXBProvider.diff
>>
>>
>> I am extending AbstractJAXBProvider and found that getJAXBUnmarshaller is final (unlike getJAXBMarshaller). It is just inconsistent and would be useful if these methods are not final.
>> I am actually more interested in overriding AbstractJAXBProvider#getXMLStreamReader(...) calls and these are marked as static. It would be useful if these methods are not static. I can then wrap the XMLStreamReader to deal with XML parsing case sensitivity issues like:
>> javax.xml.bind.UnmarshalException: unexpected element (uri:"", local:"Time"). Expected elements are <{}time>
>> Simple changes:
>> a.) Remove final keyword on AbstractJAXBProvider#getJAXBUnmarshaller()
>> b.) Remove static keyword on AbstractJAXBProvider#getXMLStreamReader(InputStream) and AbstractJAXBProvider#getXMLStreamReader(InputStreamReader)
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>