You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Doug Davies (JIRA)" <ji...@apache.org> on 2011/06/15 20:14:47 UTC
[jira] [Created] (SHINDIG-1549) gadgets.metadata request fails for
gadgets that don't have a "default" view
gadgets.metadata request fails for gadgets that don't have a "default" view
---------------------------------------------------------------------------
Key: SHINDIG-1549
URL: https://issues.apache.org/jira/browse/SHINDIG-1549
Project: Shindig
Issue Type: Bug
Components: Java
Affects Versions: 3.0.0
Environment: Mac OSX
Reporter: Doug Davies
The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
if (needIfrUrl && gadget.getCurrentView() == null) {
throw new ProcessingException("View " + request.getView() + " does not exist",
HttpResponse.SC_BAD_REQUEST);
}
The gadget.getCurrentView returns null if no "default" view is defined.
You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
RE: [jira] [Commented] (SHINDIG-1549) gadgets.metadata request
fails for gadgets that don't have a "default" view
Posted by "Ciancetta, Jesse E." <jc...@mitre.org>.
Hmm... Looks like I don’t have the proper role in Shindig JIRA to be able to resolve tickets I didn’t submit.
Could someone with administrative privileges over the Shindig JIRA project please grant me the needed privileges?
Thanks!
--Jesse
>-----Original Message-----
>From: Jesse Ciancetta (Commented) (JIRA) [mailto:jira@apache.org]
>Sent: Friday, December 23, 2011 8:31 AM
>To: issues@shindig.apache.org
>Subject: [jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
>for gadgets that don't have a "default" view
>
>
> [ https://issues.apache.org/jira/browse/SHINDIG-
>1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
>tabpanel&focusedCommentId=13175419#comment-13175419 ]
>
>Jesse Ciancetta commented on SHINDIG-1549:
>------------------------------------------
>
>This appears to have been fixed -- I just tried the wikipedia gadget with
>common container running from trunk and it rendered fine (and I verified that
>there is still no "default" view) so I'm going to go ahead and mark this as fixed.
>Doug -- if you're still having issues with this please re-open.
>
>> gadgets.metadata request fails for gadgets that don't have a "default" view
>> ---------------------------------------------------------------------------
>>
>> Key: SHINDIG-1549
>> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
>> Project: Shindig
>> Issue Type: Bug
>> Components: Java
>> Affects Versions: 3.0.0
>> Environment: Mac OSX
>> Reporter: Doug Davies
>>
>> The request for gadgets.metadata fails for a gadget spec that doesn't
>specify a "default" view. For example
>http://www.google.com/ig/modules/wikipedia.xml. The reason is in
>GadgetsHandlerService.java.
>> if (needIfrUrl && gadget.getCurrentView() == null) {
>> throw new ProcessingException("View " + request.getView() + " does
>not exist",
>> HttpResponse.SC_BAD_REQUEST);
>> }
>> The gadget.getCurrentView returns null if no "default" view is defined.
>> You can see this behavior by testing in the commoncontainer sample and
>trying to load the wikipedia gadget.
>
>--
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly, please contact your JIRA administrators:
>https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
RE: [jira] [Commented] (SHINDIG-1549) gadgets.metadata request
fails for gadgets that don't have a "default" view
Posted by "Ciancetta, Jesse E." <jc...@mitre.org>.
Hmm... Looks like I don’t have the proper role in Shindig JIRA to be able to resolve tickets I didn’t submit.
Could someone with administrative privileges over the Shindig JIRA project please grant me the needed privileges?
Thanks!
--Jesse
>-----Original Message-----
>From: Jesse Ciancetta (Commented) (JIRA) [mailto:jira@apache.org]
>Sent: Friday, December 23, 2011 8:31 AM
>To: issues@shindig.apache.org
>Subject: [jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
>for gadgets that don't have a "default" view
>
>
> [ https://issues.apache.org/jira/browse/SHINDIG-
>1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
>tabpanel&focusedCommentId=13175419#comment-13175419 ]
>
>Jesse Ciancetta commented on SHINDIG-1549:
>------------------------------------------
>
>This appears to have been fixed -- I just tried the wikipedia gadget with
>common container running from trunk and it rendered fine (and I verified that
>there is still no "default" view) so I'm going to go ahead and mark this as fixed.
>Doug -- if you're still having issues with this please re-open.
>
>> gadgets.metadata request fails for gadgets that don't have a "default" view
>> ---------------------------------------------------------------------------
>>
>> Key: SHINDIG-1549
>> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
>> Project: Shindig
>> Issue Type: Bug
>> Components: Java
>> Affects Versions: 3.0.0
>> Environment: Mac OSX
>> Reporter: Doug Davies
>>
>> The request for gadgets.metadata fails for a gadget spec that doesn't
>specify a "default" view. For example
>http://www.google.com/ig/modules/wikipedia.xml. The reason is in
>GadgetsHandlerService.java.
>> if (needIfrUrl && gadget.getCurrentView() == null) {
>> throw new ProcessingException("View " + request.getView() + " does
>not exist",
>> HttpResponse.SC_BAD_REQUEST);
>> }
>> The gadget.getCurrentView returns null if no "default" view is defined.
>> You can see this behavior by testing in the commoncontainer sample and
>trying to load the wikipedia gadget.
>
>--
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly, please contact your JIRA administrators:
>https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
>For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195334#comment-13195334 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
This addresses bug SHINDIG-1549.
https://issues.apache.org/jira/browse/SHINDIG-1549
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
Diff: https://reviews.apache.org/r/3670/diff
Testing
-------
Updated unit tests and tested in the various containers
Thanks,
Ryan
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1549) gadgets.metadata request fails for
gadgets that don't have a "default" view
Posted by "Stanton Sievers (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stanton Sievers resolved SHINDIG-1549.
--------------------------------------
Closed by Ryan per his comments.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
> Attachments: issue-1549.patch
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "Ryan Baxter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196659#comment-13196659 ]
Ryan Baxter commented on SHINDIG-1549:
--------------------------------------
Doug, could you close this JIRA I have submitted the change.
Committed revision 1238135.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
> Attachments: issue-1549.patch
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1549) gadgets.metadata request fails for
gadgets that don't have a "default" view
Posted by "Ryan Baxter (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ryan Baxter updated SHINDIG-1549:
---------------------------------
Attachment: issue-1549.patch
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
> Attachments: issue-1549.patch
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "Ryan Baxter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193220#comment-13193220 ]
Ryan Baxter commented on SHINDIG-1549:
--------------------------------------
I figured out what is going on. The default view is aliased to home, profile, and canvas, so if that gadget has one of those other views everything works fine. I seem to remember this changing going in a while ago so this is probably why the gadget started working. However if your gadget doesn't have a home, profile, or canvas view then it will still fail.
The crux of the problem appears to be in the way the metadata request is handled on the server when the iFrame URL is requested by the container. When the server constructs the response to a metadata request it will try and build the iFrame URL and part of the iFrame URL is the view to render. The metadata request handler creates a GadgetContext object, it looks to see if a view was specified in the metadata request and if its not it will set the view for the GadgetContext object to default. When we process the GadgetContext object in GadgetHandlerService.getMetadata to create a Gadget object we try to get the view from the GadgetSpec. In the case of a metadata request for a gadget with no default view the Gadget object will have a null view, which in turn causes any metadata request, which needs the iFrame URL, to fail.
The metadata request, correctly, does not send any view along with it to the server when making a metadata request. This makes sense because you are requesting the metadata for the gadget and the container does not necessarily know what view it is going to render. However the DefaultIFrameUriManager.getIframeUrl_ method uses the view for several things when constructing the iFrame URL returned in the metadata request.
1.) Sets the view query parameter in the iFrame URL. This does not necessarily need to happen on the server as the common container will set it again in GadgetHolder.getIframeUrl_
2.) If the view for the iFrame URL has the type URL then it will add all the Javascript libs for this view to the URL.
3.) Its used to determine whether user preferences in the iFrame URL should be added as query parameters or as fragments. The user preferences will be added as query parameters is the view needs to do user pref subsitution using __UP_ or if the view has the type URL. I assume the reason for adding them as fragments for everything else is because it allows the browser to cache the gadget. When we rewrite the gadget we only ever look at preferences in the query parameters not in the fragments, which makes sense since we would only ever be doing substitution in that case.
The fact that the metadata response is cached in the common container and we just replace key query parameters in the common container when we switch views in that gadget reveals another bug. If the default view of the gadget you are rendering is of type URL, than the metadata response you get back will have an IFR URL for the URL view. In other words it will pretty much be the href property of the view. If you switch to another view in that gadget we will get the cached metadata and replace the view parameter in the IFR URL, but the IFR URL is the href property from the default URL view and the content in the gadget is incorrect!
My proposed solution to the problem is to actually return the IFR URLs for all the different views in the gadget in the metadata request. While this will increase the response size, it is the only way to guarantee we will be using the correct IFR URL for the correct view we are trying to render.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "Jesse Ciancetta (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175419#comment-13175419 ]
Jesse Ciancetta commented on SHINDIG-1549:
------------------------------------------
This appears to have been fixed -- I just tried the wikipedia gadget with common container running from trunk and it rendered fine (and I verified that there is still no "default" view) so I'm going to go ahead and mark this as fixed. Doug -- if you're still having issues with this please re-open.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195333#comment-13195333 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/
-----------------------------------------------------------
(Updated 2012-01-28 01:17:22.559949)
Review request for shindig.
Summary
-------
The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
This addresses bug SHINDIG-1549.
https://issues.apache.org/jira/browse/SHINDIG-1549
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
Diff: https://reviews.apache.org/r/3670/diff
Testing
-------
Updated unit tests and tested in the various containers
Thanks,
Ryan
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196173#comment-13196173 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/
-----------------------------------------------------------
(Updated 2012-01-30 15:29:59.387801)
Review request for shindig.
Changes
-------
Updated with Henry's and Stanton's suggestions
Summary
-------
The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
This addresses bug SHINDIG-1549.
https://issues.apache.org/jira/browse/SHINDIG-1549
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
Diff: https://reviews.apache.org/r/3670/diff
Testing
-------
Updated unit tests and tested in the various containers
Thanks,
Ryan
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1549) gadgets.metadata request fails for
gadgets that don't have a "default" view
Posted by "Doug Davies (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Davies closed SHINDIG-1549.
--------------------------------
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195937#comment-13195937 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/#review4684
-----------------------------------------------------------
Ship it!
+1 Other than small nit/suggestion about iframeUrls param name.
- Henry
On 2012-01-28 01:17:22, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3670/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-28 01:17:22)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
bq.
bq.
bq. This addresses bug SHINDIG-1549.
bq. https://issues.apache.org/jira/browse/SHINDIG-1549
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
bq.
bq. Diff: https://reviews.apache.org/r/3670/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests and tested in the various containers
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195563#comment-13195563 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/#review4672
-----------------------------------------------------------
My biggest concern with this change is that it breaks backwards compatibility. There is no longer "iframeurl" on the metadata responses. This isn't a big deal if everyone is using the common container, since you've updated that portion, but if they aren't, then this will cause problems. Maybe not a big deal, as the metadata request/response is not spec'd. Something to consider and get more feedback on from the rest of the dev list.
Also, have you tried this out with requestNavigateTo functionality or the view switching functionality (as in the sample common container)? With this patch the CC shouldn't have to re-issue any metadata requests because it has everything it needs. I want to make sure that is indeed the case.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
<https://reviews.apache.org/r/3670/#comment10391>
Can we strip out the gmodules language? I've never noticed it being here before.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js
<https://reviews.apache.org/r/3670/#comment10392>
With your changes, uri is now the uri with render params and other query params set on it. Is that necessary for the patch? I'd like to not change this behavior if you don't have to.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
<https://reviews.apache.org/r/3670/#comment10393>
Trailing whitespace
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java
<https://reviews.apache.org/r/3670/#comment10394>
Make this protected so that anyone can override this functionality. Prior to your changes they would have been able to do that by overriding makeRenderingUri().
- Stanton
On 2012-01-28 01:17:22, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3670/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-28 01:17:22)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
bq.
bq.
bq. This addresses bug SHINDIG-1549.
bq. https://issues.apache.org/jira/browse/SHINDIG-1549
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
bq.
bq. Diff: https://reviews.apache.org/r/3670/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests and tested in the various containers
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "Jesse Ciancetta (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175423#comment-13175423 ]
Jesse Ciancetta commented on SHINDIG-1549:
------------------------------------------
Hmm... Looks like I don’t have the proper role in Shindig JIRA to be able to resolve tickets I didn’t submit.
Could someone with administrative privileges over the Shindig JIRA project please grant me the needed privileges?
Thanks!
--Jesse
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196224#comment-13196224 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/#review4690
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-01-30 15:29:59, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3670/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-30 15:29:59)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
bq.
bq.
bq. This addresses bug SHINDIG-1549.
bq. https://issues.apache.org/jira/browse/SHINDIG-1549
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
bq.
bq. Diff: https://reviews.apache.org/r/3670/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests and tested in the various containers
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196129#comment-13196129 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/#review4687
-----------------------------------------------------------
LGTM other than the comments Stanton already made. Re: backcompat, if it's an issue could we also return the 'iframeurl' in the metadata response as it always came back? at that point we'd just be adding stuff for the CC until others catch up.
- Dan
On 2012-01-28 01:17:22, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3670/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-28 01:17:22)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
bq.
bq.
bq. This addresses bug SHINDIG-1549.
bq. https://issues.apache.org/jira/browse/SHINDIG-1549
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
bq.
bq. Diff: https://reviews.apache.org/r/3670/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests and tested in the various containers
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196172#comment-13196172 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
bq. On 2012-01-28 15:17:28, Stanton Sievers wrote:
bq. > My biggest concern with this change is that it breaks backwards compatibility. There is no longer "iframeurl" on the metadata responses. This isn't a big deal if everyone is using the common container, since you've updated that portion, but if they aren't, then this will cause problems. Maybe not a big deal, as the metadata request/response is not spec'd. Something to consider and get more feedback on from the rest of the dev list.
bq. >
bq. > Also, have you tried this out with requestNavigateTo functionality or the view switching functionality (as in the sample common container)? With this patch the CC shouldn't have to re-issue any metadata requests because it has everything it needs. I want to make sure that is indeed the case.
RE backwards compatibility
I realize this. Since this is the first release of Shindig with the common container I think it is fine to break the "API". However if someone have a need for that functionality I can add it back in.
RE requestNavigateTo
Even before this change we only ever made 1 request to get the metadata for the gadget. When switching views we used the cached metadata. This was part of the problem. The cache is indexed by gadget URL so switching views and / or subsequent calls to requestNavigateTo always resulted in using the cached metadata.
bq. On 2012-01-28 15:17:28, Stanton Sievers wrote:
bq. > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js, line 169
bq. > <https://reviews.apache.org/r/3670/diff/3/?file=71190#file71190line169>
bq. >
bq. > With your changes, uri is now the uri with render params and other query params set on it. Is that necessary for the patch? I'd like to not change this behavior if you don't have to.
It was not necessary, but it seemed odd to me that we were not using the actual URL in the iFrame when setting up relay uri. If getIframeUrl_ changed the URL in some way that would effect setting up RPC then we might be in trouble. I figured it would be best to use the same URL that the iFrame will contain.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/#review4672
-----------------------------------------------------------
On 2012-01-30 15:29:59, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3670/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-30 15:29:59)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
bq.
bq.
bq. This addresses bug SHINDIG-1549.
bq. https://issues.apache.org/jira/browse/SHINDIG-1549
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
bq.
bq. Diff: https://reviews.apache.org/r/3670/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests and tested in the various containers
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13196656#comment-13196656 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/#review4699
-----------------------------------------------------------
Committed revision 1238135.
- Ryan
On 2012-01-30 15:29:59, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3670/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-30 15:29:59)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
bq.
bq.
bq. This addresses bug SHINDIG-1549.
bq. https://issues.apache.org/jira/browse/SHINDIG-1549
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
bq.
bq. Diff: https://reviews.apache.org/r/3670/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests and tested in the various containers
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "Ryan Baxter (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13192408#comment-13192408 ]
Ryan Baxter commented on SHINDIG-1549:
--------------------------------------
Doug and Jesse, I am still seeing this problem. I could not verify with the gadget above because I was getting a 404, but I tried it with another gadget I had and I still see the metadata request failing because the gadget does not have a default view.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "Jesse Ciancetta (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193003#comment-13193003 ]
Jesse Ciancetta commented on SHINDIG-1549:
------------------------------------------
Are you sure whatever error your seeing is due to lack of a default view? The wikipedia gadget was moved to here:
http://www.gstatic.com/ig/modules/wikipedia/wikipedia.xml
and still doesn't have a default view -- but I just tested it with common container running from trunk and it seems to work fine.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (SHINDIG-1549) gadgets.metadata request fails for
gadgets that don't have a "default" view
Posted by "Doug Davies (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Davies resolved SHINDIG-1549.
----------------------------------
Resolution: Fixed
Fix Version/s: 3.0.0
Closing per Jesse's comment.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195936#comment-13195936 ]
jiraposter@reviews.apache.org commented on SHINDIG-1549:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3670/#review4683
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
<https://reviews.apache.org/r/3670/#comment10425>
I think we could just call this "iframeUrls". Should be implicitly imply all for the metadata call since we dont pass any view param.
- Henry
On 2012-01-28 01:17:22, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3670/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-28 01:17:22)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view.
bq.
bq.
bq. This addresses bug SHINDIG-1549.
bq. https://issues.apache.org/jira/browse/SHINDIG-1549
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManagerTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/FakeIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/IframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/DefaultIframeUriManager.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1236884
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/uri/UriManagerTestBase.java 1236884
bq.
bq. Diff: https://reviews.apache.org/r/3670/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests and tested in the various containers
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1549) gadgets.metadata request fails
for gadgets that don't have a "default" view
Posted by "Doug Davies (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175452#comment-13175452 ]
Doug Davies commented on SHINDIG-1549:
--------------------------------------
I went ahead and closed it. Thanks for verifying.
Doug
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 3.0.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 3.0.0
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1549) gadgets.metadata request fails for
gadgets that don't have a "default" view
Posted by "Doug Davies (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Davies closed SHINDIG-1549.
--------------------------------
> gadgets.metadata request fails for gadgets that don't have a "default" view
> ---------------------------------------------------------------------------
>
> Key: SHINDIG-1549
> URL: https://issues.apache.org/jira/browse/SHINDIG-1549
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Environment: Mac OSX
> Reporter: Doug Davies
> Fix For: 2.5.0
>
> Attachments: issue-1549.patch
>
>
> The request for gadgets.metadata fails for a gadget spec that doesn't specify a "default" view. For example http://www.google.com/ig/modules/wikipedia.xml. The reason is in GadgetsHandlerService.java.
> if (needIfrUrl && gadget.getCurrentView() == null) {
> throw new ProcessingException("View " + request.getView() + " does not exist",
> HttpResponse.SC_BAD_REQUEST);
> }
> The gadget.getCurrentView returns null if no "default" view is defined.
> You can see this behavior by testing in the commoncontainer sample and trying to load the wikipedia gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira