[GitHub] [daffodil] mbeckerle-yahoo commented on a diff in pull request #812: Use Exificient to support EXI format for infosets

[GitBox <gi...@apache.org>]

mbeckerle-yahoo commented on code in PR #812:
URL: https://github.com/apache/daffodil/pull/812#discussion_r926850696


##########
daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala:
##########
@@ -873,8 +883,6 @@ object Main {
 
               val parseResult = eitherOutputterOrHandler match {
                 case Right(saxContentHandler) =>
-                  // reset in case we are streaming
-                  saxContentHandler.reset()

Review Comment:
   We should error here until we know what we're doing with trying to use EXI for streaming. I have no idea if EXI files concatenated can be processed in any sensible way, are self-length aware, etc. XML is not sensible this way. It really wants to read until "end of data" before issuing an endDocument() SAX call/event. Some experiments are really needed here to see whether a sensible stream of SAX events can come from concatenated EXI data, or not. We may find that EXI streaming requires trickery like putting a length header on each chunk. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org