[commons-beanutils] 05/08: Make instance variable final

[gg...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-beanutils.git

commit 1ffdb370bd354cfc2c242d18e56cf8597905c802
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Wed Feb 8 14:13:15 2023 -0500

    Make instance variable final
---
 .../org/apache/commons/beanutils2/locale/BaseLocaleConverter.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
index 7bdbf45b..640a272f 100644
--- a/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
+++ b/src/main/java/org/apache/commons/beanutils2/locale/BaseLocaleConverter.java
@@ -40,7 +40,7 @@ public abstract class BaseLocaleConverter<T> implements LocaleConverter<T> {
     private final Log log = LogFactory.getLog(BaseLocaleConverter.class);
 
     /** The default value specified to our Constructor, if any. */
-    private Object defaultValue;
+    private final Object defaultValue;
 
     /** Should we return the default value on conversion errors? */
     protected final boolean useDefault;
@@ -117,9 +117,7 @@ public abstract class BaseLocaleConverter<T> implements LocaleConverter<T> {
      */
     private BaseLocaleConverter(final Object defaultValue, final Locale locale,
             final String pattern, final boolean useDefault, final boolean locPattern) {
-        if (useDefault) {
-            this.defaultValue = defaultValue;
-        }
+        this.defaultValue = useDefault ? defaultValue : null;
         this.useDefault = useDefault;
         this.locale = locale != null ? locale : Locale.getDefault();
         this.pattern = pattern;