You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "rodrigonull (via GitHub)" <gi...@apache.org> on 2023/12/15 13:47:10 UTC

[PR] kie-issues#755: Fix kogito operator nightly deploy pipelines [incubator-kie-kogito-serverless-operator]

rodrigonull opened a new pull request, #323:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/323

   Initial fixes for kogito-serverless-oprator nightly pipeline


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#755: Fix kogito operator nightly deploy pipelines [incubator-kie-kogito-serverless-operator]

Posted by "rodrigonull (via GitHub)" <gi...@apache.org>.
rodrigonull merged PR #323:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#755: Fix kogito operator nightly deploy pipelines [incubator-kie-kogito-serverless-operator]

Posted by "rodrigonull (via GitHub)" <gi...@apache.org>.
rodrigonull commented on code in PR #323:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/323#discussion_r1439779747


##########
.ci/jenkins/scripts/minikube.groovy:
##########
@@ -100,8 +100,9 @@ void preChecks() {
         ${minikubeContainerEngine} info
 
         if [[ ! \$(command -v minikube) ]]; then
-            curl -LO https://github.com/kubernetes/minikube/releases/download/v${minikubeVersion}/minikube-${minikubeVersion}-0.x86_64.rpm
-            sudo yum localinstall -y minikube-${minikubeVersion}-0.x86_64.rpm
+            curl -LO https://github.com/kubernetes/minikube/releases/download/v${minikubeVersion}/minikube-linux-amd64
+            sudo cp minikube-linux-amd64 /usr/local/bin/minikube
+            sudo chmod 755 /usr/local/bin/minikube

Review Comment:
   I've applied the suggested change. Thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org


Re: [PR] kie-issues#755: Fix kogito operator nightly deploy pipelines [incubator-kie-kogito-serverless-operator]

Posted by "ricardozanini (via GitHub)" <gi...@apache.org>.
ricardozanini commented on code in PR #323:
URL: https://github.com/apache/incubator-kie-kogito-serverless-operator/pull/323#discussion_r1428002670


##########
.ci/jenkins/scripts/minikube.groovy:
##########
@@ -100,8 +100,9 @@ void preChecks() {
         ${minikubeContainerEngine} info
 
         if [[ ! \$(command -v minikube) ]]; then
-            curl -LO https://github.com/kubernetes/minikube/releases/download/v${minikubeVersion}/minikube-${minikubeVersion}-0.x86_64.rpm
-            sudo yum localinstall -y minikube-${minikubeVersion}-0.x86_64.rpm
+            curl -LO https://github.com/kubernetes/minikube/releases/download/v${minikubeVersion}/minikube-linux-amd64
+            sudo cp minikube-linux-amd64 /usr/local/bin/minikube
+            sudo chmod 755 /usr/local/bin/minikube

Review Comment:
   We have a script to do this, maybe it's worth reusing it? https://github.com/apache/incubator-kie-kogito-serverless-operator/blob/main/hack/ci/install-minikube.sh
   
   There we are able to fetch the correct minikube version based on the platform, so we avoid hardcoding here. wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org