You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/10/31 13:05:00 UTC

[jira] [Commented] (ARTEMIS-4064) Harden MetricsManager

    [ https://issues.apache.org/jira/browse/ARTEMIS-4064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17626579#comment-17626579 ] 

ASF subversion and git services commented on ARTEMIS-4064:
----------------------------------------------------------

Commit ccb76c0a2a1055e83ddfdbbda5049b97b2389b16 in activemq-artemis's branch refs/heads/main from Justin Bertram
[ https://gitbox.apache.org/repos/asf?p=activemq-artemis.git;h=ccb76c0a2a ]

ARTEMIS-4064 Harden MetricsManager

In order to improve trouble-shooting for the MetricsManager there should
be additional logging and exceptions. In all, this commit contains the
following changes:

 - Additional logging
 - Throw an exception when registering meters if meters already exist
 - Rename a few variables & methods to more clearly identify what they
   are used for
 - Upgrade Micrometer to 1.9.5
 - Simplify/clarify a few blocks of code
 - No longer pass the ManagementServiceImpl when registering the
   metrics, but instead pass the Object the meter is observing (e.g.
   broker, address, or queue)


> Harden MetricsManager
> ---------------------
>
>                 Key: ARTEMIS-4064
>                 URL: https://issues.apache.org/jira/browse/ARTEMIS-4064
>             Project: ActiveMQ Artemis
>          Issue Type: Improvement
>            Reporter: Justin Bertram
>            Assignee: Justin Bertram
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> In order to improve trouble-shooting for the MetricsManager there should be additional logging and exceptions.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)