You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by "DorrisRuixuanZhang (via GitHub)" <gi...@apache.org> on 2023/02/28 09:44:25 UTC
[GitHub] [kylin] DorrisRuixuanZhang opened a new pull request, #2098: Doc KYLIN-5447, KYLIN-5454
DorrisRuixuanZhang opened a new pull request, #2098:
URL: https://github.com/apache/kylin/pull/2098
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Branch to commit
- [ ] Branch **kylin3** for v2.x to v3.x
- [ ] Branch **kylin4** for v4.x
- [x] Branch **kylin5** for v5.x
## Types of changes
What types of changes does your code introduce to Kylin?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [x] Documentation Update (if none of the other choices apply)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on [Kylin's jira](https://issues.apache.org/jira/browse/KYLIN), and have described the bug/feature there in detail
- [x] Commit messages in my PR start with the related jira ID, like "KYLIN-0000 Make Kylin project open-source"
- [x] Compiling and unit tests pass locally with my changes
- [x] I have added tests that prove my fix is effective or that my feature works
- [x] I have added necessary documentation (if appropriate)
- [x] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at user@kylin.apache.org or dev@kylin.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] yabola commented on a diff in pull request #2098: Doc KYLIN-5447, KYLIN-5454
Posted by "yabola (via GitHub)" <gi...@apache.org>.
yabola commented on code in PR #2098:
URL: https://github.com/apache/kylin/pull/2098#discussion_r1121086205
##########
website/docs/datasource/logical_view.md:
##########
@@ -0,0 +1,53 @@
+---
+title: Logical View
+language: en
+sidebar_label: Logical View
+pagination_label: Logical View
+toc_min_heading_level: 2
+toc_max_heading_level: 6
+pagination_prev: null
+pagination_next: null
+keywords:
+ - logical view
+draft: false
+last_update:
+ date: 02/28/2023
+---
+
+## Logical View
+- Logical view is a special view maintained only in KYLIN rather than a real view in hive. Once created, you can use it like a normal Hive view.
+- Logical view feature is turned off by default, you can set `kylin.source.ddl.logical-view.enabled = true` to turn this feature on.
+- All logical views are in the same database, you can set the database name by the following parameters, be careful not to have the same name as the normal Hive database:
+ - `kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
Review Comment:
`kylin.source.ddl.logical-view.enabled = true`
`kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
please remove the spaces on both sides of `=`
##########
website/docs/datasource/logical_view.md:
##########
@@ -0,0 +1,53 @@
+---
+title: Logical View
+language: en
+sidebar_label: Logical View
+pagination_label: Logical View
+toc_min_heading_level: 2
+toc_max_heading_level: 6
+pagination_prev: null
+pagination_next: null
+keywords:
+ - logical view
+draft: false
+last_update:
+ date: 02/28/2023
+---
+
+## Logical View
+- Logical view is a special view maintained only in KYLIN rather than a real view in hive. Once created, you can use it like a normal Hive view.
+- Logical view feature is turned off by default, you can set `kylin.source.ddl.logical-view.enabled = true` to turn this feature on.
+- All logical views are in the same database, you can set the database name by the following parameters, be careful not to have the same name as the normal Hive database:
+ - `kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
+
+### Main operation flow
+1. Log in to KYLIN, and the login account must be:
+- System admin.
+- Have the Administrator or Project Administrator role for the target project.
+- User has Management Role.
+
+2. Click Data Assets - > Logical View to go to the main page of the logical view, you can enter SQL statements in the text box, and there are three tabs which can respectively manage the logical view tables, load the data source and display the syntax rules.
+
+3. Enter the `Create Logical View as...` statement in the SQL text box to create the logical view, noting that the database name is not required.
+4. After the view is created, you need to load the source table for Modeling to use. Since the logical view is newly created, you need to click "Refresh Now" first, then find the newly created logical view and then complete the loading.
+
+
+### Delete logical view
+1. On the main page of the logical view, you can enter SQL statement on the left: `DROP LOGICAL VIEW logical_view_db.your_logical_view;` to delete the logical view. Pay attention that the database name is needed.
+
+
+### View/Edit Logical View
+1. In the main interface of the logical view, click the 'Logical View Chart' (L) tab, you can see all the created logical views, those of current project will be pinned to the top, and those belonging to other projects will be grey out.
+2. Click the pencil icon next to the view to enter view/edit page.
+
+3. On this page, you can view the create view statement.
+4. To edit the table definition, click the 'create - > replace' icon
+
+5. You can see that `Create Logical View` in the edit box is replaced with `Replace Logical View`, and then you can modify the previous create table statement. In the following example, the condition of `where 1 = 1` is added.
+
Review Comment:
In the following example, the condition of `where 1 = 1` is added.
what does this mean..If it is useless please remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] DorrisRuixuanZhang commented on a diff in pull request #2098: Doc KYLIN-5447, KYLIN-5454
Posted by "DorrisRuixuanZhang (via GitHub)" <gi...@apache.org>.
DorrisRuixuanZhang commented on code in PR #2098:
URL: https://github.com/apache/kylin/pull/2098#discussion_r1121465692
##########
website/docs/datasource/logical_view.md:
##########
@@ -0,0 +1,53 @@
+---
+title: Logical View
+language: en
+sidebar_label: Logical View
+pagination_label: Logical View
+toc_min_heading_level: 2
+toc_max_heading_level: 6
+pagination_prev: null
+pagination_next: null
+keywords:
+ - logical view
+draft: false
+last_update:
+ date: 02/28/2023
+---
+
+## Logical View
+- Logical view is a special view maintained only in KYLIN rather than a real view in hive. Once created, you can use it like a normal Hive view.
+- Logical view feature is turned off by default, you can set `kylin.source.ddl.logical-view.enabled = true` to turn this feature on.
+- All logical views are in the same database, you can set the database name by the following parameters, be careful not to have the same name as the normal Hive database:
+ - `kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
+
+### Main operation flow
+1. Log in to KYLIN, and the login account must be:
+- System admin.
+- Have the Administrator or Project Administrator role for the target project.
+- User has Management Role.
+
+2. Click Data Assets - > Logical View to go to the main page of the logical view, you can enter SQL statements in the text box, and there are three tabs which can respectively manage the logical view tables, load the data source and display the syntax rules.
+
+3. Enter the `Create Logical View as...` statement in the SQL text box to create the logical view, noting that the database name is not required.
+4. After the view is created, you need to load the source table for Modeling to use. Since the logical view is newly created, you need to click "Refresh Now" first, then find the newly created logical view and then complete the loading.
+
+
+### Delete logical view
+1. On the main page of the logical view, you can enter SQL statement on the left: `DROP LOGICAL VIEW logical_view_db.your_logical_view;` to delete the logical view. Pay attention that the database name is needed.
+
+
+### View/Edit Logical View
+1. In the main interface of the logical view, click the 'Logical View Chart' (L) tab, you can see all the created logical views, those of current project will be pinned to the top, and those belonging to other projects will be grey out.
+2. Click the pencil icon next to the view to enter view/edit page.
+
+3. On this page, you can view the create view statement.
+4. To edit the table definition, click the 'create - > replace' icon
+
+5. You can see that `Create Logical View` in the edit box is replaced with `Replace Logical View`, and then you can modify the previous create table statement. In the following example, the condition of `where 1 = 1` is added.
+
Review Comment:
This should waits for the screenshot of kylin ui modifying the create logical view statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] yabola commented on a diff in pull request #2098: Doc KYLIN-5447, KYLIN-5454
Posted by "yabola (via GitHub)" <gi...@apache.org>.
yabola commented on code in PR #2098:
URL: https://github.com/apache/kylin/pull/2098#discussion_r1121086229
##########
website/docs/datasource/logical_view.md:
##########
@@ -0,0 +1,53 @@
+---
+title: Logical View
+language: en
+sidebar_label: Logical View
+pagination_label: Logical View
+toc_min_heading_level: 2
+toc_max_heading_level: 6
+pagination_prev: null
+pagination_next: null
+keywords:
+ - logical view
+draft: false
+last_update:
+ date: 02/28/2023
+---
+
+## Logical View
+- Logical view is a special view maintained only in KYLIN rather than a real view in hive. Once created, you can use it like a normal Hive view.
+- Logical view feature is turned off by default, you can set `kylin.source.ddl.logical-view.enabled = true` to turn this feature on.
+- All logical views are in the same database, you can set the database name by the following parameters, be careful not to have the same name as the normal Hive database:
+ - `kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
+
+### Main operation flow
+1. Log in to KYLIN, and the login account must be:
+- System admin.
+- Have the Administrator or Project Administrator role for the target project.
+- User has Management Role.
+
+2. Click Data Assets - > Logical View to go to the main page of the logical view, you can enter SQL statements in the text box, and there are three tabs which can respectively manage the logical view tables, load the data source and display the syntax rules.
+
+3. Enter the `Create Logical View as...` statement in the SQL text box to create the logical view, noting that the database name is not required.
+4. After the view is created, you need to load the source table for Modeling to use. Since the logical view is newly created, you need to click "Refresh Now" first, then find the newly created logical view and then complete the loading.
+
+
+### Delete logical view
+1. On the main page of the logical view, you can enter SQL statement on the left: `DROP LOGICAL VIEW logical_view_db.your_logical_view;` to delete the logical view. Pay attention that the database name is needed.
+
+
+### View/Edit Logical View
+1. In the main interface of the logical view, click the 'Logical View Chart' (L) tab, you can see all the created logical views, those of current project will be pinned to the top, and those belonging to other projects will be grey out.
+2. Click the pencil icon next to the view to enter view/edit page.
+
+3. On this page, you can view the create view statement.
+4. To edit the table definition, click the 'create - > replace' icon
+
+5. You can see that `Create Logical View` in the edit box is replaced with `Replace Logical View`, and then you can modify the previous create table statement. In the following example, the condition of `where 1 = 1` is added.
+
Review Comment:
> In the following example, the condition of `where 1 = 1` is added.
what does this mean..If it is useless please remove it
##########
website/docs/datasource/logical_view.md:
##########
@@ -0,0 +1,53 @@
+---
+title: Logical View
+language: en
+sidebar_label: Logical View
+pagination_label: Logical View
+toc_min_heading_level: 2
+toc_max_heading_level: 6
+pagination_prev: null
+pagination_next: null
+keywords:
+ - logical view
+draft: false
+last_update:
+ date: 02/28/2023
+---
+
+## Logical View
+- Logical view is a special view maintained only in KYLIN rather than a real view in hive. Once created, you can use it like a normal Hive view.
+- Logical view feature is turned off by default, you can set `kylin.source.ddl.logical-view.enabled = true` to turn this feature on.
+- All logical views are in the same database, you can set the database name by the following parameters, be careful not to have the same name as the normal Hive database:
+ - `kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
Review Comment:
>`kylin.source.ddl.logical-view.enabled = true`
`kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
please remove the spaces on both sides of `=`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] yabola commented on a diff in pull request #2098: Doc KYLIN-5447, KYLIN-5454
Posted by "yabola (via GitHub)" <gi...@apache.org>.
yabola commented on code in PR #2098:
URL: https://github.com/apache/kylin/pull/2098#discussion_r1121490525
##########
website/docs/datasource/logical_view.md:
##########
@@ -0,0 +1,53 @@
+---
+title: Logical View
+language: en
+sidebar_label: Logical View
+pagination_label: Logical View
+toc_min_heading_level: 2
+toc_max_heading_level: 6
+pagination_prev: null
+pagination_next: null
+keywords:
+ - logical view
+draft: false
+last_update:
+ date: 02/28/2023
+---
+
+## Logical View
+- Logical view is a special view maintained only in KYLIN rather than a real view in hive. Once created, you can use it like a normal Hive view.
+- Logical view feature is turned off by default, you can set `kylin.source.ddl.logical-view.enabled = true` to turn this feature on.
+- All logical views are in the same database, you can set the database name by the following parameters, be careful not to have the same name as the normal Hive database:
+ - `kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
+
+### Main operation flow
+1. Log in to KYLIN, and the login account must be:
+- System admin.
+- Have the Administrator or Project Administrator role for the target project.
+- User has Management Role.
+
+2. Click Data Assets - > Logical View to go to the main page of the logical view, you can enter SQL statements in the text box, and there are three tabs which can respectively manage the logical view tables, load the data source and display the syntax rules.
+
+3. Enter the `Create Logical View as...` statement in the SQL text box to create the logical view, noting that the database name is not required.
+4. After the view is created, you need to load the source table for Modeling to use. Since the logical view is newly created, you need to click "Refresh Now" first, then find the newly created logical view and then complete the loading.
+
+
+### Delete logical view
+1. On the main page of the logical view, you can enter SQL statement on the left: `DROP LOGICAL VIEW logical_view_db.your_logical_view;` to delete the logical view. Pay attention that the database name is needed.
+
+
+### View/Edit Logical View
+1. In the main interface of the logical view, click the 'Logical View Chart' (L) tab, you can see all the created logical views, those of current project will be pinned to the top, and those belonging to other projects will be grey out.
+2. Click the pencil icon next to the view to enter view/edit page.
+
+3. On this page, you can view the create view statement.
+4. To edit the table definition, click the 'create - > replace' icon
+
+5. You can see that `Create Logical View` in the edit box is replaced with `Replace Logical View`, and then you can modify the previous create table statement. In the following example, the condition of `where 1 = 1` is added.
+
Review Comment:
`where 1 = 1` is confused, add a condition like `where c1 = xx` is more meaningful
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] DorrisRuixuanZhang commented on a diff in pull request #2098: Doc KYLIN-5447, KYLIN-5454
Posted by "DorrisRuixuanZhang (via GitHub)" <gi...@apache.org>.
DorrisRuixuanZhang commented on code in PR #2098:
URL: https://github.com/apache/kylin/pull/2098#discussion_r1121465692
##########
website/docs/datasource/logical_view.md:
##########
@@ -0,0 +1,53 @@
+---
+title: Logical View
+language: en
+sidebar_label: Logical View
+pagination_label: Logical View
+toc_min_heading_level: 2
+toc_max_heading_level: 6
+pagination_prev: null
+pagination_next: null
+keywords:
+ - logical view
+draft: false
+last_update:
+ date: 02/28/2023
+---
+
+## Logical View
+- Logical view is a special view maintained only in KYLIN rather than a real view in hive. Once created, you can use it like a normal Hive view.
+- Logical view feature is turned off by default, you can set `kylin.source.ddl.logical-view.enabled = true` to turn this feature on.
+- All logical views are in the same database, you can set the database name by the following parameters, be careful not to have the same name as the normal Hive database:
+ - `kylin.source.ddl.logical-view.database = KYLIN_LOGICAL_VIEW`
+
+### Main operation flow
+1. Log in to KYLIN, and the login account must be:
+- System admin.
+- Have the Administrator or Project Administrator role for the target project.
+- User has Management Role.
+
+2. Click Data Assets - > Logical View to go to the main page of the logical view, you can enter SQL statements in the text box, and there are three tabs which can respectively manage the logical view tables, load the data source and display the syntax rules.
+
+3. Enter the `Create Logical View as...` statement in the SQL text box to create the logical view, noting that the database name is not required.
+4. After the view is created, you need to load the source table for Modeling to use. Since the logical view is newly created, you need to click "Refresh Now" first, then find the newly created logical view and then complete the loading.
+
+
+### Delete logical view
+1. On the main page of the logical view, you can enter SQL statement on the left: `DROP LOGICAL VIEW logical_view_db.your_logical_view;` to delete the logical view. Pay attention that the database name is needed.
+
+
+### View/Edit Logical View
+1. In the main interface of the logical view, click the 'Logical View Chart' (L) tab, you can see all the created logical views, those of current project will be pinned to the top, and those belonging to other projects will be grey out.
+2. Click the pencil icon next to the view to enter view/edit page.
+
+3. On this page, you can view the create view statement.
+4. To edit the table definition, click the 'create - > replace' icon
+
+5. You can see that `Create Logical View` in the edit box is replaced with `Replace Logical View`, and then you can modify the previous create table statement. In the following example, the condition of `where 1 = 1` is added.
+
Review Comment:
This should wait for the screenshot of kylin ui modifying the create logical view statement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kylin] hit-lacus merged pull request #2098: Doc KYLIN-5447, KYLIN-5454
Posted by "hit-lacus (via GitHub)" <gi...@apache.org>.
hit-lacus merged PR #2098:
URL: https://github.com/apache/kylin/pull/2098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@kylin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org