You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "tustvold (via GitHub)" <gi...@apache.org> on 2023/10/23 15:48:44 UTC
[PR] Support ImdsManagedIdentityProvider in Azure Functions (#4976) [arrow-rs]
tustvold opened a new pull request, #4977:
URL: https://github.com/apache/arrow-rs/pull/4977
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes #4976
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Tweaks the ImdsManagedIdentityProvider to not rely on a field that isn't consistently returned by all IMDS endpoints. Azure continues to achieve new innovative levels of inconsistency...
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support ImdsManagedIdentityProvider in Azure Functions (#4976) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4977:
URL: https://github.com/apache/arrow-rs/pull/4977#issuecomment-1775690835
@tahaum are you able to test this out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support ImdsManagedIdentityProvider in Azure Functions (#4976) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4977:
URL: https://github.com/apache/arrow-rs/pull/4977#issuecomment-1777057265
Aah I see you are using delta-rs via the python bindings, yeah that would be fiddly, I'll test this out before I cut the next release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support ImdsManagedIdentityProvider in Azure Functions (#4976) [arrow-rs]
Posted by "tahaum (via GitHub)" <gi...@apache.org>.
tahaum commented on PR #4977:
URL: https://github.com/apache/arrow-rs/pull/4977#issuecomment-1777073979
Ok, great! 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support ImdsManagedIdentityProvider in Azure Functions (#4976) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4977:
URL: https://github.com/apache/arrow-rs/pull/4977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support ImdsManagedIdentityProvider in Azure Functions (#4976) [arrow-rs]
Posted by "tahaum (via GitHub)" <gi...@apache.org>.
tahaum commented on PR #4977:
URL: https://github.com/apache/arrow-rs/pull/4977#issuecomment-1777045526
@tustvold No, how can I easily test this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Support ImdsManagedIdentityProvider in Azure Functions (#4976) [arrow-rs]
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4977:
URL: https://github.com/apache/arrow-rs/pull/4977#issuecomment-1776049283
I have confirmed this does not break the pre-existing support for virtual machines
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org