You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/01/18 19:52:26 UTC
[jira] [Commented] (BEAM-1279) Composite nodes should never be able
to produce primitive output
[ https://issues.apache.org/jira/browse/BEAM-1279?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15828670#comment-15828670 ]
ASF GitHub Bot commented on BEAM-1279:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/1788
[BEAM-1279] Ensure Composite Nodes produce no output
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
Travis-CI on your fork and ensure the whole test matrix passes).
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam no_composite_primitives
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/1788.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1788
----
commit d07af5ce4feacf596a6d6a7ad09b8f0c782ebcd5
Author: Thomas Groh <tg...@google.com>
Date: 2017-01-18T19:45:25Z
Ensure Composite Nodes produce no output
----
> Composite nodes should never be able to produce primitive output
> ----------------------------------------------------------------
>
> Key: BEAM-1279
> URL: https://issues.apache.org/jira/browse/BEAM-1279
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Thomas Groh
>
> If a composite PTransform only outputs PCollections that it produces, but also applies other PTransforms to its inputs, TransformHierarchy should catch this. Currently it determines that the node must be a primitive, even though it has component nodes.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)