You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/06/16 21:21:42 UTC
[GitHub] [nifi] alopresto opened a new pull request #4340: NIFI-7541 Increased TestListenSMTP timeout for Windows to resolve CI/…
alopresto opened a new pull request #4340:
URL: https://github.com/apache/nifi/pull/4340
…CD build failures.
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
#### Description of PR
_Enables X functionality; fixes bug NIFI-YYYY._
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically `master`)?
- [x] Is your initial contribution a single, squashed commit? _Additional commits in response to PR reviewer feedback should be made on this branch and pushed to allow change tracking. Do not `squash` or use `--force` when pushing to allow for clean monitoring of changes._
### For code changes:
- [ ] Have you ensured that the full suite of tests is executed via `mvn -Pcontrib-check clean install` at the root `nifi` folder?
- [x] Have you written or updated unit tests to verify your changes?
- [ ] Have you verified that the full build is successful on JDK 8?
- [x] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main `LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main `NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for build issues and submit an update to your PR as soon as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4340: NIFI-7541 Increased TestListenSMTP timeout for Windows to resolve CI/…
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4340:
URL: https://github.com/apache/nifi/pull/4340#issuecomment-645082064
Although now it does seem to be failing on the same issue as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4340: NIFI-7541 Increased TestListenSMTP timeout for Windows to resolve CI/…
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4340:
URL: https://github.com/apache/nifi/pull/4340#issuecomment-645081823
Thanks Joey. Once I increased the timeout, it did complete that test successfully and failed on the `ZooKeeperMigratorTest` in a similar situation. If the underlying platform is now less stable, we should address it, but it seems like these at least progress the build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee edited a comment on pull request #4340: NIFI-7541 Increased TestListenSMTP timeout for Windows to resolve CI/…
Posted by GitBox <gi...@apache.org>.
jfrazee edited a comment on pull request #4340:
URL: https://github.com/apache/nifi/pull/4340#issuecomment-645026124
@alopresto I had been working on fixes for this for the macOS build failures in #4341 and I think it probably addresses the Windows failures too. AFAICT the timeouts were hiding some threading issues in the way ListenSMTP was being created in the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto commented on pull request #4340: NIFI-7541 Increased TestListenSMTP timeout for Windows to resolve CI/…
Posted by GitBox <gi...@apache.org>.
alopresto commented on pull request #4340:
URL: https://github.com/apache/nifi/pull/4340#issuecomment-645622645
Closing because PR 4341 was merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] alopresto closed pull request #4340: NIFI-7541 Increased TestListenSMTP timeout for Windows to resolve CI/…
Posted by GitBox <gi...@apache.org>.
alopresto closed pull request #4340:
URL: https://github.com/apache/nifi/pull/4340
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee commented on pull request #4340: NIFI-7541 Increased TestListenSMTP timeout for Windows to resolve CI/…
Posted by GitBox <gi...@apache.org>.
jfrazee commented on pull request #4340:
URL: https://github.com/apache/nifi/pull/4340#issuecomment-645026124
@alopresto I had been working on fixes for this for the macOS build failures in #4341 and I think it probably addresses the Windows failures too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] jfrazee edited a comment on pull request #4340: NIFI-7541 Increased TestListenSMTP timeout for Windows to resolve CI/…
Posted by GitBox <gi...@apache.org>.
jfrazee edited a comment on pull request #4340:
URL: https://github.com/apache/nifi/pull/4340#issuecomment-645026124
@alopresto I had been working on fixes for this for the macOS build failures in #4341 and I think it probably addresses the Windows failures too. AFAICT successive increases in the timeouts were hiding some threading issues in the way ListenSMTP was being created in the tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org