You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@nifi.apache.org by pvillard31 <gi...@git.apache.org> on 2016/04/15 16:50:17 UTC
[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...
GitHub user pvillard31 opened a pull request:
https://github.com/apache/nifi/pull/357
NIFI-1777 Prevent deleting a connection going to a running processor
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pvillard31/nifi NIFI-1777
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/357.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #357
----
commit de8b65e3b16f0185029fd53f201334347e0f5ffd
Author: Pierre Villard <pi...@gmail.com>
Date: 2016-04-15T14:49:47Z
NIFI-1777 Prevent deleting a connection going to a running processor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/357#issuecomment-211319503
@pvillard31 also, when you submit PR click on "Submit Patch" in JIRA (without writing anything in description). I know it may be a bit awkward but this is how we signal that JIRA is ready for review/resolution.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...
Posted by pvillard31 <gi...@git.apache.org>.
Github user pvillard31 commented on the pull request:
https://github.com/apache/nifi/pull/357#issuecomment-211276565
@olegz You're right, just added a unit test. (Note: I believe that travis build failure is not related to this PR)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/357#issuecomment-211079403
@pvillard31 I know this is a simple one, but would you consider adding a simple unit test for it as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/357#issuecomment-211322321
Was able to validate that when/if someone attempts to delete a connected processor a window pops up with the error message "Destination of Connection (LogAttribute[id=7a37a5bb-1017-4732-8c31-a6c1f44eea18]) is running". So all good, adequate tests provided, +1.
@mcgilman @scottyaslan perhaps in the future we can further address it (as an additional feature) in the UI and disable "Delete" option all together.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...
Posted by olegz <gi...@git.apache.org>.
Github user olegz commented on the pull request:
https://github.com/apache/nifi/pull/357#issuecomment-211318338
Perfect, reviewing now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request: NIFI-1777 Prevent deleting a connection going t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/357
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---