You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/28 07:19:27 UTC

[jclouds] Accidentally set limited json fallback field naming to an enum. (#589)

In docker, I need to set a custom field naming policy that isn&#39;t in the enum, as certain names are not normal case. Ex. IP not Ip.
You can merge this Pull Request by running:

  git pull https://github.com/adriancole/jclouds adrian.whoops-too-tight

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/589

-- Commit Summary --

  * Accidentally set limited json fallback field naming to an enum.

-- File Changes --

    M core/src/main/java/org/jclouds/json/config/GsonModule.java (86)
    M core/src/main/java/org/jclouds/json/internal/NamingStrategies.java (7)
    M core/src/test/java/org/jclouds/json/JsonTest.java (5)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/589.patch
https://github.com/jclouds/jclouds/pull/589.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/589

Re: [jclouds] Accidentally set limited json fallback field naming to an enum. (#589)

Posted by Adrian Cole <no...@github.com>.
picked into master, 1.8.x

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/589#issuecomment-60718017

Re: [jclouds] Accidentally set limited json fallback field naming to an enum. (#589)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #1357](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/1357/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/589#issuecomment-60715975

Re: [jclouds] Accidentally set limited json fallback field naming to an enum. (#589)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests-java-7 #268](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests-java-7/268/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/589#issuecomment-60715524

Re: [jclouds] Accidentally set limited json fallback field naming to an enum. (#589)

Posted by BuildHive <no...@github.com>.
[jclouds ยป jclouds #1873](https://buildhive.cloudbees.com/job/jclouds/job/jclouds/1873/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/589#issuecomment-60717718

Re: [jclouds] Accidentally set limited json fallback field naming to an enum. (#589)

Posted by Adrian Cole <no...@github.com>.
cc @nacx @zack-shoylev @andreaturli This change will allow us to not need `@SerializedName` in most cases. watch for an example on https://github.com/jclouds/jclouds-labs/pull/102 soon.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/589#issuecomment-60714488

Re: [jclouds] Accidentally set limited json fallback field naming to an enum. (#589)

Posted by Adrian Cole <no...@github.com>.
> @@ -16,6 +16,45 @@
>   */
>  package org.jclouds.json.config;
>  
> +import static com.google.common.io.BaseEncoding.base16;

forgive me.. I couldn't help reformatting imports.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/589/files#r19454722